DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
	Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map
Date: Thu, 30 Jun 2016 19:58:50 +0200	[thread overview]
Message-ID: <4355072.3dvfNtBY6m@xps13> (raw)
In-Reply-To: <57712511.3020806@intel.com>

> Hi Thomas,
> 
> I got the duplicates with following command [1], does it make sense to
> add this into one of the check scripts, -not sure which one?
> 
> [1]
> # for m in $(find . -name *_version.map); do for l in $(cat $m | sort |
> uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";"
> -f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l;
> fi; done; done
> 

I have started to write a script to check symbol export.
Feel free to start a new script scripts/check-symbols.sh with this
check for duplicated symbols in .map.
I will add my checks later in this script.

Thanks

  reply	other threads:[~2016-06-30 17:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-25 13:10 [dpdk-dev] [PATCH] mempool: fix symbol export Thomas Monjalon
2016-06-25 16:49 ` Olivier Matz
2016-06-27 15:03   ` Thomas Monjalon
     [not found] ` <1467032271-10116-1-git-send-email-y>
2016-06-27 13:02   ` [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from .map Ferruh Yigit
2016-06-27 13:02 ` Ferruh Yigit
2016-06-27 13:02   ` [dpdk-dev] [PATCH 2/3] cmdline: " Ferruh Yigit
2016-06-27 15:55     ` Olivier MATZ
2016-06-27 13:02   ` [dpdk-dev] [PATCH 3/3] port: " Ferruh Yigit
2016-06-27 13:13     ` Dumitrescu, Cristian
2016-06-27 13:07   ` [dpdk-dev] [PATCH 1/3] ethdev: " Ferruh Yigit
2016-06-30 17:58     ` Thomas Monjalon [this message]
2016-06-30 18:03   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4355072.3dvfNtBY6m@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).