From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id EAFE93978
 for <dev@dpdk.org>; Thu, 30 Jun 2016 19:59:54 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id r201so129841575wme.1
 for <dev@dpdk.org>; Thu, 30 Jun 2016 10:59:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=95aNrmAasApvjbgitPsTDlbgLgE3pKeUsJ1vTIeq16s=;
 b=qaTARBO9puZmPk/yJEYuvxPMWi+pIGNNqk1KI2mnDx1/m/GYflBxWJ22z4mzwTKzqH
 bjbGYOQtg/mgZwuSTIMuYvPa+k/++Pb7a7qztBUZXtNyWGqC0eWJpa5ttOTOZyOv+s/H
 iBrOcW5iDAjm8rY2FvIBYHMfRh784z8Iu6FIL5+f/a7nQpFS+VyUq30OeaodccNPKCvK
 3VCdzArrUMSkgUwIpyBi0RvX3KG3oa5VX6x6MA6Z/2XTvX2FtPsbya04Z/6jsQGUuUPk
 tAf0goZ30jL4VLT2Yh/sFZkAcNKZJKYGWELBE4q1whUurZC/b30OFRg+fjO9H4VaaH8E
 fgog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=95aNrmAasApvjbgitPsTDlbgLgE3pKeUsJ1vTIeq16s=;
 b=YxuozLQ3zZqjki8ybIn3Rxa/3q8RT5yw2OSCB8Xn4zJ31+X+afDpmUMDQikU1HNXnN
 DPuKAj+b6Ob3fEhSfpPpe/xu3VS1aTNTC73+G9b26slgYEor8o+HPjf05vkhQJVWSWwj
 1ejn/OrhWAwV83m/ro9yvkn9WTfJxe37yHIRF0rBt77JBqDLV8t1lJ1vP9MI7HZTEN9E
 bVy/K/4mg/0UazUR6vf7r4y9vEEzJOWhGfNlZEE7PvHRfeS+07Jr+DLSi+e62huUQcAR
 KfhrmLHoOsjV64r45cN5Ebj1KQ1KLTjtnFPjd9cC/Bm8ofpMOau91ISHbCfjzj8oVBG5
 AB0w==
X-Gm-Message-State: ALyK8tJJTNtcSn+9SMdn469/1zQ4D8p6laOret2lBWdSH5GQtpXuuGJ3oeqHoafXJ2ygrwit
X-Received: by 10.28.64.213 with SMTP id n204mr29026480wma.7.1467309594740;
 Thu, 30 Jun 2016 10:59:54 -0700 (PDT)
Received: from xps13.localnet (184.16.90.92.rev.sfr.net. [92.90.16.184])
 by smtp.gmail.com with ESMTPSA id p191sm4098313wme.7.2016.06.30.10.59.53
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 30 Jun 2016 10:59:53 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Date: Thu, 30 Jun 2016 19:58:50 +0200
Message-ID: <4355072.3dvfNtBY6m@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <57712511.3020806@intel.com>
References: <1466860257-4068-1-git-send-email-thomas.monjalon@6wind.com>
 <1467032551-14979-1-git-send-email-ferruh.yigit@intel.com>
 <57712511.3020806@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: remove duplicated symbols from
	.map
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jun 2016 17:59:55 -0000

> Hi Thomas,
> 
> I got the duplicates with following command [1], does it make sense to
> add this into one of the check scripts, -not sure which one?
> 
> [1]
> # for m in $(find . -name *_version.map); do for l in $(cat $m | sort |
> uniq -d | grep -v global | grep -v local); do ll=$(echo $l | cut -d";"
> -f1); git grep -q "VERSION_SYMBOL.$ll"; if [ $? -eq 1 ]; then echo $l;
> fi; done; done
> 

I have started to write a script to check symbol export.
Feel free to start a new script scripts/check-symbols.sh with this
check for duplicated symbols in .map.
I will add my checks later in this script.

Thanks