From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f178.google.com (mail-qk0-f178.google.com [209.85.220.178]) by dpdk.org (Postfix) with ESMTP id 1EFDC6CD2 for ; Wed, 12 Oct 2016 18:06:48 +0200 (CEST) Received: by mail-qk0-f178.google.com with SMTP id f128so37729800qkb.1 for ; Wed, 12 Oct 2016 09:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=h/ze9vgQfLtPSowBg6m/f74SQ9tN4XiLFajr7C14+aY=; b=uiHcwonFkbJ78J/CTdWnciVc6yeNZ+HdmEIsPMXkl6g3pK3RAzern3m/5YA71c+Ohu ToiS7TVaQAqURMY3P4CKhouPaGtTyekJamimFsjeoryhr7Uo/TbaWTqlq/548lb5HhTB VVTKvUKXUBJtFUIqwCJAPchNTwz8vuO8nqKLEkeeAD+nfFTuu5dmdJJk02USB1irsYKm hx3CDpv0L5TxzIHgcFXWeMw8dHVGhmZAoI4lxYh1J8+GusvjM3K8R9gImUcPA09yJuZz vMojYB7+j7rz1Tox/dtUR1cp6CfwXZzz3BB8IeJ7F7AdXl/3gyGkZ+XEeyteE6g78zj8 8OFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=h/ze9vgQfLtPSowBg6m/f74SQ9tN4XiLFajr7C14+aY=; b=SeOUBKbkmQ7vRBpLu2dU6MHA9w2hwK/g9iXOFtOAWH86LQmqDbaXQclPsYcTLJ+kXP H/HxGwJgfcsnYZcbH33Al8X2svz8y7k1krjGyjPz77Jw7t5FjWTiZCaPMbJT158pL7cG HEXsy/FQA3mfoJ3cIwQ8ea0D7zNUW+xc+dui1a3pVzaOf+4QDNSYO53lHZnwBfq3bwSU RZrVMkXvV4NVZoDkwk552NwIV55CPsJxEGOMz642ClCqKv+/u5Vqbs4HAbSS3sC5v89A mPKzTW14yOCMcvMu+Gi6aqInVE/WG7SC+iAINh3qgfFnEKsBM+7nQPxK8xk99mEjC7WM zWmw== X-Gm-Message-State: AA6/9RnHZ4sq3cqItIgNDJddFZ+Emp/5RjUtCELjUlWKaLK4Ygk+j8PzTl2uTJu9rLyMdgbf X-Received: by 10.194.94.168 with SMTP id dd8mr2587588wjb.96.1476288407455; Wed, 12 Oct 2016 09:06:47 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id p9sm14058216wjs.11.2016.10.12.09.06.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Oct 2016 09:06:46 -0700 (PDT) From: Thomas Monjalon To: "Iremonger, Bernard" Cc: dev@dpdk.org, "Shah, Rahul R" , "Lu, Wenzhuo" , "az5157@att.com" , "De Lara Guarch, Pablo" Date: Wed, 12 Oct 2016 18:06:45 +0200 Message-ID: <4355552.XQIr0B1y70@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A09209C@IRSMSX108.ger.corp.intel.com> References: <1475858784-5303-1-git-send-email-bernard.iremonger@intel.com> <2791430.Y8ncTCNxt5@xps13> <8CEF83825BEC744B83065625E567D7C21A09209C@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new API's X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 16:06:48 -0000 2016-10-12 15:48, Iremonger, Bernard: > Hi Thomas, > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for new > > API's > > > > 2016-10-12 15:27, Iremonger, Bernard: > > > Hi Thomas, > > > > > > > > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 2/2] app/test_pmd: add tests for > > > > new API's > > > > > > > > 2016-10-12 16:03, Bernard Iremonger: > > > > > --- a/app/test-pmd/Makefile > > > > > +++ b/app/test-pmd/Makefile > > > > > @@ -58,6 +58,17 @@ SRCS-y += csumonly.c SRCS-y += icmpecho.c > > > > > SRCS-$(CONFIG_RTE_LIBRTE_IEEE1588) += ieee1588fwd.c > > > > > > > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) > > > > > +LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > endif > > > > > + > > > > > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > > > > > +ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > > > > > +LDLIBS += -lrte_pmd_ixgbe > > > > > +endif > > > > > +endif > > > > > > > > Sorry if I miss something, but I thought it was enough to do: > > > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > > > > > No unfortunately not, the above line does not work for all scenarios . > > > > > > There are 4 scenarios as follows: > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=y with > > CONFIG_RTE_BUILD_SHARED_LIB=n > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=y with > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=n with > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > CONFIG_RTE_LIBRTE_IXGBE_PMD=n with > > CONFIG_RTE_BUILD_SHARED_LIB=n > > > > > > I have been doing quite a bit of building today to get it to work in all 4 > > scenarios. > > > > I have a doubt about the tests because LDLIBS-y does not exist. > > There is _LDLIBS-y and LDLIBS. > > But in the static case, you wrote: > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe > > endif Please could you check? > > LDLIBS-y exists in some of the scenarios but not all. I think I'm something obvious. Please could you point the line where LDLIBS-y is used? > Do you want me to check the four scenarios with just the line below. > > LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe Let's check the theory first :)