From: Thomas Monjalon <thomas@monjalon.net>
To: Somalapuram Amaranath <asomalap@amd.com>,
David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Akhil Goyal <gakhil@marvell.com>,
"Ravi1.Kumar@amd.com" <ravi1.kumar@amd.com>,
"keesang.song@amd.com" <keesang.song@amd.com>
Subject: Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP
Date: Thu, 27 May 2021 16:10:13 +0200 [thread overview]
Message-ID: <4362836.01VGQip8NV@thomas> (raw)
In-Reply-To: <CAJFAV8wtnF+mNjkFaemBAYuz8cZDCWybURC3054Kd8udv+OzqA@mail.gmail.com>
27/05/2021 15:24, David Marchand:
> On Fri, Dec 25, 2020 at 9:06 AM <asomalap@amd.com> wrote:
> >
> > From: Amaranath Somalapuram <Amaranath.Somalapuram@amd.com>
> >
> > CCP use vdev framework, and vdev framework don’t support IOMMU.
> > Adding custom IOMMU support for AMD CCP driver.
>
> I am currently looking at pci bus patches/cleanups.
> I ended up looking at crypto/ccp.
> This driver code contains a lot of features duplicated with the pci bus.
>
> Why is the ccp driver not a PCI driver?
Indeed it looks abusing vdev.
We should drop all the code duplicating the PCI bus driver.
If nothing else is done, it would mean breaking the probing
of this driver.
Adding more people in Cc list to have a fix before it is broken,
thanks.
next prev parent reply other threads:[~2021-05-27 14:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 8:38 [dpdk-dev] [PATCH v2] " asomalap
2020-02-12 7:11 ` Akhil Goyal
2020-02-12 7:44 ` Somalapuram, Amaranath
2020-02-12 10:05 ` Akhil Goyal
2020-02-12 10:31 ` Kumar, Ravi1
2020-02-12 13:50 ` Akhil Goyal
2020-02-14 15:53 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-12-25 8:03 ` [dpdk-dev] [PATCH v3] " asomalap
2021-01-15 15:58 ` Akhil Goyal
2021-05-27 13:24 ` David Marchand
2021-05-27 14:10 ` Thomas Monjalon [this message]
2021-05-28 5:02 ` Somalapuram, Amaranath
2021-05-28 7:20 ` Thomas Monjalon
2021-05-28 9:40 ` Somalapuram, Amaranath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4362836.01VGQip8NV@thomas \
--to=thomas@monjalon.net \
--cc=asomalap@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=keesang.song@amd.com \
--cc=ravi1.kumar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).