From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04163A0546; Thu, 27 May 2021 16:10:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9EC340150; Thu, 27 May 2021 16:10:23 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 6296A40143 for ; Thu, 27 May 2021 16:10:21 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 903685C00E5; Thu, 27 May 2021 10:10:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 27 May 2021 10:10:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= dkU/Oy248tpUDClqarK7D8gqZuc4BcNPrDbKVq4cLyM=; b=Do4UMG2W380Feyx2 brmIaHCHRp0td6D7LTKwjP1Bfx8MK7udrHKUAHX5+hNc1VHF+k4m9maE424MVG/n rVtFohpPEbQq1NFkt+NMFnDAgsmT8QL7CmolBB1nqSeQx6M5NIoTMEWeqBsl+m+a 8VZjqMDlWmI07mNHbdlseIBAka+eTf6oNYllReNAaPXqVJELbWdfYQzdFPHbJGKy ohToxHrq57T6RIMT8Q+M3RfjvkcIT4S9Zsksf2GUIVbbQ9/U/p0C95pczOQSrfJG TgefeBeKlSgLlXtj7bl8TrmripKjq4W0YTHbVHexXHRu9eSNwZD4UjQLMLfMhum0 SKrT3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=dkU/Oy248tpUDClqarK7D8gqZuc4BcNPrDbKVq4cL yM=; b=LFR1SEUbh+YAB7tUISJdXmLkyizk8DL80EXRiY9W1TX5tMAz4XlvmOGZ7 mYH1KRs8UINJDnP/MLhOEeW6ILOapeSRpjSxZobhkQ9L3TTbz/IPUXkA0FkFs5A3 HkiAZfztQbRWmxV9JAkL6GH/7G6Ns7jQw74DVgvwDrKH3JKmU+Zy+OHihrhR7VRN vKyEoNZe7OS7D/Fa4Ca2r/I3ZWLzSPD0xTETTOCPh3IcCKxfbLwJnxb6RroqrLV2 JnoKrAv3SoRHNZ2VTX86hnTZmmFxFIY+tBiJg0cxo3YpQw6GHAsY9hAB8Q+TZFO6 /kXstnf+0U924VbxA8llZPkVSEn0g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdekhedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeethedtieevhfeigeejleegudefjeehkeekteeuveeiuedvveeu tdejveehveetnecukfhppeejjedrvddthedrieelrddugeejnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (147.69.205.77.rev.sfr.net [77.205.69.147]) by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 27 May 2021 10:10:17 -0400 (EDT) From: Thomas Monjalon To: Somalapuram Amaranath , David Marchand Cc: dev , Akhil Goyal , "Ravi1.Kumar@amd.com" , "keesang.song@amd.com" Date: Thu, 27 May 2021 16:10:13 +0200 Message-ID: <4362836.01VGQip8NV@thomas> In-Reply-To: References: <20200128083819.32834-1-asomalap@amd.com> <20201225080358.366162-1-asomalap@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] crypto/ccp: enable IOMMU for CCP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/05/2021 15:24, David Marchand: > On Fri, Dec 25, 2020 at 9:06 AM wrote: > > > > From: Amaranath Somalapuram > > > > CCP use vdev framework, and vdev framework don=E2=80=99t support IOMMU. > > Adding custom IOMMU support for AMD CCP driver. >=20 > I am currently looking at pci bus patches/cleanups. > I ended up looking at crypto/ccp. > This driver code contains a lot of features duplicated with the pci bus. >=20 > Why is the ccp driver not a PCI driver? Indeed it looks abusing vdev. We should drop all the code duplicating the PCI bus driver. If nothing else is done, it would mean breaking the probing of this driver. Adding more people in Cc list to have a fix before it is broken, thanks.