From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0F1DA0C40; Thu, 5 Aug 2021 15:57:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9237441273; Thu, 5 Aug 2021 15:57:26 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 941B940040 for ; Thu, 5 Aug 2021 15:57:24 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="214184346" X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="214184346" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Aug 2021 06:57:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,296,1620716400"; d="scan'208";a="586218227" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 05 Aug 2021 06:57:21 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 06:57:20 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 5 Aug 2021 06:57:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 5 Aug 2021 06:57:20 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 5 Aug 2021 06:57:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KDmnFZx+Jvzx47m9CP5FwpfX1ryH1e12g59Q5lL9S68lljlaukgxB+NLZ46mnjJomS66dtdulY+7g6EDx9KYdPpZA/CBPgg+D9yyGXKhkGHI4ELAnO/jVXoQedxaUvddAEmjpjGOIhVqPp6FxGGW+63SkqJL6B/hnzqAs0g/WRgc+KRzHXJgVy4AF+fxs0hG+HBBk8UT09XBs9p+4u5Iiuh+wDtQrGbGPqYN12gpi4L4nVXyig7EWNSGsikYisqVHvmwvtj8gDK+BTItM3G/PEw99z9StSYeuuPYOl1VmPSJNpaLcgOYcXOpZ86P+Os0RNdcxxvXbJEfzBcV9P/6gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQsNNR25+f1EqDQ69zdTyFE2BmlI8AjvDPf5xVWW6eU=; b=ciQwOF7sUAcMClN/uitQr5R7/zYwctJl4i7N1QqDeHBPndH1skUZGWD3Dv5DWcNgKoA3w6ZT1Fyw1zhdjld0oohSRTr48zUhHNlDu2JDlYdXB9eYbvEFjwwiKLWUXRaOBeibw1LzApu/m1nNgAUfeYaVPskdpM4hSmcVUtd6NhmrdqFDjqHQwIOa6Aa0NSQMu4CWbUrX9xxR7gEzPL1DgU3j1NzuKg5fswlIEhMsy+wKR11ECWDaJIHOOUXOreNzf3tppK3a6zwrOgzn1BkXEEOHELCLr9uYEBlQ0CSw0PWHw/bf4GAFMX5mb7fx2Uf/NGjjNC/4C/5M87oAbfnp8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQsNNR25+f1EqDQ69zdTyFE2BmlI8AjvDPf5xVWW6eU=; b=zEQdH3CPcrdqRgxJGGadyloF1LLSlIPPUeRws/CZI+Q65OroTBUBfAl7VXZaNtw+GYIqUjDkqkWxsa7Ql92TctSEVQ0UcwdtUOwudK6H/cMiNjVPbGxk8Ep5Flud5N6yNgQtuvDinLUfkg0EHMfjlD+7TxaceWwDwcN9GsM0uH0= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB5012.namprd11.prod.outlook.com (2603:10b6:303:90::18) by CO1PR11MB4835.namprd11.prod.outlook.com (2603:10b6:303:9e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.19; Thu, 5 Aug 2021 13:57:19 +0000 Received: from CO1PR11MB5012.namprd11.prod.outlook.com ([fe80::8dc5:29c1:180e:11fc]) by CO1PR11MB5012.namprd11.prod.outlook.com ([fe80::8dc5:29c1:180e:11fc%6]) with mapi id 15.20.4373.026; Thu, 5 Aug 2021 13:57:19 +0000 To: Jan Viktorin CC: "dev@dpdk.org" References: <20210805151451.59932409@coaster.localdomain> <32cb2d90-2a08-ec06-0c71-031b6187c472@intel.com> <20210805153201.0f6a1dee@coaster.localdomain> From: "Medvedkin, Vladimir" Message-ID: <4369f1c3-c9f6-693a-5b21-1a5a4774478d@intel.com> Date: Thu, 5 Aug 2021 15:57:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 In-Reply-To: <20210805153201.0f6a1dee@coaster.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0311.eurprd04.prod.outlook.com (2603:10a6:10:2b5::16) To CO1PR11MB5012.namprd11.prod.outlook.com (2603:10b6:303:90::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.198.151.51] (192.198.151.51) by DU2PR04CA0311.eurprd04.prod.outlook.com (2603:10a6:10:2b5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Thu, 5 Aug 2021 13:57:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90f9f79b-c2de-465a-16fd-08d95818f0f6 X-MS-TrafficTypeDiagnostic: CO1PR11MB4835: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gf7Tg2b6L46hRMe3LBVak5bw8UTlj1U++IXeH8M4YAebVgaKu1H9VTitB5NQsxa5iziP1TnV4wskK8MFQVcfY+oWvg0C9P0ym0JNcP2c8tKgEaRemJmR2iJcOy/t63qM7IL7Gzy6H/L0bRLUx55K6PgloRNuMNTr7jQabXvlknnqrnm7kHUtfgPfqXfMvyGSjLie3c9BQizizozYx/nDq9L7MMmdhfDivWW3YtUvICuGVshB3NPj2iWIp19WQxwfsLz3mG9ogj9Za4aZOBGUvh0m9ypgmCGuNmgmTHx7E4aXed4boV7Mo9c/ZN5bFRe5hIW0bi8b2kcyU4YJifL0biJCPXFvOf62f+nYPOSICTjEnV+JccasEXnhNKotKdqnEWgcP0fDox+V5i+YDK4q3ZPXleIYzE6+1wQKKSwATB/wiVWzFwtF1B9VGP/+BX0km5MuQgk6AgWVWHWGZ2JagRmwBxZcG3JFCZjI2gzfuJiU9kqOfO+GiFdr7P1/UEd1AfRBXzZnik6VkVUoKUaaovT3muLU+AB0pWM15FxOGOG5FnnjAAh2Htm42QcEp/dTcslI3UoH5SQ9l3pYuosEl7qaLR5JOFTsgVJ8XI0sODGeDRmFjiJJFe914djFxz3UxbX9UwKANx/3m/YzeNhy8r95+YBci7m0D+MamKHqNDPGw/xDm9ouukSW/UC6kLvY1mcVqHbbZSiUIqpHYMAIwVZ9KSA0R5pJ5eKorVP7FimFCVdVpQRmRZmvpQBndHu1pY+6ap0iJm5Zxw2Fbg+7Gg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB5012.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(376002)(396003)(366004)(39860400002)(2906002)(316002)(86362001)(16576012)(5660300002)(38100700002)(66476007)(66556008)(66946007)(31686004)(8676002)(186003)(4326008)(956004)(31696002)(6666004)(478600001)(53546011)(6486002)(36756003)(8936002)(2616005)(6916009)(26005)(83380400001)(6706004)(3940600001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFIvL2xoVUg3NDhVa2llekZ4dkVuTHkxSkdLTWZUMVhzazdiK3Q3ZlRLZjc3?= =?utf-8?B?a05iakY2UERKaWR3bVZCZm9PTlRPb0ZWRGFvbUFZUkNTQ1VqS1VQWXQ3c2FL?= =?utf-8?B?M09MUmw1bHp4SlptdGV1OVRVazQrbzBUNCtmMXJOSk5vSnhtQTd2eVNWSUJr?= =?utf-8?B?eldTdVA4R2g5QVB3TUJ5WiswdE1JY25UVjhYeHZtWWtXdzF4NTAyYmdzK0d2?= =?utf-8?B?c0N0ckRCVGE0Q2E0bmlDVktLMFR1UkVHWG1JZE5qRjN6M09MRnZvVmlvUDR4?= =?utf-8?B?K3dvaUU1cG1Sa0ZQbHBoM0pMQkl5VWhrZUh4QkRncUp0YmNLRVcxRkpidlFk?= =?utf-8?B?aXVrMU5rZFcxelVQeDFaTEJYM25kamxqZ1dMOGtMVXVnWGhlRjNVeFZZaHVZ?= =?utf-8?B?eld2eE1Dak1jNEJLTHlDOXM3dkRYREdKTjViOEpOVkJaeit3Q3NMZERvV3lV?= =?utf-8?B?RVhGVWtXeTNNbFZBQnRWelRTbFhDVHZtL2IrSERkb2JrbXcwb3lacnJxUDhN?= =?utf-8?B?aGtJckFtamJadTNtWC96dWlLbHVYS0FKc2p1MmJ6YzQ0SDVkRVg5Z0ZqZUJo?= =?utf-8?B?YUwzaHZLN0d4aGxjRjF0YnBDaTlISHdvR3NFaTAzNTRlclBTeWJMNGlVdjBG?= =?utf-8?B?WFY2aHJOVDE0ZmYwdWEzVVI0K1VlVVVnN1BLYnIvaHZUelhqVEtaOEpnOU1y?= =?utf-8?B?RDAyRFc4RnVqZEpiaXlEVVVXb1F6UjI5YlFoWkJBNFNzZjYwcVdWRUJ3YkM3?= =?utf-8?B?eWhOMXBrd2xLY2tQbU5RTEorWEhSUkxncU5UT1JveXlaN2FibEhxbWtBNVlB?= =?utf-8?B?a3VQbDJUZk43NEhtMkZ4OXdmRThnK1JESUx0czBESFRSVjB3SC9ZcVAzQjJj?= =?utf-8?B?eXpYWnpSU2FNc0ppd0k2VUtkUmY5V0o4dk5tdmN6cmFhWFJ3alRaYm94bU5D?= =?utf-8?B?amdpWWhMem1YTDlMbnJqQ04yenFyamI5d2Q2RWhkdWg3bnFsSnhGc29XeW1T?= =?utf-8?B?c0RkYW1US1NWWjEyMHRYcVM0NjJoWGdYNTFweW9yWEJxQ2RqUUdOVjk5UlRl?= =?utf-8?B?VndobEcrV3VqYSthbXVhTlhlTkVveFpzODBDcjkxa1N2Vm5PYUhYYnByT3dC?= =?utf-8?B?Ky8xM0VvY1pmME5pbXFvOHBJTklmV2lFVkkzZVBzVkxXQ1A2Q3NHQmhuYVps?= =?utf-8?B?czg5QTVZRFpZK2V2aDBYOWZOT0tRcTdLcENIaDJxQ1JSUGV4eTYzdVlCRUFO?= =?utf-8?B?d0xTL2RRWUdmQkd3c2pFMENmZWlEUy8wNy84WlF4anRTT1g1L1ZrLzFRTWZm?= =?utf-8?B?NTU4ckM2UjRaMnJGRHVTbmRsN0xsWFprZWRZcU00U3MyWi9GalFpZVYwR1Ns?= =?utf-8?B?akh4K3lWa3lCUmFsM0dOTTZXdk82MWpNNkY5UHRtYlpDSHV2UEhtNFFwZmZL?= =?utf-8?B?cTRxQUYzbTZTeTczU1ZPMENVTnU5MWNyMWFNL0NoaGgvNkNvazVPazRBc3RL?= =?utf-8?B?VWl2MkNXN3hJMnY1aVJIT0NyYi95THJmb1F2ajhrNFNIWHhpb3hDSnE4aVhx?= =?utf-8?B?aHlDK3BrY3BrQ3Z3c29sOWE5dFo4WEN1RTJxTGpRSU1lOEVUMHZ4QnJqZGdS?= =?utf-8?B?cHJnUHJIVW4zQmdxZ3FFOEpYT3hXOTNSRDAvYzNlaU5kM1pNdzZFSGRtMk54?= =?utf-8?B?UUJwTWd0WGFJWktCZThFcjVPb2lBS3RTWThYMVRYTTJ3bUNyKzhWRHd1V0J4?= =?utf-8?Q?qhxfWX3QWlB65kOqB1GibQQYg8Q0dgSoWjzLB89?= X-MS-Exchange-CrossTenant-Network-Message-Id: 90f9f79b-c2de-465a-16fd-08d95818f0f6 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5012.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2021 13:57:19.5790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JRlVhX8p9LQD79kZ62jQHgXCk5wfWGuJjbPynqfQkpDCbCLoBEyYnHA0XIqSCdaQ3ZcqeuZfbUZxscYYBN2fIyyuxvRShbAjfoQ5FKCUBpY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4835 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] fib: announce experimental tag removal of the fib API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/08/2021 15:32, Jan Viktorin wrote: > On Thu, 5 Aug 2021 15:27:15 +0200 > "Medvedkin, Vladimir" wrote: > >> Hi Jan, >> >> The RIB is always used as a control plane struct intended to maintain >> the correct content of the dataplane struct, such as DIR24_8 for >> example. So it is always used on _add()/_delete(). For simplicity you >> can consider it as an LPM's rule_info. But instead of keeping routes >> in a plane array as it is in LPM, FIB uses RIB which is more suitable >> binary tree. > > OK. I thought that I can have a single RIB, use it for maintaining > routes and based on this single RIB, I can build a FIB for the data > plane. And when the single RIB is updated (which can take quite a lot > of time) I build a new FIB and locklessly give it to the dataplane. > Such approach is not considered? > > Jan > I'm not sure I understood completely your use case. Do you want to rebuild the entire FIB from scratch every time the RIB changes? >> >> >> On 05/08/2021 15:14, Jan Viktorin wrote: >>> On Thu, 5 Aug 2021 15:08:13 +0200 >>> Vladimir Medvedkin wrote: >>> >>>> This patch announces the experimental tag removal of all fib APIs, >>>> which have been experimental for 2 years. >>>> API will be promoted to stable in DPDK 21.11 >>> >>> Hi Vladimir, >>> >>> I have a question related to FIB. I am just learning how to use it >>> and I found that each FIB always creates a new RIB internally. >>> There is no doc about this topic... >>> >>> If I understand correctly, the underlying RIB is only used when >>> dummy_lookup() and dummy_modify() are used. But they are only used >>> when the configured mode is RTE_FIB_DUMMY. Is there any reason to >>> create the RIB with RTE_FIB_DIR24_8? >>> >>> The issue with this is that each RIB allocates a new mempool >>> internally which can waste quite a lot of never used memory that >>> would be unused with DIR24_8 implementation. >>> >>> Regards >>> Jan >>> >>>> >>>> >>>> Signed-off-by: Vladimir Medvedkin >>>> --- >>>> doc/guides/rel_notes/deprecation.rst | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/doc/guides/rel_notes/deprecation.rst >>>> b/doc/guides/rel_notes/deprecation.rst >>>> index afb599a..58826a8 100644 >>>> --- a/doc/guides/rel_notes/deprecation.rst >>>> +++ b/doc/guides/rel_notes/deprecation.rst >>>> @@ -195,3 +195,5 @@ Deprecation Notices >>>> communicate events such as soft expiry with IPsec in lookaside >>>> mode. >>>> * rib: The ``rib`` library will be promoted from experimental to >>>> stable. + >>>> +* fib: The ``fib`` library will be promoted from experimental to >>>> stable. >> > -- Regards, Vladimir