From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1F4964F91; Mon, 29 Oct 2018 00:26:27 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9491721F16; Sun, 28 Oct 2018 19:26:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 28 Oct 2018 19:26:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=zjnkTWhdQmZ+02JiOFcJHcA9EW89Ro729LUOYghqFNY=; b=mnueB8Ys5VbI nxQZCZa76j8n20F56BdYftmFaDGtudb/xJlhWggVNbfMQ2OtT6T181OxU1Wi/PEu TMZnI9p57sQOOj4zHPcMtz/49r80W6swUk8fg0vDgK2QjhaSZrvtN5MU4F/ctMHJ xtuiK9zIAqcq94+d0S4kj5NJTHyWHSA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=zjnkTWhdQmZ+02JiOFcJHcA9EW89Ro729LUOYghqF NY=; b=Q+0HZbON1uISWK0Ht1v9gh1hSDobS7ruhh09dRdAn4jxkcLFnK9UR27W7 WjCCpQ2pMGKspcCrCyGnfECO7cjRPEaCrokX/RdDczMa1V/GDeW9o7fC14/E44Nv wTLJR76/mOrMkuxyqtXM1wutQl2iuAof8KGf+TaV/rrJ0TY1HqiSj9xsHbBIy7Lk YwiyGBIfULO0Wp1j4QG862LpX71yzBZ5aC7tOm76XbWoH4nqgwtR9Nvd53YxkEcq Ltylc4EXkbeIJkluOeiX4jffDChBwkbb+rkQg+hEvbMpkr9DVoguv4KGTvWiAmwE PyWn5fRjyj4cLVA2/A7l4xaIL22+w== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 415ACE40E6; Sun, 28 Oct 2018 19:26:24 -0400 (EDT) From: Thomas Monjalon To: Qi Zhang Cc: dev@dpdk.org, anatoly.burakov@intel.com, ferruh.yigit@intel.com, geoffrey.lv@gmail.com, ajit.khaparde@broadcom.com, stable@dpdk.org, gaetan.rivet@6wind.com, arybchenko@solarflare.com Date: Mon, 29 Oct 2018 00:26:30 +0100 Message-ID: <4370007.3MeJCCFLt4@xps> In-Reply-To: <20181027032045.7564-1-qi.z.zhang@intel.com> References: <20181027032045.7564-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] bus/pci: fix unexpected resource mapping override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Oct 2018 23:26:27 -0000 27/10/2018 05:20, Qi Zhang: > When scanning an already plugged device, the virtual address > of mapped PCI resource in rte_pci_device will be overridden > with 0, that may cause driver does not work correctly. > The fix is not to update any rte_pci_device's field if the being > scanned device's driver is already probed. >=20 > Bugzilla ID: 85 > Fixes: c752998b5e2e ("pci: introduce library and driver") > Cc: stable@dpdk.org >=20 > Reported-by: Lv Geoffrey > Signed-off-by: Qi Zhang I still think something must be fixed in PCI scan. Anyway, there is an error: passing argument 1 of =E2=80=98rte_dev_is_probed=E2=80=99 from incompatible= pointer type