From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 739955F16 for ; Fri, 27 Apr 2018 23:47:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 039BA21450; Fri, 27 Apr 2018 17:47:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 27 Apr 2018 17:47:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=cJC6TSpUU2Ia+ibm2WoQGKWAqs mWKshtx1+EFPL9jhw=; b=D3I7hMZHa42qNX1fpBXgUqEcrxSD6G+JxeEOtotp8j 5P+3ManxDS479LVdSc7j4Jq2nSoVHzTe2zyl+21pU85K+A7Be6hqyVRuh9lWaIZl 5ABFT2WyFc8FhXUEmo+FzbhhOS2RFvwoR5yV2CPrsjccHIYR9x8kD6LYOERZiMxz o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=cJC6TS pUU2Ia+ibm2WoQGKWAqsmWKshtx1+EFPL9jhw=; b=SUzSWP/FKd/6nKgzrUBJvN DH+xi++73sWZpiCws6FN/nvpSSuNFOh7vq9lfYw303ZTt0unoETA9eFJsEM1JO+5 VQigmeogf9Gte+FqMIM7Dsl8dc7zf5JGTN1MZGc5RAX1nZ7HfHA6v+Vg4yV59cos hJQ7F+bYaP5pOw9unhuknmRIs/N0Kkquz/Cgcy8SZYcrFTomIv4OlG7M/ugydC8J 5pj7eM1pGj+LY7urqzajljetVP35i7SrIduYKha2JZ+JCiD8ADz4fHMZp5SP7l7x JqYkbWxKivrK/66c6Li2cJ5Jc46WzvmInrM0B7xrzOZRGqcDFPMsMTYaECpvSYOA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2BF2AE5094; Fri, 27 Apr 2018 17:47:13 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, "Pattan, Reshma" , "Parthasarathy, JananeeX M" Date: Fri, 27 Apr 2018 23:47:11 +0200 Message-ID: <4370618.qW8ombCSU7@xps> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C9B5B@irsmsx110.ger.corp.intel.com> References: <3AEA2BF9852C6F48A459DA490692831F2A2C9B5B@irsmsx110.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 3/3] mem: improve autodetection of hugepage counts on 32-bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 21:47:14 -0000 > > For non-legacy mode, we are preallocating space for hugepages, so we know > > in advance which pages we will be able to allocate, and which we won't. > > However, the init procedure was using hugepage counts gathered from sysfs > > and paid no attention to hugepage sizes that were actually available for > > reservation, and failed on attempts to reserve unavailable pages. > > > > Fix this by limiting total page counts by number of pages actually > > preallocated. > > > > Also, VA preallocate procedure only looks at mountpoints that are available, > > and expects pages to exist if a mountpoint exists. That might not necessarily > > be the case, so also check if there are hugepages available for a particular > > page size on a particular NUMA node. > > > > Signed-off-by: Anatoly Burakov > > Tested-by: Jananee Parthasarathy Series applied, thanks