From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BCB72374 for ; Tue, 27 Jun 2017 13:09:00 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2017 04:08:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,399,1493708400"; d="scan'208";a="101884488" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 27 Jun 2017 04:08:57 -0700 To: Radu Nicolau , dev@dpdk.org Cc: wenzhuo.lu@intel.com, reshma.pattan@intel.com, michalx.k.jastrzebski@intel.com, deepak.k.jain@intel.com, harry.van.haaren@intel.com, piotrx.t.azarewicz@intel.com References: <20170522143202.22424-2-michalx.k.jastrzebski@intel.com> <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> From: Ferruh Yigit Message-ID: <4375ffd8-6957-7f53-a9b0-081e705a5eb1@intel.com> Date: Tue, 27 Jun 2017 12:08:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 11:09:01 -0000 On 6/26/2017 10:42 AM, Radu Nicolau wrote: > From: Michal Jastrzebski > > If-MIB xstats: > ifNumber > ifIndex > ifType > ifMtu > ifSpeed > ifPhysAddress > ifOperStatus > ifLastChange > ifHighSpeed > ifConnectorPresent > ifCounterDiscontinuityTime > > EtherLike-MIB xstats: > dot3PauseOperMode > dot3StatsDuplexStatus > dot3StatsRateControlAbility > dot3StatsRateControlStatus > dot3ControlFunctionsSupported > > -updated in v2: coding style > > Signed-off-by: Piotr Azarewicz > Signed-off-by: Michal Jastrzebski > Signed-off-by: Radu Nicolau <...> This patch implements MIBs for some Intel drivers using xstats, this is easy way to get some information from PMDs. But there was a outstanding comment to make this ethdev layer. So I believe we have two options: [1] Each PMD implements MIBs using xstats, this is pragmatic solution and each PMD can implement whichever MIBs they want. [2] Implement a ethdev layer API and add a new dev_ops to get MIBs, API can use existing methods to get required information, and if it fails can call dev_ops which can be similar to the xstats. Because of API all PMDs can have a small amount of support by default and they can implement dev_ops for more support. Although 2) looks more generic and proper, I am not really sure if that is overkill and if this worth to the effort and to have new API and dev_ops, comparing current method is easy to implement, any comments? Thanks, ferruh