From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2C5411B583
 for <dev@dpdk.org>; Sun,  5 Aug 2018 22:11:53 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 9AF8A20DB5;
 Sun,  5 Aug 2018 16:11:52 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Sun, 05 Aug 2018 16:11:52 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=JYR6qExFJQYmf2//pqtD9LCnYZ
 klX1rhbIPX9euHLOA=; b=YkusM0DHdUw3p9Vzc2+8hV3t+1h9w4LEf9urL38ZsM
 q5P3oi9xzEAJpAWni1HeOQfSIMOCLajbfpvLiZMoefmk+4AnSn7r+Nqry5tBiiIV
 xMH1BSz3+/Xr286GmcM/2ZOe5kZe9udvVYwSxXu7+ZymcnbILsVQqaQ+IDx2GdpI
 0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=JYR6qE
 xFJQYmf2//pqtD9LCnYZklX1rhbIPX9euHLOA=; b=g61leJ/VfXEg+HiRbA7Sm3
 m12Z4GoQucz1MFSt6Q7nmYhygxSpneHDCTka8zG3zLHP+0wqbzpuWO4zG57jl0g6
 3riLGiiJYGD69acP/E9ItyKzkCuXdgi6xNHubnWFAi8Vhh24Ywha8xgARZ9ZsxDo
 ovDlV7QYUTTA/esrIpfBXQC+mUT/RwpeMkJPnQIh+j8p0TNbue515QVKT52344HA
 1wFRdv7Cu30dEgvxMHKjkWCHIvTLojyKJZPcR++cZRW+LORiunEbrilGDwJM4wUx
 6eP9FU3piWKxZGkrVxnqok9LbBBsQUJ5PmNbCVdo2sTxFBN7MFBzMasVeiXGSu/Q
 ==
X-ME-Proxy: <xmx:CFpnW8OppE2sDRzOOcegbrjHfhu0msGUwEbNM9kyyzIexvmZJri2YQ>
 <xmx:CFpnW4cQ8N_ka_GUjPZNBDECO7Th_q3fVONzDSOZTyL8Bacq5etRWQ>
 <xmx:CFpnWyUlg4F_OhQkh619ABUzC_tPgqldShAarFlNr0fS4KVjHb-hrg>
 <xmx:CFpnW5Ac6xVkCM9y-FoISUYsfFnjoFmat2XbsQtqTv2anhIDeTidSg>
 <xmx:CFpnW94H7xeAZgwwjJhhWYxiQnsVfzSOHcfpMy6aq0VikhCmrfxzsQ>
 <xmx:CFpnW9sC_v5_AmMHQoJkSjRqdtb4zifpBaInA0etaWFySRKwVHveJw>
X-ME-Sender: <xms:CFpnWygKAFw7byp0T_LWd9hyLXfcksMf6uvoEVi-uFdz_baXU5lh-w>
Received: from xps.localnet (195.19.136.77.rev.sfr.net [77.136.19.195])
 by mail.messagingengine.com (Postfix) with ESMTPA id 064D010261;
 Sun,  5 Aug 2018 16:11:50 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, Fan Zhang <roy.fan.zhang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Yuan Peng <yuan.peng@intel.com>
Date: Sun, 05 Aug 2018 22:08:28 +0200
Message-ID: <4382199.Nx38v1RVeE@xps>
In-Reply-To: <1533048565-216267-1-git-send-email-cristian.dumitrescu@intel.com>
References: <1533048565-216267-1-git-send-email-cristian.dumitrescu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix RSS
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Aug 2018 20:11:53 -0000

31/07/2018 16:49, Cristian Dumitrescu:
> Fix for RSS issue triggered by latest changes in ethdev layer.
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Collected agreements:
    Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
    Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
    Tested-by: Yuan Peng <yuan.peng@intel.com>

But 3 things are missing:
	- The issue is not described
	- The fix is not explained (you chose to mask unsupported RSS fields)
	- There is no Fixes line, I guess this one:
		Fixes: aa1a6d87f15d ("ethdev: force RSS offload rules again")

Please send a v2