From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com (mail-wg0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 8FEE6B347 for ; Thu, 18 Sep 2014 00:30:14 +0200 (CEST) Received: by mail-wg0-f48.google.com with SMTP id m15so22319wgh.19 for ; Wed, 17 Sep 2014 15:35:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=rOGyNARPwMKkoU53bbU/wEFdvz6QSV26wHbWwmWTHCk=; b=Zj0Iw/VoRfNlSwYqcBHUuORT0VUDtXE0Qln/+uuhziJJJOiU1Pijf72MaGEiHYX235 a6mmA1ZqOQ4+p3AJN9eDksaMhTFDTfRrtQwqhl6un0pST2Uj6foSuBmVlG3i3TeG2GHI EnJnK5VOfaZSoVrpuF2liMFiaJpEkeC243zemeTctivM8WURangaLH7UpMFxFGakbVzJ IrMWFLL+hIuh1oqhTL8B8SbBMmbGcK40m6pA4M7QFI0O1Hjmjl1/mZHOecNU+ElfC0Bu MPV9/nAnh5XRFcd6u8jiQhpRjzdxYuTwD54Lw8UxvL9i79xvuTdegy8Ptzt6Y83Y9gEb HFwQ== X-Gm-Message-State: ALoCoQljtEpWOfRjIFnx9EP8BPx8SkrJY4GfowNWYHGw7cNg2ijf5spXaxZ4Ap7EmimC71SO0sQA X-Received: by 10.180.94.161 with SMTP id dd1mr8776074wib.22.1410993357290; Wed, 17 Sep 2014 15:35:57 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id q2sm633190wiy.23.2014.09.17.15.35.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Sep 2014 15:35:56 -0700 (PDT) From: Thomas Monjalon To: Bruce Richardson Date: Thu, 18 Sep 2014 00:35:45 +0200 Message-ID: <4382532.Ge2NzkiriE@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1410441347-22840-1-git-send-email-bruce.richardson@intel.com> References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1410441347-22840-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 00/13] Mbuf Structure Rework, part 2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Sep 2014 22:30:14 -0000 2014-09-11 14:15, Bruce Richardson: > This patch set continues on from the changes in part 1, and depends > upon that patch set. > > This patch set reorders the fields in the mbuf structure and splits > the structure across two cache lines, given lots of new space for new > fields to be added. This set uses some of that space by expanding the > ol_flags field. A part 3 patchset is planned to introduce some other > new fields into the new mbuf structure. > > With the splitting of the mbuf across multiple cache lines, performance > degradations are seen inside the drivers, both fast-path and slow path. > For the fast-path, this patchset reworks the way in which the pool pointer > is used to free packets post-TX, which removes the perf regression. For > the slow path, an alternative approach is taken - a new scattered packets > RX function is introduced into the vector PMD. Using this function, > throughput for the slow path RX-TX using testpmd is increased by up to 20% > over the original baseline. > > Changes in V2: > * General minor updates follow comments on V1 set > * Updated a number of patches to include KNI mbuf changes where needed > * Deferred the patch to add the packet type field to a future patch set > * After removing meta-data element from mbuf structure also added in patch > to move the macros to rte_port/rte_port.h > > Bruce Richardson (11): > mbuf: reorder fields by time of use > mbuf: expand ol_flags field to 64-bits > mbuf: introduce a flag to indicate a control mbuf > mbuf: minor changes for readability > mbuf: use macros only to access the mbuf metadata > mbuf: add named points inside the mbuf structure > ixgbe: rework vector pmd following mbuf changes > mbuf: split mbuf across two cache lines. > mbuf: move l2_len and l3_len to second cache line > ixgbe: Fix perf regression due to moved pool ptr > ixgbe: Improve slow-path perf: vector scattered RX > > Olivier Matz (1): > mbuf: replace data pointer by an offset Applied for version 1.8.0. Note that ixgbe patches are not reviewed but I make an exception here, because Intel is responsible of ixgbe performances and we have some time to fix it (if needed) before the release. -- Thomas