From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 020FF5AA0 for ; Tue, 8 Dec 2015 11:40:00 +0100 (CET) Received: by wmvv187 with SMTP id v187so207319003wmv.1 for ; Tue, 08 Dec 2015 02:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=XZ0wF3v18yV0GY3IdtPwwz+SyDh+0Qk3aa1eUopZhMg=; b=tFhUaSwuOLvmqKuyGDkOyhlvvnmghO7X5YtTCAnwVnCI4h2RXRmLBGZ27ihlPmXrhF LywfYTj2dF6B9Bfj5guP2jvwglzI3nM8N81yQFRlHU0qP1Jk5Kxxbc972C5aefaMSCdM P/weH2n9UJGBdWBHRXNgs/fN1zoBfIjze8V0wTJn6m/DLssC821OriUKr5XnIfvZxsnJ DUvKugZQvrAbVEPPSWEXKg2p6pqyHZxfyYezyuL9CGuo2ykTo/z7WpAMOCPLnIxaHF9U FlTDOJXwXuAaMvB5cxz7yW4XgFygWW/rLOAlcMck8TQNS+jf6hVodSBSoMwQqb5to2RF fwcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=XZ0wF3v18yV0GY3IdtPwwz+SyDh+0Qk3aa1eUopZhMg=; b=Jn5dBe1pCcP598z9ioCrP98KupZOz7SA2PsWCb8YbL/EfSn/a/VmvqhJ2PqGBN1pkh E41QBSKWl1VZwMTvb/cB/EB8zgsTILRjLvdj7fkQooBph4pN7G1ySoOyqud0tD3cXfw6 L7fLeZFcK3UpNO9DhW+IaSGn9AaWE50IeCaWXSe4KD3b+D+az/ipDMS1F7JVaub92Xe9 ddOCVx1kkK4fZDc5FpuhBJLWr4ZTqsnDhZ+456goQzNY1TsaiCytJT3S8D08a3Tla4F0 Yb/u9chyqDGJyhovPwloChLqD74hcH9hZ6kMfc3qc2xUXNCCx2dG3uYwARZWHFX9SnMn svgw== X-Gm-Message-State: ALoCoQlcEWpGQAMne9MzG2+GIpLYsxJJkXQDl0owA+xlylIVer9ECl9Yw8h3pPvsu9r5dzcDNr8KWPNv2NE5BqGKPvi7qge2jg== X-Received: by 10.194.82.99 with SMTP id h3mr3442265wjy.41.1449571199854; Tue, 08 Dec 2015 02:39:59 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id a76sm20784125wma.19.2015.12.08.02.39.58 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Dec 2015 02:39:58 -0800 (PST) From: Thomas Monjalon To: Jianbo Liu Date: Tue, 08 Dec 2015 11:38:46 +0100 Message-ID: <43936748.C5nEZ994YB@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1448995276-9599-1-git-send-email-jianbo.liu@linaro.org> <2562409.c2PxG9doT8@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/3] eal/acl: enable acl for armv7-a X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2015 10:40:00 -0000 2015-12-08 18:21, Jianbo Liu: > On 8 December 2015 at 18:03, Thomas Monjalon wrote: > > 2015-12-08 15:56, Jianbo Liu: > >> On 8 December 2015 at 10:23, Thomas Monjalon wrote: > >> > 2015-12-08 09:50, Jianbo Liu: > >> >> On 8 December 2015 at 09:18, Thomas Monjalon wrote: > >> >> > 2015-12-03 23:02, Jianbo Liu: > >> >> >> -ifeq ($(CONFIG_RTE_ARCH_ARM64),y) > >> >> >> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),) > >> >> > [...] > >> >> >> +#ifdef RTE_ARCH_ARM > >> >> >> +/* NEON intrinsic vqtbl1q_u8() is not supported in ARMv7-A(AArch32) */ > >> >> > > >> >> > I'm convinced there is a good reason why ARMv8 is also called ARCH_ARM64, > >> >> > and ARMv7 may be called AArch32 or ARCH_ARM. But I don't know why? > >> >> > > >> >> https://lkml.org/lkml/2012/7/15/133 > >> >> > >> >> > Is ARCH_ARM32 or ARCH_ARMv7 too simple? > >> >> > Is it possible to have a 32-bit ARMv8? > >> >> Yes, ARMv8-R/M > >> > > >> > So what does mean CONFIG_RTE_ARCH_ARM? > >> > ARMv7? ARM32? > >> > Please consider a renaming. > >> > >> I'd rather not renaming becase it can be both ARMv7 and AARCH32, which > >> are ISA compatibility. > >> If further differentiation is needed, CONFIG_RTE_ARCH_ARMv7 is added > >> in the config, just like Jan Viktorin did. > > > > I don't understand. > > You say CONFIG_RTE_ARCH_ARM is for ARMv7 and AARCH32, right? > > Both are 32-bit right? > > Why not rename it to CONFIG_RTE_ARCH_ARM32? > > I understand that you want to make the naming more clear. > But arm/arm64 are used in Linux kernel, I think it's better to stay the same. Linux supports ARM for a very long time. Doing a rename now is costly. The DPDK support is recent. Keeping a bad naming scheme because an old project follows this scheme is insane.