From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E8DD6A04C0;
	Fri, 25 Sep 2020 17:31:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 42A8E1E99B;
	Fri, 25 Sep 2020 17:31:30 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id E1B261E99A
 for <dev@dpdk.org>; Fri, 25 Sep 2020 17:31:26 +0200 (CEST)
IronPort-SDR: DwpP8zwikVZneKvXGyV1i9MKXWOmyvgFVdZnpJNi8ip7CuNVPCH+sHjJLfHFkQL+N4THd4F1yS
 YD1kETr8zOUQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9755"; a="223158001"
X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="223158001"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Sep 2020 08:31:24 -0700
IronPort-SDR: UXhUHMtfwl545bcwWDdJN1bSW06rTzOKJ3R2cODhk86LbCzgndf/pSqVRfwOloydMwbYV0QmXX
 dVv/WLI/UZ1Q==
X-IronPort-AV: E=Sophos;i="5.77,302,1596524400"; d="scan'208";a="336740724"
Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.219.62])
 ([10.213.219.62])
 by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Sep 2020 08:31:23 -0700
To: David Marchand <david.marchand@redhat.com>,
 Sarosh Arif <sarosh.arif@emumba.com>
Cc: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>, dev <dev@dpdk.org>
References: <20200415064238.24012-1-sarosh.arif@emumba.com>
 <20200908102204.727240-1-sarosh.arif@emumba.com>
 <CAJFAV8zU-4ZWx4Q0vOWja6KNfubZ0ow+1_UtUSrihd+FQffqSg@mail.gmail.com>
From: David Hunt <david.hunt@intel.com>
Message-ID: <4397da05-8169-d9e7-5948-24eced57213d@intel.com>
Date: Fri, 25 Sep 2020 16:31:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CAJFAV8zU-4ZWx4Q0vOWja6KNfubZ0ow+1_UtUSrihd+FQffqSg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Subject: Re: [dpdk-dev] [v3 PATCH] test_distributor: prevent memory leakages
 from the pool
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi David,

On 25/9/2020 3:22 PM, David Marchand wrote:
> On Tue, Sep 8, 2020 at 12:22 PM Sarosh Arif <sarosh.arif@emumba.com> wrote:
>> rte_mempool_get_bulk is used to get bufs/many_bufs from the pool,
>> but at some locations when test fails the bufs/many_bufs are
>> not returned back to the pool.
>> Due to this, multiple executions of distributor_autotest gives the
>> following error message: Error getting mbufs from pool.
>> To resolve this issue rte_mempool_put_bulk is used whenever the test
>> fails and returns.
>>
>> Signed-off-by: Sarosh Arif <sarosh.arif@emumba.com>
> It deserves a Fixes: line.
>
> I can see a ack from Lukasz.
> David, review please?

Done. Apoligies, I should have put you on CC:

My review comments have just been sent to the mailing list.

Rgds,
Dave.