From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B6A49DE3 for <dev@dpdk.org>; Thu, 9 May 2019 16:28:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5156B24423; Thu, 9 May 2019 10:28:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 10:28:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vB5A9GmGZd22HjAInUUGKNMBIBblOfL9MmXwxifPn5Q=; b=KjyBCHpqSuP8 3GDFVlN9KRSNrKWPqJw0TnzDmzPaf7e/zf8OwoeSC4HoMGXEeFfQxSMp+HBmS8Qr gA1XpOXCv2YX4uCqYEqHmO0LnucHfTFKZzeYv7+AJqMGZK98gTDYdm6DJNQ9YXN2 Ex6/+/UMdMJd5y0PZET234pVLJtkRp4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vB5A9GmGZd22HjAInUUGKNMBIBblOfL9MmXwxifPn 5Q=; b=LHCzDgzeIMG/C+WPWreDKK9mJCsRhi0Ie695CfEHgx27qa1M/nPbqRGXt 9Mtd/97si4XUG8UlZJp/2VxWcmftjvKBLHUls3r8I5ifA+zIx2a0HdhcxmfhJF2v I91UlU4DFstO3EEO6wVHMSqWUy4CQ6GtFsh3kXScg+BT2fksnLkatK7GU0B/K9Jz s8FQjggiD3obtqvoSDLfTPF8uE0LEoDWKR5aQrUMmP/A+G0SS/VzItyklWnNRmlr I7GJ1QkAVSs/aqSQMkuHV6gceB/kr4wuDM41biw7tGe6kp4uW+fxSf4EqXV5emcs qEmYChm0Qs/onoqsn/pCON06xbBGA== X-ME-Sender: <xms:8TjUXDrEOqxC9_69Xa_r4fyjFcwLM-6FU4QzrzrxQenJEiVsL15ewA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:8TjUXEs_JRPVMiPrBx8c6stFVGbL84KuHHhAxGTaxTOudXG_GaP9ow> <xmx:8TjUXH52pwr-vESi42fXM7R9zXzBhfN0o_MzVc8BAZD9v1QkVHrRYw> <xmx:8TjUXNRb-UcFp3ZYgklahJvg2QbrHqlcCklNnLwSAMyErP6T2_xrjg> <xmx:8jjUXNT3q37sDAgWGkX56NK5MLMvYYHYCRCHxhfPWmvImwvypxjxag> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 17F5D80060; Thu, 9 May 2019 10:28:00 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ayuj Verma <ayverma@marvell.com>, shallyv@marvell.com Cc: dev@dpdk.org, akhil.goyal@nxp.com, arkadiuszx.kusztal@intel.com, fiona.trahe@intel.com, ssahu@marvell.com, kkotamarthy@marvell.com, adesai@marvell.com Date: Thu, 09 May 2019 16:27:58 +0200 Message-ID: <4399121.H3Qt12NPdz@xps> In-Reply-To: <1557401001-27203-2-git-send-email-ayverma@marvell.com> References: <1557401001-27203-1-git-send-email-ayverma@marvell.com> <1557401001-27203-2-git-send-email-ayverma@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 09 May 2019 14:28:03 -0000 09/05/2019 13:23, Ayuj Verma: > Currently some tests return TEST_SKIPPED/-1 when tests or params > are not supported for particular PMD because of which tests adds to > FAILED test counter in place of Skipped/Unsupported counter. It looks to be a bug that TEST_SKIPPED is not caught to increment "skipped" counter. Please fix it. > Since unsupported test is not a failure case, > replace return value TEST_SKIPPED/-1 with -ENOTSUP I would say the right reason is that the test is not supported by the HW. > - Return -ENOTSUP for unsupported tests > - add NULL check for rte_cryptodev_asym_capability_get() > - Typo correction > > Signed-off-by: Ayuj Verma <ayverma@marvell.com> > Signed-off-by: Shally Verma <shallyv@marvell.com> I am not sure what the "skipped" counter is supposed to represent if it's not for the unsupported cases. There is a gap to check and document here. Applied, as it sounds right to return ENOTSUP in those cases. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 69443A0096 for <public@inbox.dpdk.org>; Thu, 9 May 2019 16:28:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FD6737B7; Thu, 9 May 2019 16:28:04 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B6A49DE3 for <dev@dpdk.org>; Thu, 9 May 2019 16:28:02 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5156B24423; Thu, 9 May 2019 10:28:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 10:28:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vB5A9GmGZd22HjAInUUGKNMBIBblOfL9MmXwxifPn5Q=; b=KjyBCHpqSuP8 3GDFVlN9KRSNrKWPqJw0TnzDmzPaf7e/zf8OwoeSC4HoMGXEeFfQxSMp+HBmS8Qr gA1XpOXCv2YX4uCqYEqHmO0LnucHfTFKZzeYv7+AJqMGZK98gTDYdm6DJNQ9YXN2 Ex6/+/UMdMJd5y0PZET234pVLJtkRp4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vB5A9GmGZd22HjAInUUGKNMBIBblOfL9MmXwxifPn 5Q=; b=LHCzDgzeIMG/C+WPWreDKK9mJCsRhi0Ie695CfEHgx27qa1M/nPbqRGXt 9Mtd/97si4XUG8UlZJp/2VxWcmftjvKBLHUls3r8I5ifA+zIx2a0HdhcxmfhJF2v I91UlU4DFstO3EEO6wVHMSqWUy4CQ6GtFsh3kXScg+BT2fksnLkatK7GU0B/K9Jz s8FQjggiD3obtqvoSDLfTPF8uE0LEoDWKR5aQrUMmP/A+G0SS/VzItyklWnNRmlr I7GJ1QkAVSs/aqSQMkuHV6gceB/kr4wuDM41biw7tGe6kp4uW+fxSf4EqXV5emcs qEmYChm0Qs/onoqsn/pCON06xbBGA== X-ME-Sender: <xms:8TjUXDrEOqxC9_69Xa_r4fyjFcwLM-6FU4QzrzrxQenJEiVsL15ewA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:8TjUXEs_JRPVMiPrBx8c6stFVGbL84KuHHhAxGTaxTOudXG_GaP9ow> <xmx:8TjUXH52pwr-vESi42fXM7R9zXzBhfN0o_MzVc8BAZD9v1QkVHrRYw> <xmx:8TjUXNRb-UcFp3ZYgklahJvg2QbrHqlcCklNnLwSAMyErP6T2_xrjg> <xmx:8jjUXNT3q37sDAgWGkX56NK5MLMvYYHYCRCHxhfPWmvImwvypxjxag> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 17F5D80060; Thu, 9 May 2019 10:28:00 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ayuj Verma <ayverma@marvell.com>, shallyv@marvell.com Cc: dev@dpdk.org, akhil.goyal@nxp.com, arkadiuszx.kusztal@intel.com, fiona.trahe@intel.com, ssahu@marvell.com, kkotamarthy@marvell.com, adesai@marvell.com Date: Thu, 09 May 2019 16:27:58 +0200 Message-ID: <4399121.H3Qt12NPdz@xps> In-Reply-To: <1557401001-27203-2-git-send-email-ayverma@marvell.com> References: <1557401001-27203-1-git-send-email-ayverma@marvell.com> <1557401001-27203-2-git-send-email-ayverma@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190509142758.m4w5UI9lUZV2ucif3BJjRYhlfR5N3ZymcsXCClzgcws@z> 09/05/2019 13:23, Ayuj Verma: > Currently some tests return TEST_SKIPPED/-1 when tests or params > are not supported for particular PMD because of which tests adds to > FAILED test counter in place of Skipped/Unsupported counter. It looks to be a bug that TEST_SKIPPED is not caught to increment "skipped" counter. Please fix it. > Since unsupported test is not a failure case, > replace return value TEST_SKIPPED/-1 with -ENOTSUP I would say the right reason is that the test is not supported by the HW. > - Return -ENOTSUP for unsupported tests > - add NULL check for rte_cryptodev_asym_capability_get() > - Typo correction > > Signed-off-by: Ayuj Verma <ayverma@marvell.com> > Signed-off-by: Shally Verma <shallyv@marvell.com> I am not sure what the "skipped" counter is supposed to represent if it's not for the unsupported cases. There is a gap to check and document here. Applied, as it sounds right to return ENOTSUP in those cases.