From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A9C9A0562; Thu, 2 Apr 2020 21:49:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 930271BF6D; Thu, 2 Apr 2020 21:49:26 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E39E21BED8 for <dev@dpdk.org>; Thu, 2 Apr 2020 21:49:24 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200402194924euoutp01695349a83b38a59fe3c237da7ca71001~CGIHAOllc2095420954euoutp01S for <dev@dpdk.org>; Thu, 2 Apr 2020 19:49:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200402194924euoutp01695349a83b38a59fe3c237da7ca71001~CGIHAOllc2095420954euoutp01S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1585856964; bh=pxNyQg+NJWLm6eNMwS3p51zXlDbJLFnWBnIlUc2D758=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=ubxFaHZGEfPkvF9VXrYJ+gpzKmogvmz/pSCcSvb9R3xFs0RhPXcOtGTC9SYxXZZkC y7ts+uGa2ro9z00d9dYQj3d9i5G7P2jV1eN63Oaft2XXgPJxw7W1fLak9OzfqceeKg fhVBfm4Kcakkb+ra4WRuc/C/pJs0ATK6taRR2GH8= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200402194923eucas1p2e6bad7c5d9e99b544123b1996d7d7684~CGIGNO2dW0876908769eucas1p2_; Thu, 2 Apr 2020 19:49:23 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 41.AB.61286.3C1468E5; Thu, 2 Apr 2020 20:49:23 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200402194922eucas1p17b3e2f3f5003e889b25e010130890528~CGIFHI6JE1961719617eucas1p1Q; Thu, 2 Apr 2020 19:49:22 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200402194922eusmtrp234f47cad764d1bad635dab33c3b847ad~CGIFGlS950362603626eusmtrp2R; Thu, 2 Apr 2020 19:49:22 +0000 (GMT) X-AuditID: cbfec7f2-ef1ff7000001ef66-5e-5e8641c3b9de Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8E.0F.07950.2C1468E5; Thu, 2 Apr 2020 20:49:22 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200402194921eusmtip245bb4b0f19bc51f5c1e7b36bdff7cd5a~CGIEsOulY2823128231eusmtip29; Thu, 2 Apr 2020 19:49:21 +0000 (GMT) To: Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <akhil.goyal@nxp.com> Cc: "declan.doherty@intel.com" <declan.doherty@intel.com>, dev@dpdk.org From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Message-ID: <43a9be22-ee6a-3744-3a05-858eeee313a1@partner.samsung.com> Date: Thu, 2 Apr 2020 21:49:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <1703484.4MS8fQxZnU@xps> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRmVeSWpSXmKPExsWy7djPc7qHHdviDJa3S1msPzOP0eLNgyYW i3eftjNZfHpwgsWBxePXgqWsHov3vGTyOHZzGrvHxnc7mAJYorhsUlJzMstSi/TtErgyWr+d Yix4JFWx7/8C9gbGNaJdjJwcEgImEpN/3GXrYuTiEBJYwSgx4cdVJgjnC6NE8507UM5nRom/ L34zw7R0rD0E1bKcUeLT0zdQzltGiUUdd1hBqoQFAiW+bvvPDmKLCPhIHFn0mAnEZhZwl9jf 9Y0RxGYTsJU4MvMrWD2vgJvEogfnweIsAioS568sYAGxRQViJc49ugFVIyhxcuYTsDingKpE 87O7zBAz5SWat86GssUlbj2ZD3a2hMBkdonFeyYxQpztInHn5CGoF4QlXh3fwg5hy0j83wnT sI1R4urvn4wQzn5Gieu9K6CqrCUO//sN9CcH0ApNifW79CHCjhIfL9xnBAlLCPBJ3HgrCHEE n8SkbdOZIcK8Eh1tQhDVehJPe6Yywqz9s/YJywRGpVlIXpuF5J1ZSN6ZhbB3ASPLKkbx1NLi 3PTUYsO81HK94sTc4tK8dL3k/NxNjMAEc/rf8U87GL9eSjrEKMDBqMTDy3CwNU6INbGsuDL3 EKMEB7OSCK/jDKAQb0piZVVqUX58UWlOavEhRmkOFiVxXuNFL2OFBNITS1KzU1MLUotgskwc nFINjMIzYo+5LjAQ+Zepk3rKy9vUaR+j6MEXTv6zvpQp3z51f9UV/u/JTDN1WmsV4qZOXn2e 072xW2rpJu9DUW/v2hoUGM4+qD1h75qC2zr7ldsm+/Urvnp22rHH6MPXv2Wxri7feAINFe4b 7jl6taGVTWLRI0c/3gSZSYVO2y9YWIqnFvQdfHmhWImlOCPRUIu5qDgRAGB1Hs0sAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsVy+t/xe7qHHNviDOacErBYf2Yeo8WbB00s Fu8+bWey+PTgBIsDi8evBUtZPRbvecnkcezmNHaPje92MAWwROnZFOWXlqQqZOQXl9gqRRta GOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehltH47xVjwSKpi3/8F7A2Ma0S7GDk5 JARMJDrWHmLrYuTiEBJYyiix/cNpxi5GDqCEjMSHSwIQNcISf651QdW8ZpTYvWcyM0hCWCBQ 4uu2/+wgtoiAj8SRRY+ZQGxmAXeJ/V3fGCEaDjJJ/N17lw0kwSZgK3Fk5ldWEJtXwE1i0YPz jCA2i4CKxPkrC1hAbFGBWIn+5t2MEDWCEidnPgGLcwqoSjQ/u8sMscBMYt7mh1C2vETz1tlQ trjErSfzmSYwCs1C0j4LScssJC2zkLQsYGRZxSiSWlqcm55bbKRXnJhbXJqXrpecn7uJERhP 24793LKDsetd8CFGAQ5GJR5ehoOtcUKsiWXFlbmHGCU4mJVEeB1nAIV4UxIrq1KL8uOLSnNS iw8xmgI9N5FZSjQ5HxjreSXxhqaG5haWhubG5sZmFkrivB0CB2OEBNITS1KzU1MLUotg+pg4 OKUaGP0rTtzyyL51P6FBoaB9V0A+R8I51r/nts/frLpe/2/CvCW7DpfyuV049yr2Y4L3Coal 81fvPPwxmn1Kyf3PZ56eLV+7t0UrIt6aa2tDVsFD5/Bai7pWd/+cgI9WMlG7O1XZ5nXez5l2 wbJyv53z7jdrfCRvJu1ax+kitENgzyY+w3IzA90L6UosxRmJhlrMRcWJANnRprW9AgAA X-CMS-MailID: 20200402194922eucas1p17b3e2f3f5003e889b25e010130890528 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200401175118eucas1p253ef902f34bff3f97051d4d08bd4cbed X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200401175118eucas1p253ef902f34bff3f97051d4d08bd4cbed References: <20200312151654.7218-1-l.wojciechow@partner.samsung.com> <20200312151654.7218-6-l.wojciechow@partner.samsung.com> <DB8PR04MB6635E11FBFFDADD7537D8802E6C90@DB8PR04MB6635.eurprd04.prod.outlook.com> <CGME20200401175118eucas1p253ef902f34bff3f97051d4d08bd4cbed@eucas1p2.samsung.com> <1703484.4MS8fQxZnU@xps> Subject: Re: [dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> W dniu 01.04.2020 o 19:51, Thomas Monjalon pisze: > 01/04/2020 19:09, Akhil Goyal: >> Hi Lukasz, >> >>> This patch introduces set of unit tests of librte_security API functions. >>> Tests are added to dpdk-test application and can be run with >>> "security_autotest" runtime command. >>> >>> This is the first patch in the series of patches as adding all test cases >>> for all API functions in a single patch would make it unreadable. >>> >>> This patch defines structure of the file and necessary test framework >>> initialization. It also contains first subset of unit tests for >>> rte_security_session_create API function. >>> >>> Structure of the tests file is following: >>> - macros for making tests more readable; >>> - mockup structures and functions for rte_security_ops; >>> - test suite and test cases setup and teardown functions; >>> - tests functions; >>> - declaration of testcases. >>> >>> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> >>> Change-Id: I3a4585f56ef1a75b2984fcea3a3e4a30e4c2d8a6 >>> --- >> This patchset has a lot of repeated(for each API) tests just to check the input parameters to >> Rte_security APIs. I am not sure what value addition is done to separate out each API as a separate >> Negative Test. Instead a single case can be added to test all APIs with inappropriate arguments. >> We should add more positive cases with proper session parameters. >> >> Thomas, >> Do we allow these type of test cases in other modules? > I did not review these patches, but I think we can try to compare > with tests done on eventdev library. > It would be interesting to have an opinion from Declan. > > These rte_security tests look quite big. > However I don't know what is too big for test code? > Lukasz, please could you explain the initial motivation when writing > these tests? Are you especially interested in rte_security? > Or do you plan to reproduce this effort on other libraries? > > Hi Akhil and Thomas, I've just started using dpdk this year and was writing few small apps to get familiar with API. I noticed few things that can be fixed in the security lib and though that they can be fixed easily, so I prepared patches. After that I searched for some unit tests of the lib to add some tests that cover my code. I always try to do so and when I found no tests for security lib I made some. I don't know if you need them or is this the right place to put them, but I did. And as I made the tests I tried to cover 100% code of security lib. Currently I don't have any plans to add or change anything in rte_security. These patches are just a "collateral damage" to my process of learning dpdk and a strong believe that if you can share some fixes you should do it, because that the open source power. So it is totaly up to you, what we can do with these patches. I would be glad to work on them and change them the way you think they should look like, e.g. I can squash all the parameters checks to a single negative case as you, Akhil suggested. If you would like to see similar patches in other libraries I can help with that in some spare time. I'm the new guy here, so please guide me a bit ;) -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com