From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21ECDA034F; Wed, 24 Feb 2021 13:23:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBE48160816; Wed, 24 Feb 2021 13:23:35 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 5D7DF4069B; Wed, 24 Feb 2021 13:23:33 +0100 (CET) IronPort-SDR: jN8IJM0ufqr2iRc9BBCpZ6ANyRCjjqGGiIV0FgWM4Pbutwb2/fkAbDuSaI6y91jJugsc+ttb6K G8WJsTqVuVZA== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="246557228" X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="246557228" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2021 04:23:32 -0800 IronPort-SDR: 9H/JTL998x9SG5rl2+YdFs4v7U3OoI7U1DKmPKck9SNMPCZKq/hBDUZ46kNJ5kYqxgEdAqgEDu gJsTJpyPn0VQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,202,1610438400"; d="scan'208";a="366955721" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 24 Feb 2021 04:23:32 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Feb 2021 04:23:31 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 24 Feb 2021 20:23:29 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.002; Wed, 24 Feb 2021 20:23:29 +0800 From: "Zhang, Qi Z" To: "Guo, Jia" , "Yu, DapengX" , "Wang, Haiyue" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/igc: remove MTU setting limitation Thread-Index: AQHXCl7im6cKbNB020OHI706vVHEvapnOuBw Date: Wed, 24 Feb 2021 12:23:29 +0000 Message-ID: <43b3d3abb311485a95495521928d1318@intel.com> References: <220210219085407.97265-1-dapengx.yu@intel.com> <20210219100107.101938-1-dapengx.yu@intel.com> <3502785c0855451aae90c74426a64ecb@intel.com> In-Reply-To: <3502785c0855451aae90c74426a64ecb@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/igc: remove MTU setting limitation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Guo, Jia > Sent: Wednesday, February 24, 2021 11:41 AM > To: Yu, DapengX ; Wang, Haiyue > > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/igc: remove MTU setting limitation >=20 > Seems that v2 is the same as v1, but v1 exposure the coding style issue. > Anyway please add the change when update new version. Thanks. >=20 > Acked-by: Jeff Guo >=20 > > -----Original Message----- > > From: Yu, DapengX > > Sent: Friday, February 19, 2021 6:01 PM > > To: Guo, Jia ; Wang, Haiyue > > Cc: dev@dpdk.org; Yu, DapengX ; stable@dpdk.org > > Subject: [PATCH v2] net/igc: remove MTU setting limitation > > > > From: Dapeng Yu > > > > Currently, if requested MTU is bigger than mbuf size and scattered > > receive is not enabled, setting MTU to that value fails. > > > > This patch allows setting this special MTU when device is stopped, > > because scattered_rx will be re-configured during next port start and > > driver may enable scattered receive according new MTU value. > > > > After this patch, driver may select different receive function > > automatically after MTU set, according MTU values selected. > > > > Fixes: a5aeb2b9e225 ("net/igc: support Rx and Tx") > > Cc: stable@dpdk.org > > > > Signed-off-by: Dapeng Yu Applied to dpdk-next-net-intel. Thanks Qi