From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0065.outbound.protection.outlook.com [104.47.36.65]) by dpdk.org (Postfix) with ESMTP id 64887201 for ; Tue, 21 Mar 2017 07:19:45 +0100 (CET) Received: from BN3PR0301CA0001.namprd03.prod.outlook.com (10.160.180.139) by CY1PR03MB2266.namprd03.prod.outlook.com (10.166.207.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Tue, 21 Mar 2017 06:19:43 +0000 Received: from BL2FFO11FD041.protection.gbl (2a01:111:f400:7c09::188) by BN3PR0301CA0001.outlook.office365.com (2a01:111:e400:4000::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.977.11 via Frontend Transport; Tue, 21 Mar 2017 06:19:43 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11FD041.mail.protection.outlook.com (10.173.161.137) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.977.7 via Frontend Transport; Tue, 21 Mar 2017 06:19:42 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v2L6Jcox016321; Mon, 20 Mar 2017 23:19:39 -0700 To: "Wiles, Keith" References: <1490004190-16892-1-git-send-email-shreyansh.jain@nxp.com> <2fc176b1-a771-f4b5-a08d-1a31f46884d5@intel.com> <37546ac7-1c60-5992-5ebf-eef8e905017e@nxp.com> <70A6BC7D-3F07-4484-A8E4-ACB14522355B@intel.com> CC: "Hunt, David" , Olivier MATZ , DPDK , Thomas Monjalon , "hemant.agrawal@nxp.com" From: Shreyansh Jain Message-ID: <43b90881-7fc7-8f75-f040-2ad8ea922333@nxp.com> Date: Tue, 21 Mar 2017 11:55:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <70A6BC7D-3F07-4484-A8E4-ACB14522355B@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131345507826192619; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39450400003)(39410400002)(39380400002)(39860400002)(39850400002)(39840400002)(39400400002)(2980300002)(1109001)(1110001)(339900001)(3190300001)(199003)(189002)(24454002)(377454003)(9170700003)(5660300001)(23746002)(4326008)(229853002)(77096006)(33646002)(8936002)(65826007)(50986999)(356003)(8676002)(305945005)(54356999)(105606002)(4001350100001)(76176999)(6916009)(31686004)(106466001)(2950100002)(81166006)(53376002)(93886004)(966004)(2906002)(104016004)(38730400002)(50466002)(36756003)(83506001)(65806001)(230700001)(110136004)(64126003)(85426001)(6306002)(53936002)(31696002)(86362001)(54906002)(6246003)(8656002)(47776003)(189998001)(65956001)(53546009); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2266; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; A:1; MX:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD041; 1:t8aT0EfFBbeww7EJhFh2YuEczJr+3bcyTGEVk2todJ7TZPY6gBN4KhhV46YbiAV7zQAgI/UlFUdVqIrVi6CWxgZTiD1OeJlXag9XkSL+lU1IX3WHEo6CSwgQ1aEaCkppNGMQz9xZB4fcxV8lwOpoJRQQdOGUYmvwr/Fccs99Ial44cReZavD2os7ZmyhxZR/eIYG1CCx5/aYD3WUiFgLsN4xtims2cA3a0bDacfNO6F6OVwHQRHxng5pwcIeoLUdStFziARPkhxbXsfS8GlRgEcSAFMIPMDMNVPfJoP4kzUSiEN09Wt4DaYgR+Rdn1VYXYc9oQfSu9W2sugxURhaZAVkX38dluEyM2FPE597WJCfhOOwunsxxYANf7Qab9Umg0mu2a/DWg0NX0waxWk6Ze0MFhANDeUqBcyFdMTbMxdEELspUDXsC9Og1+31bBfIX6kIyh/5kfm2K5vABmD43TqrrtO44x7TQpqwlaktlh4c6h/AaKZ0hGB7HewBqFXO1jdmY3xX1JbcUcTn998lEnhlmg0I9bFs7AI0/moCryMPHrFMPlc0KUcmPScbQpDV4s0kpODYOk2AhAhoN5x/DdcfDsdnJE3WKqviv+W4v73TAJSM8qlJn4O+frQcsUW+ X-MS-Office365-Filtering-Correlation-Id: 7285d5bc-4a8b-40d9-6f8a-08d470224347 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY1PR03MB2266; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2266; 3:aq72cNRvqpsL3Rfx2bVU9C44oGWh/bbn/Fb6GAMAtYUgDrLQ39uqQeveHnNCeNFCcp7If3oOsNP2sASI01x0gEBNNkJqLhj37IedaxFP9MdzVesrtXWyrZCl+XkijfGJOv/azVyGKNQvImtV6rif0lDCmy/C17bla1zqF4GLkOREBfoa3W9K++k1gz507TX/JPRdCS+0uET2ISvvKi9yNO/Fh9snr9QT6fgQCfUQhvIF9Jsad/3URxvtJhVFOf8BK1GsupBB1C6o0K1US/FUEJ58wtX7CEdmc6MiNEklvjY5nB1mYW0BlhGZVuGGqskwXFa7rEL4IAgX+ZXSe4JjZpPiJmFVrn/Mj+abHmZOWNRgrmelex6GVPpuXrAI+vnI; 25:VEi/nDgRmKWTGQHwpzbCToahbSPzFKxYq4jEhrdP3pXn8nH+lIx6/ENdS3HK4kmgRk/3ntUObHWs929TPg5XBCBxpDBfb8r4L9BStDhgAJBEc+knzQPNwW87OLJ8qzlcngCZtYD/GLJ3smPn3AR1m8uNPC3ys74+ofpkZBBzKacY40hdHBhA79FqkkK8daYkKPmOvi/6TJGukClUpl1iDlycHFt0n9d7gtiSAvgYa36oSRtrsdXw8Vl6oIhhE0ZrqeU9Qa+cPq/T5nOG7T0Ct2GhKxh8eU+yWQKvKwbVNqI+4rnBh3G3WodGlV2mD4kFJNdY3xnpivlLSivr+btADPrK5mLeicEFznfZM/7CPFfnxsdNn3qt+xsMc94nLUmP5A26SPtSaDG39kgIwMFNgGLmWc8iXbCl4VFG1wF8BtKCVM5r74Qn35UwNnCBsh0f1Jc5siSc6ohxOMnXA7xeGA== X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2266; 31:CO1z9zs7bJsMX2IF3ryBTKnAFjGpm990cHCTi6GykrEgXruPUexzb8eSGj6+pSQykzitXRH+NaBZkvbqHT6JufdeJ2vLEXWBMHj/vTc4ymj2NqQbxCGgS/Y2P0bp5FtlNSkWJYkuKPYbBWh/L57bQTMVv5zWswXxzA+xmanrWJRZu6ykmej7x96Udne7HS/MejAf/cz6qzXlyhVHGI3sR5cqz6hMy4cQKbyTGiGo2yxZV7QCN84cqN3Vn49dohBKLG4QI2glEOpelktE9d0rcg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13024025)(13023025)(13015025)(13017025)(8121501046)(13018025)(5005006)(10201501046)(3002001)(6055026)(6096035)(20161123563025)(20161123561025)(20161123556025)(20161123559025)(20161123565025); SRVR:CY1PR03MB2266; BCL:0; PCL:0; RULEID:(400006); SRVR:CY1PR03MB2266; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2266; 4:dfJJcKCFNEcj0hPXQ/7HdfyyUk449UPjJ9+VVSd/jEO67iZ1DwxFhXfi+M+6g0g3YW3BY6f2+b/rS3EbE66VFo0MfO3KN/ePwEcpJvsN2X574ofzVT4bUc/iy6e5bevYCjF5PSf7hq998eU2pqztDMlX+8/OxEfgFjdgSLRdOhu0PU/qBQaeAanoIf9FOlFtkCXnd7NXJwFQQb4xsBDXuhS/U4vWMOV0o+RNRZzr7pBfz5W4jSA8YUqya64QN/xjnSMyuCa+f/Icpv1sTjAMnBD1qBMWcgxF2n8ixgU7YEQEnq1ZjgkChUPa9ptPrjN8XH/R9YinGWExmu5h5M3bO4nvTLBB3LpIyU7RgNgmYPYNKuT5zrKMNQKaHDyWlRUx3+bOn3Huaniwro9vUEakJlOxIQHYN78PNUJyycCse21w+N0dYiNg0zbpVzdoi6llFwrqCcLerK/vSZMf5ldN3LgDgBfxaNbYTFjrM/AH+G42PzMorjqZBhMNW48A8UNHYrxSlUAjYORGyozwK10sabfiqEDeU63VUADiuGnl6Ez61k6sntjAh4rrhno/lsiSDHezeCcxOn9+xqx/D9/ILIvx+Mmeyz+O2fEWS7q3rbt/3cWAXUrYNPRqC/n98cPzcXmpQYpEHV97XTaFe+7mR33LggEPladODcPNvkbdOQyRVJpjlT/MN1N1nVdIvWmjlwUIN7Q5C/AlWcpd6lIyIizk9wBAHZT3Qf0/Qj9fBUWJ41wIonQXWgWMzO0MHhrD X-Forefront-PRVS: 02530BD3AA X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY1PR03MB2266; 23:La1YJaLV7EnP2oPgWel6oMANKLZ6sCt4o7H/u?= =?Windows-1252?Q?VLgkXqhk7bv4MVz463xGm3nb+c5CtOjepFX3CR/xc1xLO4TtIZRs9jRE?= =?Windows-1252?Q?6WKF8870egreT9zZGxblkM5Bj750ioDigvE0BcB5BpVA3MEZUBpngqhW?= =?Windows-1252?Q?Gvqxd8KYQyuYbM/EVU408zBdvfscz6dX9p9kv2hv+0lyJ3FCH0xOMDtV?= =?Windows-1252?Q?FV0qo7G/Ih9Sf+9CCTeUnqmQjbHBUzk3vpxPV3OSyh8NswhR74AIJglI?= =?Windows-1252?Q?b2TBOJq4cu3fJcncX4qdP+BJ7svsY4E/5HCfikRAulI6RjBb55Se468P?= =?Windows-1252?Q?66q4CWLk4KDlEssp9wqJ+p/NZdKucPAHgRhmRrs0jwxiW8A3Y1Bn5fEz?= =?Windows-1252?Q?DAZ3yiBLEn3yj2Z4ZrSyWrM+obR1YaC1OwIyOdvuVJWwU2WAdoyWG+Mp?= =?Windows-1252?Q?VPE6sf5zNVNFv5jJD4zoXxjpC6cAXZPJq+bXI8mRWbdLXV+IgqUMdmLM?= =?Windows-1252?Q?CubjE1Cnhc4RdfdGtHmkCtV8vys2ZXLq8RG0/io9qOjqNcN2xMM5LlL9?= =?Windows-1252?Q?h1DOmtYD76TV28nFfGzzn2b+GhIozT1KUebQFj8FAh+T2jS33bOQxnOC?= =?Windows-1252?Q?/QIFOH1ONMJdbvQT8yp3iVsrAqIn7JCXpoJ4/G09CyjrF5I0tEiQ8jtN?= =?Windows-1252?Q?qCHHxlsryKfRlx5vW/PMQoU1Kfu9zkGf3YZCQwcJdbCsrTsBjBpieROH?= =?Windows-1252?Q?rUFfyh+Sje7jUvElZlAJd9XBcbzmlFjKOm4Oa0feR7iFxw1eBJlPcwWB?= =?Windows-1252?Q?yMknAzyjM26CAIkbLOf+xjneLkHTRsVVDPvw9LxSutmGieWre/yds9sD?= =?Windows-1252?Q?L3EnHo+17ACP1QMtP81sLGxXvBHWI8uJUN9oFmBfyX3O98YH7VhmQ+uT?= =?Windows-1252?Q?5oKesPr8BL9ugKcA+H/fY+fG2DhMLoEcUB9XBoAEhDWeY+PZMuT2G/vA?= =?Windows-1252?Q?Z98PDmCB6kXkwfTkqPsJy6BO8yI2F337sPJTqJRHfTF0EoNQG+T1KVG4?= =?Windows-1252?Q?58A5bBBxUf5O/jz9f1b2lkKSI7javvFzEQ1tVwYYF6pJScxWUUQvkQzV?= =?Windows-1252?Q?N7L3QWB/SelIwXx+hzA0BsqtQSmJUvOFJRoGm0yGWuFvT04b3Xct/g2C?= =?Windows-1252?Q?HO50QAdryuPzlWAmjYx38Nde/cpkFmAZB9cKg1iDvGLkCt/3cI28SqLa?= =?Windows-1252?Q?/okIYDJZaPk3vTQhO7L0dafejG6OwKW43ePHmVK5a4g0Ja+DNaMmVgku?= =?Windows-1252?Q?8j3fLZs0atFg0iIpZCoeGgPq3PASoiemY8E8LsEPFTWlYQCV9PA9qEEv?= =?Windows-1252?Q?rL7mjNS0HlNpHk+lKA1gO3go2A928LMbwYUftO9SzrR2wJ2+KVje53YY?= =?Windows-1252?Q?puA28Q2G2lfzx7v1a8EAhRvlLJIfzgyqxxy8YIt0OZzdMkJq5h6i1z00?= =?Windows-1252?Q?wcL+w/gok2e79zr+bptrkB8Go5zONLmhULjgl8nT3Ag9fY8sBIiuVifQ?= =?Windows-1252?Q?AlbyvJp+nx5elTf49W9pNdINSFBwALOR3lxVtn7+nrskCLHHljiY9fd4?= =?Windows-1252?Q?zDO/4JAyN+HGaPEZVxj7vvQV/vmCDULkZEFANNSqAFXMmO4SC5Q2qUZw?= =?Windows-1252?Q?QV7Agnt8DVAuWN1WDDAtDq5OU84Iic=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2266; 6:mpOYt0kEhZZVQEd1HR/lgliiK0ornCUNa0o/Ik9G/zKvWKZS2g87mdREkCQuL0dbtFPlttWxyH8VAFlrwX2FY/P83RPQ2vDyVflMm4m7DaqlsjLqueoe6H8Rs238trioQPGjmmpZJC3mLe20cDvwrmmCgS2vfkJInk+ciDS5Jg/ahgXqPh5cKAPlgdgDFbLiapU6nJp9qhAEsH2FRShjBYXzRCbfu5bGuQb/QqXyDYxc5mtzrYbg3AzshrAIzEmvwbFUKnF8AAtDLSUfI7WD9xJtWtiG5zVDC+oTc3OiD9qMoAbPEURnXhpH7xcsJ5/LGIC+zQa+FS9JEMm4hMICJFC7XsM91uEiRRP4keLVdZe0iBvbY6PDdkX97U6UJdeIJhFICKk7gXSMubDK0BpYdsdujQJaLdThMXCIXTauQ/s=; 5:sat3Ncm/6jvt1bxw5iTnOfXAsvSca/K1dNo6vXRC1StMHaUEFK4h9G6HEszFT4HpbTgxUlXR3lr+p9Ebpw9NCrcsbVfZU0plqeRzLOD+iSfSwOjD3jShyO8ajSqja0yvlnMgLvJ9NlmRAWmVs7Zqr0NJ5VheYcuIUr2QvqKx9X3ygm1nPtZSrInfxdeaC5oE; 24:OHR7lXItzAJcscgPM8lzsiiNRHrZ0CKpYD2LOEmmpbaVpR9LBO+cfF/4msc3ydnRrJlISoHjVxf4vOy0zgvgVJHI2YcsRVamvjW3uaEPwcY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2266; 7:j1NNuCQZP8wS7Kw5GzCqhhV088q5gNqc2uayxoPFkczMC/fzvb7CNHWnKY/0GsAfuokW8UED7IVVr75VcNIZKHHA+BaqokJHTilDybqpAqFwogVHmYq34hHTF40GtzkxokOU8e2HgCQeVP0VBB1uSbUon2+ig8bGAXmpKuN2leV8BjgkcgjZwJQ1IMEzZXPkwjLn67iOuq81xgjGWZAcL4U4eRaprrB/Q0c96u4APCTW2tROvvtGRe2jedfptlJjAfuno8K76O2osBcEh/CmHIJiqqJCohqPvy+WG0wy6fSDKcuIZOGjuvHxqjTSvWB7qf9hBmJhiTSDga5bZeJc6Q== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2017 06:19:42.4008 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2266 Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 06:19:46 -0000 Hello Keith, On Tuesday 21 March 2017 11:32 AM, Wiles, Keith wrote: > >> On Mar 20, 2017, at 11:55 PM, Shreyansh Jain wrote: >> >> Hello David, >> >> On Monday 20 March 2017 08:20 PM, Hunt, David wrote: >>> >>> On 20/3/2017 10:03 AM, Shreyansh Jain wrote: >>>> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base. >>>> Stack mempool handler moved from lib/librte_mempool into drivers/mempool. >>>> >> >> <...> >> >>>> -} >>>> - >>>> -static struct rte_mempool_ops ops_stack = { >>>> - .name = "stack", >>>> - .alloc = stack_alloc, >>>> - .free = stack_free, >>>> - .enqueue = stack_enqueue, >>>> - .dequeue = stack_dequeue, >>>> - .get_count = stack_get_count >>>> -}; >>>> - >>>> -MEMPOOL_REGISTER_OPS(ops_stack); >>> >>> Shreyansh, >>> Could I suggest you add the parameter "--find-renames" when >>> generating the patch files, as this will reduce the size of the patches >>> significantly, making for easier review. The patch line count in this >>> particular case would be reduced by approx 75%. >> >> Thanks for suggestion. >> Yes, I forgot to use this option while creating this patch. If there >> are comments and v2 needs to be created, I will keep this in mind. >> >>> Regards, >>> Dave. > > I guess I missed an email, but what is the advantage of moving the ring/stack files to the drivers directory as they are not drivers in the sense of a NIC PMD or any other driver. You can still enable/disable them in the config files right? > Just as reference, following is where this was being discussed: http://dpdk.org/ml/archives/dev/2017-March/059690.html http://dpdk.org/ml/archives/dev/2017-March/059753.html and http://dpdk.org/ml/archives/dev/2017-March/060501.html Also, a while back (I can't trace that mailing list exchange), it was decided that all mempool drivers (stack, ring, others...) would be moved to drivers/mempool. For NXP's DPAA2 PMD, we use an offloaded mempool for which there was a patchset by Hemant [1] which adds that driver to drivers/mempool. In the same breadth, ring and stack are also being moved to drivers/mempool as independent drivers (non-offloaded category). [1] http://dpdk.org/ml/archives/dev/2017-March/060476.html In my opinion, this would make the lib/* area free of handler/drivers (almost) and it is a good change. Also, ring and stack use a 'registration' mechanism - just like PMD and are good candidate to be treated as 'drivers' now even though not entirely like a PMD. You see any downside of this? > Regards, > Keith > > - Shreyansh