From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53867A0A0A; Wed, 20 Jan 2021 18:57:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F93D140E31; Wed, 20 Jan 2021 18:57:35 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 58224140E1E for ; Wed, 20 Jan 2021 18:57:34 +0100 (CET) IronPort-SDR: KJI6jiW88O86OwEUSAzYWF7yzDy8ftRjE++GjfT+I3EgXJByit5fIGvTXzf45ASV5QwT5Q0//3 qo4jZrdm+bgw== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="197880051" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="197880051" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 09:57:33 -0800 IronPort-SDR: 0X5mD0k096rGwNoUpAMdVWq/B2rzRSKilafaBNXVQdSc0tJiC+knCWIliMkEIe80oc4dLUrXNe Et+FpTPFjvpw== X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="366340363" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.192.162]) ([10.213.192.162]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 09:57:31 -0800 To: Jiawei Wang , wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, orika@nvidia.com, viacheslavo@nvidia.com, thomas@monjalon.net, rasland@nvidia.com Cc: dev@dpdk.org References: <1609942417-259610-1-git-send-email-jiaweiw@nvidia.com> <1611125417-368324-1-git-send-email-jiaweiw@nvidia.com> From: Ferruh Yigit Message-ID: <43f528d3-ded3-be32-84f3-5d57142412f0@intel.com> Date: Wed, 20 Jan 2021 17:57:27 +0000 MIME-Version: 1.0 In-Reply-To: <1611125417-368324-1-git-send-email-jiaweiw@nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7] app/testpmd: fix testpmd packets dump overlapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/20/2021 6:50 AM, Jiawei Wang wrote: > When testpmd enabled the verbosity for the received packets, if two packets > were received at the same time, for example, sampling packet and normal > packet, the dump output of these packets may be overlapping due to multiple > core handling the multiple queues simultaneously. > > The patch uses one string buffer that collects all the packet dump output > into this buffer and then printouts it at last, that guarantees to printout > separately the dump output per packet. > > Fixes: d862c45 ("app/testpmd: move dumping packets to a separate function") > > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.