From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 20C542C50 for <dev@dpdk.org>; Wed, 19 Jul 2017 15:32:43 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2017 06:32:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,381,1496127600"; d="scan'208";a="109677936" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.133.153]) ([10.255.133.153]) by orsmga004.jf.intel.com with ESMTP; 19 Jul 2017 06:32:37 -0700 To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, Shijith Thotton <shijith.thotton@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: Gregory Etelson <gregory@weka.io>, Thomas Monjalon <thomas@monjalon.net>, Stephen Hemminger <stephen@networkplumber.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com> References: <1497260285-27536-1-git-send-email-shijith.thotton@caviumnetworks.com> <1499426031-2664-1-git-send-email-shijith.thotton@caviumnetworks.com> <ED26CBA2FAD1BF48A8719AEF02201E3651230B20@SHSMSX103.ccr.corp.intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <43fc4f53-404d-242b-4a6e-508966b236af@intel.com> Date: Wed, 19 Jul 2017 14:32:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E3651230B20@SHSMSX103.ccr.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 19 Jul 2017 13:32:44 -0000 On 7/12/2017 4:40 AM, Tan, Jianfeng wrote: > > >> -----Original Message----- >> From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] >> Sent: Friday, July 7, 2017 7:14 PM >> To: dev@dpdk.org >> Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; >> Tan, Jianfeng; Lu, Wenzhuo >> Subject: [PATCH v2] igb_uio: issue FLR during open and release of device file >> >> Set UIO info device file operations open and release. Call pci reset >> function inside open and release to clear device state at start and end. >> Copied this behaviour from vfio_pci kernel module code. With this patch, >> it is not mandatory to issue FLR by PMD's during init and close. >> >> Bus master enable and disable are added in open and release respectively >> to take care of device DMA. >> >> Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com> > > Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>