From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 081912BA1 for ; Wed, 7 Jun 2017 16:16:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 77EF020C0D; Wed, 7 Jun 2017 10:16:59 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 07 Jun 2017 10:16:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Z5RmT3ppQKc6W7u PGtpLF35fSdqtzEWtEfF6QMA+weA=; b=M6zWQ+4Iu5Rq+NYsECQK2eYvkffB/kU xn8ptyx4wjsR9WqtGUMYxPDZA9+SAH6TBx4Fq87xpCVsj9ry796NJRHqNZ/7ii+u TidTnPpuOEr0RoL6HQDoqBQtx1lQmkWH/fuJSOkTVpqbbd3d9Gg+x/cRtgfOsJDP KDFTtakxl9jA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Z5RmT3ppQKc6W7uPGtpLF35fSdqtzEWtEfF6QMA+weA=; b=fSf5t9xW ZmwG23FvumN/TL7zGXVc6mBv0HRdpPv/BYXItTJviQ3F+CSg9DMBtFFVkYyoDi1G AZI3G0U2rf6s2cgmQppdSAlg+z7uByPAIfVO/2DAoSUKuyl201elrmFI9EkJQMx1 UPX+s9efHwwrDbmrdwWf4Dm3l8zV9iiTMWFbH/BlftwXLn0kSqSNsjnyxl/WH4Zf ZB+S4pTfOCPyRZ5MZRojoVYWLnC+Be1993i300mQFfwucBvYI6GAba9/n501ie7T rt7Ul0+yFZIMCcWJoeB26nYxbcSN/w7Y05T1uvR00NJ/xIBY5psHx9im9gvSA/T8 Ck8eqmQXvy1dmA== X-ME-Sender: X-Sasl-enc: fPvmdB9ZOC51PI4xTdvOIjSfL2QikqgmaAHFizsT2LMv 1496845019 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2BB83241E0; Wed, 7 Jun 2017 10:16:59 -0400 (EDT) From: Thomas Monjalon To: Adrien Mazarguil Cc: dev@dpdk.org Date: Wed, 07 Jun 2017 16:16:58 +0200 Message-ID: <44029570.D8ug5AmCbY@xps> In-Reply-To: <840342851720fc237214aeb30d38565615293b58.1495101988.git.adrien.mazarguil@6wind.com> References: <840342851720fc237214aeb30d38565615293b58.1495101988.git.adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] eal: add static endianness conversion macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 14:17:00 -0000 Hi, some comments below: 18/05/2017 12:14, Adrien Mazarguil: > These macros resolve to constant expressions that allow developers to > perform endianness conversion on static/const objects, even outside of > function scope as they do not translate to function calls. > > This is most useful for static initializers and constant values (whenever > it has to be performed at compilation time). Run-time endianness conversion > of variable values should keep using rte_*_to_*() calls for best > performance. > > Signed-off-by: Adrien Mazarguil [...] > +#define RTE_STATIC_BSWAP64(v) \ > + ((((uint64_t)(v) & UINT64_C(0x00000000000000ff)) << 56) | \ > + (((uint64_t)(v) & UINT64_C(0x000000000000ff00)) << 40) | \ > + (((uint64_t)(v) & UINT64_C(0x0000000000ff0000)) << 24) | \ > + (((uint64_t)(v) & UINT64_C(0x00000000ff000000)) << 8) | \ > + (((uint64_t)(v) & UINT64_C(0x000000ff00000000)) >> 8) | \ > + (((uint64_t)(v) & UINT64_C(0x0000ff0000000000)) >> 24) | \ > + (((uint64_t)(v) & UINT64_C(0x00ff000000000000)) >> 40) | \ > + (((uint64_t)(v) & UINT64_C(0xff00000000000000)) >> 56)) Minor nit: you could align lines by inserting a space before 8. > +#if RTE_BYTE_ORDER == RTE_BIG_ENDIAN > +#define RTE_BE16(v) (uint16_t)(v) > +#define RTE_BE32(v) (uint32_t)(v) > +#define RTE_BE64(v) (uint64_t)(v) > +#define RTE_LE16(v) RTE_STATIC_BSWAP16(v) > +#define RTE_LE32(v) RTE_STATIC_BSWAP32(v) > +#define RTE_LE64(v) RTE_STATIC_BSWAP64(v) > +#elif RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN > +#define RTE_BE16(v) RTE_STATIC_BSWAP16(v) > +#define RTE_BE32(v) RTE_STATIC_BSWAP32(v) > +#define RTE_BE64(v) RTE_STATIC_BSWAP64(v) > +#define RTE_LE16(v) (uint16_t)(v) > +#define RTE_LE32(v) (uint32_t)(v) > +#define RTE_LE64(v) (uint64_t)(v) This naming is confusing. Let's take RTE_BE16() as example, it does not say wether the input value is big endian or the output value will be big endian. I think we should mimic the wording of run-time conversions: RTE_BE_TO_CPU_16() Any other ideas?