From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 11A1620BD for ; Wed, 2 May 2018 23:01:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AB54221BEA; Wed, 2 May 2018 17:01:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 02 May 2018 17:01:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=VpdU5T54DKsCzUTpoHgiHMOftf 11Cc4/s+lZjJJbmAI=; b=QJLZaY/KuLY7HK8Ap6uf4g24+s7YRlpoakAp8o06OV RVeZ5ffnPIbv2hwwurUy4QR4Q3IHDW3VE2KQYMPusmvIQ3F7/DTBpLAkxiqGYAB8 YZGwbhEbeXRUM7aw8ERVHypi9Pk2DHZKA70kXBgnt0p2WIMVu+cXcdeUd04pIxlY 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=VpdU5T 54DKsCzUTpoHgiHMOftf11Cc4/s+lZjJJbmAI=; b=Qh5AoFAueejLYrVfeCPMCd qqdRC3WahQXywWMgfZqp4VofUk/xh+wSDkThx50KJ3eNjwcmnHxB+ePIxVUm52fZ 5JtYjGXQh9L7Xgza7Sq0g4myIS+IIxGYZCJzCklG/yQxzXW7/bLYrCuc0PRNyyjv EbxqdOkJG3jBFkqaFvSQ/Ms1oOib2znYejXsot8BxHWcpmrx7VTlAjF1p1XgYNeq U/ovArLoAek2sp+2ahzCIysHuTn1/gBYkBiGridUxNH5cPd7601I8Eg03/dw8maA VJudgvCrAmw3YEwclPs6wHP0keZsNEiSgXAcDPq1iEc8IwB1vAx57DV/0oEov1vg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F08D9E50A4; Wed, 2 May 2018 17:01:02 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson , Anatoly Burakov Cc: dev@dpdk.org Date: Wed, 02 May 2018 23:00:59 +0200 Message-ID: <4409303.1sNuYAC1ue@xps> In-Reply-To: <20180430125035.GB100464@bricha3-MOBL.ger.corp.intel.com> References: <73e35ca9ce462ab097c6ca8e7cbfdd5b8bc06c1d.1525086045.git.anatoly.burakov@intel.com> <20180430125035.GB100464@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/2] mem: unmap unneeded space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2018 21:01:04 -0000 30/04/2018 14:50, Bruce Richardson: > On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote: > > When we ask to reserve virtual areas, we usually include > > alignment in the mapping size, and that memory ends up > > being wasted. Wasting a gigabyte of VA space while trying to > > reserve one gigabyte is pretty expensive on 32-bit, so after > > we're done mapping, unmap unneeded space. > > > > Signed-off-by: Anatoly Burakov > > --- > > > > Notes: > > v2: > > - Split fix for size_t overflow into separate patch > > - Improve readability of unmapping code > > - Added comment explaining why unmapping is done > > > Acked-by: Bruce Richardson I am not confident pushing this change post-rc1. Please can we have more validation tests with this patch?