From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4D75A0546; Fri, 30 Apr 2021 08:47:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63C3640688; Fri, 30 Apr 2021 08:47:42 +0200 (CEST) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 3138440395 for ; Fri, 30 Apr 2021 08:47:39 +0200 (CEST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FWjXz34J6zBtL2; Fri, 30 Apr 2021 14:45:07 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.498.0; Fri, 30 Apr 2021 14:47:30 +0800 To: Chengchang Tang , CC: , , , References: <1618571071-5927-1-git-send-email-tangchengchang@huawei.com> <1619171202-28486-1-git-send-email-tangchengchang@huawei.com> <46d7ca0a-155b-d7d2-72da-5a3bdf15d0d6@huawei.com> From: "Min Hu (Connor)" Message-ID: <440ca32c-6564-269a-afd8-57bb561357c7@huawei.com> Date: Fri, 30 Apr 2021 14:47:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <46d7ca0a-155b-d7d2-72da-5a3bdf15d0d6@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 0/2] add Tx prepare support for bonding device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/30 14:26, Chengchang Tang 写道: > Hi，all > Any comments？ > > On 2021/4/23 17:46, Chengchang Tang wrote: >> This patch set add Tx prepare for bonding device. >> >> Currently, the bonding driver has not implemented the callback of >> rte_eth_tx_prepare function. Therefore, the TX prepare function of the >> slave devices will never be invoked. When hardware offloading such as >> CKSUM and TSO are enabled for some drivers, tx_prepare needs to be used >> to adjust packets (for example, set correct pseudo packet headers). >> Otherwise, related offloading fails and even packets are sent >> incorrectly. Due to this limitation, the bonded device cannot use these >> HW offloading in the Tx direction. >> >> Because packet sending algorithms are numerous and complex in bond PMD, >> it is hard to design the callback for rte_eth_tx_prepare. In this >> patchset, the tx_prepare callback of bonding PMD is not implemented. >> Instead, rte_eth_tx_prepare has been called in tx_burst callback. In >> this way, all tx_offloads can be processed correctly for all NIC devices. >> It is the responsibility of the slave PMDs to decide when the real >> tx_prepare needs to be used. If tx_prepare is not required in some cases, >> then slave PMDs tx_prepare pointer should be NULL and rte_eth_tx_prepare() >> will be just a NOOP. That is, the effectiveness and security of tx_prepare >> and its impact on performance depend on the design of slave PMDs. >> >> And configuring Tx offloading for bonding is also added in this patchset. >> This solves the problem that we need to configure slave devices one by one >> when configuring Tx offloading. >> >> Chengchang Tang (2): >> net/bonding: support Tx prepare for bonding >> net/bonding: support configuring Tx offloading for bonding >> >> drivers/net/bonding/rte_eth_bond.h | 1 - >> drivers/net/bonding/rte_eth_bond_pmd.c | 41 ++++++++++++++++++++++++++++++---- >> 2 files changed, 37 insertions(+), 5 deletions(-) >> Acked-by: Min Hu (Connor) >> -- >> 2.7.4 >> >> >> . >> > > . >