From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FD0CA0032; Fri, 15 Jul 2022 17:32:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EEE640A87; Fri, 15 Jul 2022 17:32:23 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 8CAD940696 for ; Fri, 15 Jul 2022 17:32:21 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1C2315C00C7; Fri, 15 Jul 2022 11:32:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 15 Jul 2022 11:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1657899139; x= 1657985539; bh=S0a2KL+io8Z0/UEqS7ai6aTLfeVjYw8KlfyVGmQ7yso=; b=G AKmevJWre0kiesd7aq1hWAMV9z4zx7iWpNpZ1BHREZnyDqoBaa7zUDYRcea11E/V Y2gSIhW6b+4WCF0ghZB7Gbj/rnm8n5ABJ4gMvbQDD1xMeEOpZXt8jeWsw5ypqQ6W VhW63xAfWJejjSi8L6KAezea8EGBQn/RgzKNxIRpPpmAfutXOcl+X4BEDUFfPI2k 4b+V5jBas9JBt7SFfb11Hs/iDR2d3SXDQnnW/WzjenclXPy1aRvE8vHEUXvAPh5r jdeakziO7bPBjVkDauQy/1cVccyd1cUKhqzTwdCxh7kpPCR1oqvqk0iuArrDtuIZ LuM7m5gUwGD4c+kIlxDbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657899139; x= 1657985539; bh=S0a2KL+io8Z0/UEqS7ai6aTLfeVjYw8KlfyVGmQ7yso=; b=V TRs926o5UkPuTxj3N6qLYgoyLZ1Tdam5l512dp7NK1ooDIUITdEreWnupDccn5XL R6JekrBSpMnW1Ytz1wP8irUDmqil7cROMsmhMYBIdWfpSdgZfJilUn7EQOaSKXSK iYR1M9EKl6e9npoEVWwQ+IooUYH9kYgp/n8KjawKCjKzYTpjFiJwYfu2NrfiW+pE zMaYo4w97QqgmofcvJUm41V1I2Ha6Jg4V6Ud2vc8W+it0BYlXUkkY92x9JOvb1hN 4pqO77r9Waa78+cHBLvijM4THW4JnUtBPgRctiZtu28HeQtbcbYTFn/yBsAMP83h su9zs/RQ9ajgVjH2nA2Dw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekuddgleduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeejjefffffgffekfefflefgkeelteejffelledugefhheelffet heevudffudfgvdenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 15 Jul 2022 11:32:16 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Bruce Richardson , "Mcnamara, John" , dev@dpdk.org, david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, maxime.coquelin@redhat.com, chenbo.xia@intel.com, mdr@ashroe.eu, olivier.matz@6wind.com, jerinj@marvell.com Subject: Re: [PATCH v4] doc: announce KNI deprecation Date: Fri, 15 Jul 2022 17:32:14 +0200 Message-ID: <4410920.LvFx2qVVIh@thomas> In-Reply-To: <9eeed029-5fb3-b999-b532-59f3f5743144@xilinx.com> References: <20211124171609.3101896-2-ferruh.yigit@intel.com> <9eeed029-5fb3-b999-b532-59f3f5743144@xilinx.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/07/2022 17:03, Ferruh Yigit: > On 7/14/2022 3:50 PM, Ferruh Yigit wrote: > > On 7/14/2022 10:20 AM, Bruce Richardson wrote: > >> On Wed, Jul 13, 2022 at 06:10:47PM +0200, Thomas Monjalon wrote: > >>> From: Ferruh Yigit > >>> > >>> Announce the deprecation plan for KNI kernel module, library and > >>> example. > >>> > >>> Signed-off-by: Ferruh Yigit > >>> Signed-off-by: Thomas Monjalon > >>> --- > >>> Squashed and updated 2 deprecations: > >>> https://patches.dpdk.org/project/dpdk/patch/20211124171609.3101896-2-ferruh.yigit@intel.com/ > >>> https://patches.dpdk.org/project/dpdk/patch/20211124171609.3101896-2-ferruh.yigit@intel.com/ > >>> --- > >> > >> One suggestion below. > >> With corrected link and with/without suggested change: > >> > >> Acked-by: Bruce Richardson > >> > >>> doc/guides/prog_guide/kernel_nic_interface.rst | 3 +++ > >>> doc/guides/rel_notes/deprecation.rst | 9 +++++++++ > >>> 2 files changed, 12 insertions(+) > >>> > >>> diff --git a/doc/guides/prog_guide/kernel_nic_interface.rst > >>> b/doc/guides/prog_guide/kernel_nic_interface.rst > >>> index e021cc69b6..03b5bca958 100644 > >>> --- a/doc/guides/prog_guide/kernel_nic_interface.rst > >>> +++ b/doc/guides/prog_guide/kernel_nic_interface.rst > >>> @@ -8,6 +8,9 @@ Kernel NIC Interface > >>> .. note:: > >>> + KNI is deprecated and will be removed in future. > >>> + See :doc:`../rel_notes/deprecation`. > >>> + > >>> For an alternative to KNI, that does not require any out-of-tree > >>> Linux kernel modules, > >>> or a custom library, see :ref:`virtio_user_as_exception_path`. > >>> diff --git a/doc/guides/rel_notes/deprecation.rst > >>> b/doc/guides/rel_notes/deprecation.rst > >>> index 4e5b23c53d..e54597c591 100644 > >>> --- a/doc/guides/rel_notes/deprecation.rst > >>> +++ b/doc/guides/rel_notes/deprecation.rst > >>> @@ -48,6 +48,15 @@ Deprecation Notices > >>> in the header will not be considered as ABI anymore. This change > >>> is inspired > >>> by the RFC > >>> https://patchwork.dpdk.org/project/dpdk/list/?series=17176. > >>> +* kni: The KNI kernel module and library are not recommended for use > >>> by new > >>> + applications - other technologies such as virtio-user are > >>> recommended instead. > >>> + The KNI kernel module and library will be removed from DPDK 23.11, > >>> + following the DPDK technical board > >>> + `decision > >>> `_ > >>> + and `refinement > >>> `_. > >>> + The first steps are to add deprecation warnings > >>> + and to remove the example application from 22.11. > >>> + > >> > >> I wonder whether having this done as bullet points in chronological order > >> might be clearer. Something like: > >> > >> * kni: The KNI kernel module and library are not recommended for use > >> by new > >> applications - other technologies such as virtio-user are > >> recommended instead. > >> Following the DPDK technical board > >> `decision > >> `_ > >> and `refinement > >> `_: > >> * The KNI example application will be removed from DPDK 22.11 release > >> * The KNI kernel module and library will be removed from the DPDK > >> 23.11 > >> release > > > > +1 to list actions in chronological order > > > > I have a concern with removing sample application without replacing one > > with alternate methods: virtio-user and tun/tap. > > > > It is easy to create a virtio-user PMD by testpmd or any sample > > application, and as far as I understand Bruce already documented this. > > But for many KNI users they are not using KNI PMD, so replacing KNI with > > this new method may require some hand holding. > > As mentioned KNI PMD, it also should be removed when library and module > are removed, may be good to list above to be explicit. Yes I'm adding the PMD in removal list. > > One option can be hotplug the virtio-user PMD and use the port_id for > > packet forwarding, and I don't know if the PMD has APIs that > > applications can use directly, as done in KNI, @Maxime & @Chenbo can > > answer this better. > > > > It can be good to have a sample application for above before deprecating > > the KNI sample application. > > And same sample can use tun/tap PMD with a runtime parameter, to show > > how other example can be used, again tap can be used as tap PMD or Linux > > tun/tap APIs. > > > > Question is who can work on such a sample, but if we can find some > > resource I am for having a replacement exception path sample app before > > deprecating KNI. We are not sure we'll have time and resource, and it has not been discussed earlier. Thus I'll consider having a replacement example as a nice-to-have. I have to be a bit conservative with techboard decisions.