From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5A23A00C5; Wed, 2 Feb 2022 13:24:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A85240689; Wed, 2 Feb 2022 13:24:38 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 1C1D640688 for ; Wed, 2 Feb 2022 13:24:37 +0100 (CET) Received: by shelob.oktetlabs.ru (Postfix, from userid 115) id 7157A4A; Wed, 2 Feb 2022 15:24:36 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from bree.oktetlabs.ru (bree.oktetlabs.ru [192.168.34.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPS id 47F9F38; Wed, 2 Feb 2022 15:24:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 47F9F38 Authentication-Results: shelob.oktetlabs.ru/47F9F38; dkim=none; dkim-atps=neutral Date: Wed, 2 Feb 2022 15:24:35 +0300 (MSK) From: Ivan Malov To: Ray Kinsella cc: dev@dpdk.org, Andrew Rybchenko , Andy Moreton , Thomas Monjalon , ferruh.yigit@intel.com, David Marchand Subject: Re: [PATCH 5/8] common/sfc_efx/base: support selecting RSS table entry count In-Reply-To: <87fsp11o7j.fsf@mdr78.vserver.site> Message-ID: <4418bec2-9810-d614-1c49-a9327da6039@oktetlabs.ru> References: <20220201085002.320102-1-ivan.malov@oktetlabs.ru> <20220201085002.320102-6-ivan.malov@oktetlabs.ru> <87fsp11o7j.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On Wed, 2 Feb 2022, Ray Kinsella wrote: > > Ivan Malov writes: > >> On Riverhead boards, the client can control how many entries >> to have in the indirection table of an exclusive RSS context. >> >> Provide the new parameter to clients and indicate its bounds. >> Extend the API for writing the table to have the flexibility. >> >> Signed-off-by: Ivan Malov >> Reviewed-by: Andrew Rybchenko >> Reviewed-by: Andy Moreton >> --- >> drivers/common/sfc_efx/base/ef10_impl.h | 1 + >> drivers/common/sfc_efx/base/ef10_nic.c | 13 +++ >> drivers/common/sfc_efx/base/ef10_rx.c | 136 +++++++++++++++++++++-- >> drivers/common/sfc_efx/base/efx.h | 18 +++ >> drivers/common/sfc_efx/base/efx_impl.h | 3 +- >> drivers/common/sfc_efx/base/efx_mcdi.h | 11 ++ >> drivers/common/sfc_efx/base/efx_rx.c | 38 ++++++- >> drivers/common/sfc_efx/base/rhead_impl.h | 1 + >> drivers/common/sfc_efx/base/rhead_rx.c | 4 +- >> drivers/common/sfc_efx/version.map | 1 + >> 10 files changed, 212 insertions(+), 14 deletions(-) >> >> >> diff --git a/drivers/common/sfc_efx/version.map b/drivers/common/sfc_efx/version.map >> index 97dd943ec4..9510897b83 100644 >> --- a/drivers/common/sfc_efx/version.map >> +++ b/drivers/common/sfc_efx/version.map >> @@ -216,6 +216,7 @@ INTERNAL { >> efx_rx_qpost; >> efx_rx_qpush; >> efx_rx_scale_context_alloc; >> + efx_rx_scale_context_alloc_v2; >> efx_rx_scale_context_free; >> efx_rx_scale_default_support_get; >> efx_rx_scale_hash_flags_get; > > So this internal, so ordinarly I have little enough to do or say about > it. In this case, I do have to ask is the _v2 version of the function > avoidable? The PMD in question is not the only driver based on libefx. Extending efx_rx_scale_context_alloc() to add an extra argument would require that the other libefx-based drivers be updated accordingly. That is not always reasonable / robust. Hence the v2 method. Thank you. -- Ivan M