From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ktraynor@redhat.com> Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8A6AD1B5E2 for <dev@dpdk.org>; Tue, 7 Nov 2017 12:51:22 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A4B11C057FA7; Tue, 7 Nov 2017 11:51:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A4B11C057FA7 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=ktraynor@redhat.com Received: from ktraynor.remote.csb (unknown [10.36.117.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2BEC5D9CD; Tue, 7 Nov 2017 11:51:19 +0000 (UTC) To: Maxime Coquelin <maxime.coquelin@redhat.com>, "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "yliu@fridaylinux.org" <yliu@fridaylinux.org>, "thomas@monjalon.net" <thomas@monjalon.net>, "Loftus, Ciara" <ciara.loftus@intel.com> References: <20171103175735.24603-1-maxime.coquelin@redhat.com> <20171106203812.18428-1-maxime.coquelin@redhat.com> <DC5AD7FA266D86499789B1BCAEC715F8D3A42A55@irsmsx105.ger.corp.intel.com> <25b7a450-37f8-48e7-4daf-90d23a507e82@redhat.com> <63345029-2bc9-cbb5-aeeb-fa15260e807b@redhat.com> From: Kevin Traynor <ktraynor@redhat.com> Organization: Red Hat Message-ID: <441a6151-baf4-6814-8489-34aa767fe2bf@redhat.com> Date: Tue, 7 Nov 2017 11:51:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <63345029-2bc9-cbb5-aeeb-fa15260e807b@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 07 Nov 2017 11:51:22 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2 0/3] vhost: disable iommu support by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 07 Nov 2017 11:51:22 -0000 On 11/07/2017 11:30 AM, Maxime Coquelin wrote: > > > On 11/07/2017 12:25 PM, Kevin Traynor wrote: >> On 11/07/2017 10:56 AM, Kavanagh, Mark B wrote: >>>> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >>>> Sent: Monday, November 6, 2017 8:38 PM >>>> To: dev@dpdk.org; yliu@fridaylinux.org; Kavanagh, Mark B >>>> <mark.b.kavanagh@intel.com>; thomas@monjalon.net; ktraynor@redhat.com >>>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com> >>>> Subject: [PATCH v2 0/3] vhost: disable iommu support by default >>>> >>>> This series disables IOMMU feature by default, and introduce >>>> a new flag passed at vhost device registration time to enable >>>> it explicitly. >>>> >>>> When disabled, patch 1 also disables reply-ack protocol feature >>>> to avoid Qemu v2.7.0-v2.9.0 reply-ack bug with multiqueue. >>>> >>>> Last patch adds a Vhost PMD "iommu-support" parameter to enable >>>> the IOMMU feature. >>> > > Hi Kevin, > >> Hi Maxime - OVS-DPDK does not use the vhost pmd, so that means that >> iommu could not be used with OVS-DPDK at present. Did I get that right? > > No :) > Good :) > This is supported both with and without using Vhost PMD. > > When using the Vhost lib directly, you just have to pass > RTE_VHOST_USER_IOMMU_SUPPORT flag to rte_vhost_driver_register(), > this is patch 1. > > When using Vhost PMD, passing the iommu-support=1 option to the vdev > cmdline will set this flag, this is patch 2. > Ah ok, just catching up, thanks for the ABC. It seems like a good compromise, sorry for the noise. > Thanks, > Maxime > >> Ciara proposed patches for vhost pmd in OVS-DPDK but it is quite an >> intrusive change and has been postponed multiple times due to various >> issues. >> >> thanks, >> Kevin. >> >>> Hi Maxime, >>> >>> I'm happy to confirm that this patchset resolves the vhost user >>> mutltiq issue for OvS-DPDK, with QEMU v2.7.1. >>> >>> Additionally, all of the individual patches look good - thanks for >>> all of your efforts on this! >>> >>> Tested-by: Mark Kavanagh <mark.b.kavanagh@intel.com> >>> Acked-by: Mark Kavanagh <mark.b.kavanagh@intel.com> >>> >>> Cheers, >>> Mark >>> >>>> >>>> Maxime Coquelin (3): >>>> vhost: disable reply-ack protocol feature if iommu feature disabled >>>> vhost: add flag to enable iommu support >>>> net: vhost: add iommu-support parameter to enable IOMMU feature >>>> >>>> doc/guides/nics/vhost.rst | 5 +++++ >>>> doc/guides/prog_guide/vhost_lib.rst | 14 ++++++++++++++ >>>> doc/guides/rel_notes/release_17_11.rst | 3 ++- >>>> drivers/net/vhost/rte_eth_vhost.c | 13 +++++++++++++ >>>> lib/librte_vhost/rte_vhost.h | 1 + >>>> lib/librte_vhost/socket.c | 6 ++++++ >>>> lib/librte_vhost/vhost_user.c | 24 ++++++++++++++++++++++-- >>>> 7 files changed, 63 insertions(+), 3 deletions(-) >>>> >>>> -- >>>> 2.13.6 >>> >>