From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF55AA00E6 for ; Thu, 11 Jul 2019 00:08:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E147A322C; Thu, 11 Jul 2019 00:08:14 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id CFC443195; Thu, 11 Jul 2019 00:08:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 66ED73C8; Wed, 10 Jul 2019 18:08:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 10 Jul 2019 18:08:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FJlA/GgE52v4gsJ0zoKnK8IQcTMrFh7wTkK8bPbyJhY=; b=iuH0i9meErNv UZUR7tfapRAkLkMehf3IOCe0w02aAsu6NzxqT1ciW5xkUlscfD9qCHYDrRxc2Dys v2rv/lF+NIuFWCjSWjsxZCtg4BZzCHy5iDvuitT71KQ7a1NsrXMFQZnxR2T/xARy DTv76dM0G/OZArgKGeSEfbRMO7tj8Hk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=FJlA/GgE52v4gsJ0zoKnK8IQcTMrFh7wTkK8bPbyJ hY=; b=mIF7PbWySw/9zFFJKmcjcR+roThZq+wu+KS4/X7RrAV88KaNiJfcjH0b0 54xiqMpOrCuD+WHkYA1xJMIjXisXjEMMPJ9aNkqZ1JkKjXgiEtB5mxoid3tJy2ON y0onm+quTENO2d2pa02cJ7v7z9cJwaRxydLHkf6fC0GxqdZEqXIe1kKI4eLlWyDV aSIrFy7jij/HWPqd2eND4sh2JV1KM0mYEv9hnNNiWPel/ta9mAcu5KRdm8rm0i8f 1MTw8pWR50loOjUEL/wOT4k8T4HldqQxL9dEhaeTv4b21Lqgf2gAJYmkghZiHol9 leEDvQtpc/KNwokjaNh73X2zG9MqQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeejgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 452A5380079; Wed, 10 Jul 2019 18:08:10 -0400 (EDT) From: Thomas Monjalon To: Harman Kalra Cc: stable@dpdk.org, "remy.horton@intel.com" , "reshma.pattan@intel.com" , "anatoly.burakov@intel.com" , "marko.kovacevic@intel.com" , "john.mcnamara@intel.com" , "dev@dpdk.org" , jerinj@marvell.com Date: Thu, 11 Jul 2019 00:08:09 +0200 Message-ID: <4424857.lkIZ7qNV9V@xps> In-Reply-To: <1562755934-13358-1-git-send-email-hkalra@marvell.com> References: <3AEA2BF9852C6F48A459DA490692831F2A4881E7@irsmsx110.ger.corp.intel.com> <1562755934-13358-1-git-send-email-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/2] metrics: new API to deinitialise metrics library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/07/2019 12:52, Harman Kalra: > Once the library usage is over, it must be deinitialized which > will free the shared memory reserved during initialization. > > Observed an issue while running 'metrics_autotest' continuously > without quiting. For the first run 'metrics_autotest' passes > all test cases but second run onwards first test case fails > because metrics library is already initialized during first run. > > Cc: stable@dpdk.org > > Signed-off-by: Harman Kalra > --- > v2: > * Adding stable@dpdk.org into cc as this patch falls between bug fix > and new feature. > v3: > * Fixed check-git-log.sh and make doc-guides-html issues. Why don't you take our comments into account? Reminder 1: " I was waiting for an ack on this patch, and realized that there was one already on v1. When sending v2, you should have reported the Ack. " Reminder 2: " Tested-by : Reshma Pattan Reviewed-by: Reshma Pattan Acked-by: Reshma Pattan Please keep these tags for next versions. " Reminder 3: " I would vote for not backporting this new API. " In case it is not clear, this comment means you should not Cc stable@dpdk.org