From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id B4A182C65
 for <dev@dpdk.org>; Tue, 19 Apr 2016 14:35:16 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id e201so12106860wme.0
 for <dev@dpdk.org>; Tue, 19 Apr 2016 05:35:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=8mZrApQepEplaTv27fUboZ30yeWI/v2cWHZLp5tsSBw=;
 b=t7jarR5fkHpBoh4J8HY0mfkQme3lf2ETMrs3HQSS+ZrDE0epumSyJbh6zXHynWRf/J
 OPqljKPNsCMS4zf2nSE7pfOaDTqm0UmSd1qT0YZj4vuTJmMXYwK5BgPOIG9DNoE7tu6L
 t7gvQsBmwMBRO0E59cydebxydiky2sFtCEZV7MqbQfc8zfEGvokNn/y7huT5hf0arXtz
 NW73Q0g8zqSjAEVJCHYtcNTgYcCmHia5zq9AidN8elCvLJ7JKZLJYwRLVLcpVuQW7QhP
 bLUzUNAiNieHud0Uo8li2JDK/6OQZD3GokIRMXJ6nb+GsYvAgcuHOwDXeK/uB3fjugFh
 Sc/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding;
 bh=8mZrApQepEplaTv27fUboZ30yeWI/v2cWHZLp5tsSBw=;
 b=ix4oEWTYYVKAWN760vEMAWNI3Z5Sg7IQUFYOswG1sokwrLKctc3qz5hoQnN0De0KuF
 5+yo3r908mejx8OFf4mGfQvfLxYBcN3qGQjpsL2JMgl6inxaM6IYPGHRwx2eDOX/4K3x
 5t1wMvrg7GnUWsYuhyrVkG2LT4ZJC/IrbV6OAtx9296un+F1ttqSXtt3n4G1VpupIWyN
 OcMGztMD85dJD+M/fX1nSrpso1YV+PUW/urupJjZWepdzuQVTrXxFcycbFgOuCAqPiyg
 b0ghe8arzJtkBj2IQK21POM9gakqqWI2Y+uf32ma2p5w/umTyuJCL5hIo2yXuFiD1aw9
 EUzw==
X-Gm-Message-State: AOPr4FVkCZLkYO2htWlOWFEfkyhhOtrh9lXaiXtgJKBdgGodYAPKf/MMOqlJqBOp+5D0wKQx
X-Received: by 10.194.69.106 with SMTP id d10mr2992494wju.165.1461069316469;
 Tue, 19 Apr 2016 05:35:16 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by smtp.gmail.com with ESMTPSA id a73sm4163226wme.4.2016.04.19.05.35.15
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 19 Apr 2016 05:35:15 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Rasesh Mody <rasesh.mody@qlogic.com>
Cc: bruce.richardson@intel.com, dev@dpdk.org, stephen@networkplumber.org,
 ameen.rahman@qlogic.com, harish.patil@qlogic.com, sony.chacko@qlogic.com
Date: Tue, 19 Apr 2016 14:35:13 +0200
Message-ID: <44291434.0HKUfuGdmz@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
 <1459476927-21387-6-git-send-email-rasesh.mody@qlogic.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 05/10] qede: Add core driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2016 12:35:16 -0000

2016-03-31 19:15, Rasesh Mody:
> +#
> +# CFLAGS
> +#
> +CFLAGS_ECORE_DRIVER = -Wno-unused-parameter
> +CFLAGS_ECORE_DRIVER += -Wno-unused-value
> +CFLAGS_ECORE_DRIVER += -Wno-sign-compare
> +CFLAGS_ECORE_DRIVER += -Wno-missing-prototypes
> +CFLAGS_ECORE_DRIVER += -Wno-cast-qual
> +CFLAGS_ECORE_DRIVER += -Wno-unused-function
> +CFLAGS_ECORE_DRIVER += -Wno-unused-variable
> +CFLAGS_ECORE_DRIVER += -Wno-strict-aliasing
> +CFLAGS_ECORE_DRIVER += -Wno-missing-prototypes
> +CFLAGS_ECORE_DRIVER += -Wno-format-nonliteral
> +ifeq ($(OS_TYPE),Linux)
> +CFLAGS_ECORE_DRIVER += -Wno-shift-negative-value
> +endif
> +
> +ifneq (,$(filter gcc gcc48,$(CC)))
> +CFLAGS_ECORE_DRIVER += -Wno-unused-but-set-variable
> +CFLAGS_ECORE_DRIVER += -Wno-missing-declarations
> +CFLAGS_ECORE_DRIVER += -Wno-maybe-uninitialized
> +CFLAGS_ECORE_DRIVER += -Wno-strict-prototypes
> +else ifeq ($(CC), clang)
> +CFLAGS_ECORE_DRIVER += -Wno-format-extra-args
> +CFLAGS_ECORE_DRIVER += -Wno-visibility
> +CFLAGS_ECORE_DRIVER += -Wno-empty-body
> +CFLAGS_ECORE_DRIVER += -Wno-invalid-source-encoding
> +CFLAGS_ECORE_DRIVER += -Wno-sometimes-uninitialized
> +CFLAGS_ECORE_DRIVER += -Wno-pointer-bool-conversion
> +else
> +#icc flags
> +endif
> +
> +#
> +# Add extra flags for base ecore driver files
> +# to disable warnings in them
> +#
> +#
> +ECORE_DRIVER_OBJS=$(patsubst %.c,%.o,$(notdir $(wildcard $(SRCDIR)/base/*.c)))
> +$(foreach obj, $(ECORE_DRIVER_OBJS), $(eval CFLAGS+=$(CFLAGS_ECORE_DRIVER)))

CFLAGS_ECORE_DRIVER options apply only to base driver.
So why not name it CFLAGS_BASE_DRIVER?

This part of the Makefile should be in the patch importing the base driver.