From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76ECA43B08; Sun, 18 Feb 2024 19:11:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 210AE40262; Sun, 18 Feb 2024 19:11:08 +0100 (CET) Received: from wfout6-smtp.messagingengine.com (wfout6-smtp.messagingengine.com [64.147.123.149]) by mails.dpdk.org (Postfix) with ESMTP id 9BB8E4021D for ; Sun, 18 Feb 2024 19:11:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.west.internal (Postfix) with ESMTP id BA7981C00054; Sun, 18 Feb 2024 13:11:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 18 Feb 2024 13:11:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708279864; x=1708366264; bh=Lg3l+8Bv/UlucXl3tPAv7YHhcq3xZ7c24qmEQi6u3Z0=; b= q1yUHZXdP07zKL9UiYYd4MN0v0nJi5nE+8U2bROtO/pDbOozHC10GQIn1Fdun7h1 WLIKj8qSJpNk76X+o2CI4wkrdT6JHRRDWrvNMbJPzTdXNM1xJplahNtfk1v+B20N YyUDn1f+nzn6kX27ftEO7lemUWVH6+pup/QGS/HLlFiCY3ttvrMLOON0kyce49D8 hkuuwGi5U+hTOf7GfI+cwsT7jxk2Suqzt11rux4Mo0pzjd+vj8fGAu3M1P4m4IRz 3tWWxqK3EAg4iyJZyrxXpDNZAZ8ZGT6KOFK5mL+U+oN1xOXECEdBub4C9FtD5pRM oyYD/KkDwOVUcI6X1TJ8hA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708279864; x= 1708366264; bh=Lg3l+8Bv/UlucXl3tPAv7YHhcq3xZ7c24qmEQi6u3Z0=; b=d UjuFBa9cQIdSmCMqUPZHbJTCDwaIAJOnwfjw1EiH3q5KJ/SWfI1Ce+0E8K/H4qd/ iVBaMcSoI3ZnOkEjzOoH1Oah1rRoNIh3ooFfDXYvr2humu7N9RDXHx3QfwI5BWIy H12Yqhd6SHU4MqDl0GKsa4Vap96A0P1C/0Ir81q2SbUJkqth6CZXuWkxu7rmR8lr i2uzBWZugy1OPH3V1I+GFAZBiGU0C5MOdqe3Ctw29kaFYaYr2E6ucQ4HrjM+qekY HyhGw51QXXdD49b5x2UmfX4FhxFzoQi4dlueOlI+6iAphobDWfQAOLQejSw1N7Qx cnULB8JXKKMBIrk+SMlLg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeigdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Feb 2024 13:11:02 -0500 (EST) From: Thomas Monjalon To: Jie Hai Cc: honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru, dev@dpdk.org, david.marchand@redhat.com, Ruifeng.Wang@arm.com, mb@smartsharesystems.com, lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com Subject: Re: [RESEND v7 1/3] ring: fix unmatched type definition and usage Date: Sun, 18 Feb 2024 19:11:01 +0100 Message-ID: <4429509.yaVYbkx8dN@thomas> In-Reply-To: <20231109102046.1277893-2-haijie1@huawei.com> References: <20230117091049.20194-1-haijie1@huawei.com> <20231109102046.1277893-1-haijie1@huawei.com> <20231109102046.1277893-2-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/11/2023 11:20, Jie Hai: > Field 'flags' of struct rte_ring is defined as int type. However, > it is used as unsigned int. To ensure consistency, change the > type of flags to unsigned int. Since these two types has the > same byte size, this change is not an ABI change. >=20 > Fixes: af75078fece3 ("first public release") >=20 > Signed-off-by: Jie Hai > Acked-by: Konstantin Ananyev > Acked-by: Chengwen Feng > Acked-by: Morten Br=F8rup > --- > lib/ring/rte_ring_core.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h > index b7708730658a..14dac6495d83 100644 > --- a/lib/ring/rte_ring_core.h > +++ b/lib/ring/rte_ring_core.h > @@ -119,7 +119,7 @@ struct rte_ring_hts_headtail { > struct rte_ring { > char name[RTE_RING_NAMESIZE] __rte_cache_aligned; > /**< Name of the ring. */ > - int flags; /**< Flags supplied at creation. */ > + uint32_t flags; /**< Flags supplied at creation. */ This triggers a warning in our ABI checker: in pointed to type 'struct rte_ring' at rte_ring_core.h:119:1: type size hasn't changed 1 data member change: type of 'int flags' changed: entity changed from 'int' to compatible type 'typedef uint32_t'= at stdint-uintn.h:26:1 type name changed from 'int' to 'unsigned int' type size hasn't changed I guess we were supposed to merge this in 23.11, sorry about this. How can we proceed?