From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6FEB47D4E
for <dev@dpdk.org>; Thu, 21 Sep 2017 14:41:48 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 18D0421002;
Thu, 21 Sep 2017 08:41:48 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
by compute1.internal (MEProxy); Thu, 21 Sep 2017 08:41:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=vPBnM/hW3MXSyMc
EkDlwEBgaCaYxhsVdt+mNcXelF/o=; b=cdYnLWWTPu46WFu2bW2gBLEpy7Rz1PZ
pE1u5R5U65a/RtZWgwgt+3kb6TL8y61/M/AGKP7xP3bc9eVetboNV5Dg48aOXcPf
8v0Kz51sztk+xf1XrWc3y3TJb/iPXeFuN9QZmLV86e2LlntmARfeerX/fCC7ISJT
Js0mz1CneVRs=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=vPBnM/hW3MXSyMcEkDlwEBgaCaYxhsVdt+mNcXelF/o=; b=J0M6fUiM
uEOIEvy76JK13C0lVFrZm3Jby1GyX2xp6qb+xmHCFECw/BbTqDAdeJ5MXn6Ap2X7
5nnuWLmNouSWg02NXwSMUJm96TQrcpkZ68TfmOq3ioHZH0qwZcmPXuG9NVkuG3K9
/chDhC/vViuGyyHDIXsCXPQE7iG8bUsFtLu7ok2ijOblKDMsmCn7ljHbyfXZqa9I
q837DUmYQ1Vd3TbG6hPFFlx0hEyU7Uhv+70LteqQUOra53Ir4S8aEVAH+d62cu7Q
Qfofu267vz3GxLbMBsjkvE2Fw6slQKwugKDK8SWKxVwt/4dIxXmQ07hpxHjpE4ZS
yNMlZhS5XTYicQ==
X-ME-Sender: <xms:jLPDWSNfw7wzZ2c77j6WwcpoU9vRSXhIrOLGF3xLPZRGyv7bNbqIvg>
X-Sasl-enc: 65TsfZY7dzxl6gxGZ7xS/QGGknElBevhyRXe5Wyj+DLl 1505997707
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id B39FD7E187;
Thu, 21 Sep 2017 08:41:47 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Yang, Yi Y" <yi.y.yang@intel.com>
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
nelio.laranjeiro@6wind.com
Date: Thu, 21 Sep 2017 14:41:46 +0200
Message-ID: <4430088.xROSz6HfYO@xps>
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FA8738@IRSMSX101.ger.corp.intel.com>
References: <1505958643-21203-1-git-send-email-yi.y.yang@intel.com>
<E923DB57A917B54B9182A2E928D00FA650FA8738@IRSMSX101.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2] service: fix build error "ids
uninitialized in rte_service_map_lcore_set"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Sep 2017 12:41:48 -0000
21/09/2017 13:55, Van Haaren, Harry:
> > From: Yang, Yi Y
> > Sent: Thursday, September 21, 2017 2:51 AM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Yang, Yi Y
> > <yi.y.yang@intel.com>
> > Subject: [PATCH v2] service: fix build error "ids uninitialized in
> > rte_service_map_lcore_set"
> >=20
> > v1->v2
> > - Change title to more descriptive one
> > - Add issue reproduce information to git log body
> >=20
> > On current master tree, normal DPDK make will result in
> > the below error:
> >=20
> > error: =E2=80=98ids[0]=E2=80=99 may be used uninitialized in this
> > function [-Werror=3Dmaybe-uninitialized]
> > ret =3D rte_service_map_lcore_set(i, ids[lcore_iter], 1);
> >=20
> > It can be reproduced very easily on Fedora 21 with
> > gcc-4.9.2-6.fc21.x86_64.
=46ixes: 21698354c832 ("service: introduce service cores concept")
Cc: stable@dpdk.org
> > It is fixed after applied this patch.
> >=20
> > Signed-off-by: Yi Yang <yi.y.yang@intel.com>
>=20
> +CC Thomas, please pull this asap, as it causes build issues on various G=
CC/OS versions.
Most of compilers do not raise an error.
It seems specific to gcc 4.9.
Nelio reported the same error with gcc 4.9.
Changing the title to "service: fix build with gcc 4.9"
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks