Re: [dpdk-dev] [PATCH v4 0/4] bonding corrections and additions

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Declan, Neil,

Please help to review this series.

2015-05-26 08:41, Eric Kinzie:
> This patchset makes a couple of small corrections to the bonding driver
> and introduces the ability to use an external state machine for mode
> 4 operation.
> 
> Changes in v2:
>   . eliminate external_sm field in 802.3ad configuration 
>     (rte_eth_bond_8023ad_conf).
>   . stop bonding device before changing the periodic callback function.
>     start again if needed.
>   . remove unnecessary calls to valid_bonded_port_id().
>   . do not check for NULL tx_ring.
>   . return error in rte_eth_bond_8023ad_ext_slowtx() if packet is not LACP.
>   . remove check for external sm configuration in periodic callback
>   . check for valid LACPDU in test application's rx callback
>   . add "Fixes:" tags
> 
> Changes in v3:
>   . update rte_eth_bond_version.map
> 
> Changes in v4:
>   . version functions that modify slowrx_cb
> 
> Eric Kinzie (4):
>   bond mode 4: copy entire config structure
>   bond mode 4: do not ignore multicast
>   bond mode 4: allow external state machine
>   bond mode 4: tests for external state machine
> 
>  app/test/test_link_bonding_mode4.c                |  217 ++++++++++++++++++-
>  drivers/net/bonding/Makefile                      |    2 +-
>  drivers/net/bonding/rte_eth_bond_8023ad.c         |  241 ++++++++++++++++++++-
>  drivers/net/bonding/rte_eth_bond_8023ad.h         |   44 ++++
>  drivers/net/bonding/rte_eth_bond_8023ad_private.h |   28 +++
>  drivers/net/bonding/rte_eth_bond_pmd.c            |    1 +
>  drivers/net/bonding/rte_eth_bond_version.map      |    7 +
>  7 files changed, 524 insertions(+), 16 deletions(-)
> 
>