From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 6465AC448 for ; Mon, 29 Jun 2015 00:03:47 +0200 (CEST) Received: by wgqq4 with SMTP id q4so126734055wgq.1 for ; Sun, 28 Jun 2015 15:03:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LfbGZjZQxplX6VViDWKThogol/2SLldOSRd+B9Whj40=; b=T9puvI9P/wI1BaXMq8PqaiDUHETHA1aeYejaGkD4RJIaoBdxMDSA9APNMz+q3DSRjl hW+oMMgCgI39yBMT4fIcfzNmFufk3GL3BeUFERKKGU0+6v/cjiOu7k3mnPivvlq0brP4 fcnr/0a32xrvMktITs9jzijcblLD5UaUaJGs1E5fuHrDoW3JKcbudodVP+xo4L++4FR4 +O17Vco9sdOdxi1SbNuuTYSmuTPCS16C9Ek0JR5u5haNW+kcE0fcYhT18/nm4PAff1od IlfqQ/T73pxWKcm871gIR4v1rRoW/s3cd4vcED9YOFxXU0+XGXJeIqGFa+Dl77DaR0eX BVVw== X-Gm-Message-State: ALoCoQmDliPZQw9zRYyrmxE7rpaNTFVqQKGIub2ib+55ju04pfyBw7J5m3oUSvP+Ei5EAhvksGC9 X-Received: by 10.194.95.132 with SMTP id dk4mr24862975wjb.88.1435529027240; Sun, 28 Jun 2015 15:03:47 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id dz4sm9168694wib.17.2015.06.28.15.03.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 Jun 2015 15:03:46 -0700 (PDT) From: Thomas Monjalon To: nhorman@tuxdriver.com, declan.doherty@intel.com Date: Mon, 29 Jun 2015 00:02:38 +0200 Message-ID: <4434114.84Vb6lbvqE@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1432654909-13845-1-git-send-email-ehkinzie@gmail.com> References: <1432654909-13845-1-git-send-email-ehkinzie@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/4] bonding corrections and additions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2015 22:03:47 -0000 Declan, Neil, Please help to review this series. 2015-05-26 08:41, Eric Kinzie: > This patchset makes a couple of small corrections to the bonding driver > and introduces the ability to use an external state machine for mode > 4 operation. > > Changes in v2: > . eliminate external_sm field in 802.3ad configuration > (rte_eth_bond_8023ad_conf). > . stop bonding device before changing the periodic callback function. > start again if needed. > . remove unnecessary calls to valid_bonded_port_id(). > . do not check for NULL tx_ring. > . return error in rte_eth_bond_8023ad_ext_slowtx() if packet is not LACP. > . remove check for external sm configuration in periodic callback > . check for valid LACPDU in test application's rx callback > . add "Fixes:" tags > > Changes in v3: > . update rte_eth_bond_version.map > > Changes in v4: > . version functions that modify slowrx_cb > > Eric Kinzie (4): > bond mode 4: copy entire config structure > bond mode 4: do not ignore multicast > bond mode 4: allow external state machine > bond mode 4: tests for external state machine > > app/test/test_link_bonding_mode4.c | 217 ++++++++++++++++++- > drivers/net/bonding/Makefile | 2 +- > drivers/net/bonding/rte_eth_bond_8023ad.c | 241 ++++++++++++++++++++- > drivers/net/bonding/rte_eth_bond_8023ad.h | 44 ++++ > drivers/net/bonding/rte_eth_bond_8023ad_private.h | 28 +++ > drivers/net/bonding/rte_eth_bond_pmd.c | 1 + > drivers/net/bonding/rte_eth_bond_version.map | 7 + > 7 files changed, 524 insertions(+), 16 deletions(-) > >