From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86BEFA0C46; Mon, 27 Sep 2021 20:29:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EA64410DC; Mon, 27 Sep 2021 20:29:55 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id AA62240E3C; Mon, 27 Sep 2021 20:29:52 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10120"; a="310087091" X-IronPort-AV: E=Sophos;i="5.85,327,1624345200"; d="scan'208,217";a="310087091" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2021 11:29:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,327,1624345200"; d="scan'208,217";a="707260380" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga005.fm.intel.com with ESMTP; 27 Sep 2021 11:29:51 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 11:29:50 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 27 Sep 2021 11:29:50 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 27 Sep 2021 11:29:50 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 27 Sep 2021 11:29:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UmPNPl+14Itt8OmrnoSZvywJIlo3VL/A5spLrYhbF5eC/tok9sSdLzhzloxBL7wd9BboE0LlvrkpDKy+bPW76meiKAYZWCCBjT4KjFs4rVChhzmDmJp2EFqcA+bzEtayzOy3LCQTDUIdPBheQWOcUWl0nvb24e0b+zZN8i2kOvptA2Uzjxucj/xV+/2CtUbr0AGRvO2tRondscyac7/fAl6vayWjcd8bPsiDypt5U3FGmcAkEc+ZkyT1ZiX24R/qdBsj+qqRMGU4SGkC5i5D9Uwq39b+cRjxUe3bGDg3S+Es1i8hCYTXh8BjS9d+bwqCA6xnQpbhKvIqVqxTVJduBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jKJu9qkpLWTJqlHAB73jgvZPuRcHeqOUoNVUbFSqGH8=; b=Jr9Vhvo0iyu+DQPYwsEjFqD+eL1Kx9IcCT8SJTNaF8zwsKLc9RXfw+poiCSYiu/+Ah2m9AHkdDs6AAxSmCuG3qt3LL4JWpGidFeAc42gc9tf0j/pu3zEIbscKRtfU/7p2TL3Wg+iERHPLjmfBskWztApB7ma6WCIadgdqSecAcf+Padj/x4m4dtg5ZvO8hvYzesTSXITPKyZFlma0X10aBk09aICkU3rdjEy2srsa5h02ZXBGCkWOp+67T1xcoSJ0tKMUrH06SDhHkgb8BDlgZMe0EUkptTqxbblLFGzA0azMsHL1dPwsSaCnQ9ESMqjAf7cfgxW8rVkc8bowRaIhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jKJu9qkpLWTJqlHAB73jgvZPuRcHeqOUoNVUbFSqGH8=; b=W4UO4HVscR/JB7fs8aVyESjzt/bkWvkEGRnW+KwAoCbr5EG/7t4T1+EH/tFxF8QHquEu5vqaLUZOXbeACBZRKae1xVjg8aMnFCg1PtcQ1Gg4mSKv1FgNwGsytfgrlYN2wbJovxvDe7KdBV6apnQzMdkzJBdWQOPs7X9jfEcQ4eo= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) by SA0PR11MB4526.namprd11.prod.outlook.com (2603:10b6:806:96::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Mon, 27 Sep 2021 18:29:48 +0000 Received: from SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e]) by SA2PR11MB5210.namprd11.prod.outlook.com ([fe80::e5f6:85a1:af0d:705e%6]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 18:29:48 +0000 To: Pallavi Kadam , CC: , , , , , References: <20210927184322.1455-1-pallavi.kadam@intel.com> From: "Menon, Ranjit" Message-ID: <443fbd7d-6f00-c0cd-df84-781ad47b89ca@intel.com> Date: Mon, 27 Sep 2021 11:29:44 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: <20210927184322.1455-1-pallavi.kadam@intel.com> Content-Language: en-US X-ClientProxiedBy: MW4P221CA0027.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::32) To SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23) MIME-Version: 1.0 Received: from [192.168.254.28] (50.39.109.205) by MW4P221CA0027.NAMP221.PROD.OUTLOOK.COM (2603:10b6:303:8b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Mon, 27 Sep 2021 18:29:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94c707f4-17bc-49d6-b7ee-08d981e4c989 X-MS-TrafficTypeDiagnostic: SA0PR11MB4526: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:247; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vQTKcbEnD9DmIID0MmwMS9Z50clAOG/BNP9ootZ4A9GarzCpB3FN2RpVHP8ZfDFXAVmDaMwmOKhyVj7Kav0VG+cr8XpIaYKDgwk+mY4gGIM+cCPeWw8i4vgX03Pkwz1/fKRUqhXvR/2bEnYwhR7BnJ4KdUNKeLWcIv5Gdtq/pE1BzHDTkgWgrV/amnpawGZu0rMnpTeIkrROtWxb9KOwp6FIc/V2IfQ2Gy/8517Ibm4Qr6Y3Uy02bark8hmRnWmT0PyWxSyKj72ncrqjsNT1lF6WPAcFd0jVKRqIlICLcS8wUvZFcHdBJkcjgsd6qdzkk2qhGJfe9335f0NhWeIyS1xH8vjslV3VDLm5rvEF2RA/ysm/cMjG1u2L5Vmtq1guipsZ9AePkc82l07POJAbOvnGyOI18msoHXaYjo1XD6FYVDB6ntAUyYMBeeW+XAxYrKTHhzk/sTEX9cBrKzZP/JnQ0ZQ7tHeQVFI7mID4fz00V8mI4A/dIRlGwBxeJoAylZ4LsalHFLNbkIP/+tE/9FkCwyAjkiFkYCrDRNoYkiyqgdCMgVNyjH0sFRKgql94m1Cnc+MiAPsh+dy+QqL75Dra+fgV4hxTE0hA9oK1fZopSNX6YHRXJfoOio4DMa376vnAHgvKE29ZN+h/Zg5NLN/OLBor83/reWHoZLmNwnB2Z3UX1is4NzjZtYir9l/FYhpmaXCtXFouC7lLMjpWqR7sfaiY8AJIS9Lm3DhZcvU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(31696002)(508600001)(53546011)(4326008)(36756003)(31686004)(16576012)(66556008)(956004)(86362001)(2616005)(2906002)(66946007)(66476007)(38100700002)(316002)(8936002)(5660300002)(107886003)(33964004)(83380400001)(8676002)(6666004)(6486002)(186003)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDhYT1FvcWRqRlJRVFZRQkI5VW1kYVYyNWlKRDVoYm5rNWhjT2Nhdzh2eG5R?= =?utf-8?B?N1dpWElqSnhCVzZzQ3JmS0NpMGtQRjVQYUVmaGM5NWt1V3pZT096dmJvK0ZP?= =?utf-8?B?RFRLTmlNNDE3WUg1MFJSbzg1WFMxVEFrZHE4eW5HUEtUR0hhakIxTzdGWXVZ?= =?utf-8?B?UUdrN1N2RDhkM296Z1gyQm4rRGtLL2dLZjdXVE1tODhGL296RGZqeVBZbEx2?= =?utf-8?B?OTBPMXdmSWlQWTc0WDhWRHNCZlBxcEp1bytZRlo0WHhrK1lzbEZ3WktIUTdF?= =?utf-8?B?THRXd3V6Y3BIZ2F3Y1V4V0R6c2pDVWViVDBPMU10TmE4Q2c0elJzMVpoYkRa?= =?utf-8?B?Zm1ieVpFK2xZYXdiMkNoU2tMakRRVGJMRWtWSHNoRGdWdXcxZzJBcUlISkpr?= =?utf-8?B?ejhYNk03YmFEcERNM1BTT3Q3dlRwY0NVV0gzYVdWMVNxem9qOWh1SU0wcks1?= =?utf-8?B?K2Y3QjJaTDRJMDN3ZFJraGwvUTlGYzc2YTlqcGJKRGsxNE1qMnhYeDVGdlhs?= =?utf-8?B?ZkJXSHpVaVNReHFrUElqRi9DTGZGeDE4T094RnBtV0M5ekdYVXUvQ1F0eHIz?= =?utf-8?B?aHc2T2VzMVNMVm1JTHNzaVpNYUpPVEdiVEU2VW04OEJCVHlZZkxadm9QR21n?= =?utf-8?B?NDU1ZmJHakNWS0s5M2Juejl1aG8vZUE0WWt6SWxUOFNhSDNCS1lrNmJXc1V2?= =?utf-8?B?Y0xXSE1qbTJhKy96UThFdFpndlNoT0krc2lVR2hhclY4TEJNeWRvV0t4OXJP?= =?utf-8?B?b0Yvd0lSa3VPVXdoOEhsNnNNaCs1cEZKVm1hMk9yQS8wU2RVSHhWVk9wRXZD?= =?utf-8?B?YmVvSk5ZVUc2WmNQdkozMEFPQUlSWENNQ0diYWNHdEhKRmR3QWdNZU9VN1hX?= =?utf-8?B?bjloaVVtZEJYVUViUVNJMDdJUmt3eDVoZmptTXBPL1Jnc3hQclZFTXF4Uk0x?= =?utf-8?B?UTRzdDlBZnd0bnZjOUxJWHRwaTFPcFdkMGJCMS9HMDEzUWRXeUhNTHlmYmdV?= =?utf-8?B?VHlBVk9weW1yRnNoQnVhWWxIUVFvSHBoWTRISVhkQ0xhaUR1eEx6WGRlVWY1?= =?utf-8?B?UlhJbjY4OStJNUQzMkQ1ZFE1YmJrc2Q2NlpJajNoTVQ1OVZVS1dFdTRRMW40?= =?utf-8?B?V2tiZ052ZmlheEdQbWZGOUQycnFudlJNRm4zUXZUR3BuRlZzUlR0WW9hbWIx?= =?utf-8?B?VHJOWGVQZDZLQ2Y1YnlNd0wxVzhOQnJCUEY4U3ZjV2dLd3ZvREdyT1J2R09O?= =?utf-8?B?WDg0Z2s3bUNpUENCM0JCMHg5TVNyejkyS1l2akQ1alpQemNUYXpGeGZGbTdW?= =?utf-8?B?WGtwakNMRk5aYVNVek5jcW5CcGNEclZjakR4WEVQbDN0SWpyV2F5eDBlcUdJ?= =?utf-8?B?REhYVzdPZngyU2JNV3dBNW05N1hiR0lKVXBZRzQyYlMySzRqTFZobFVWZEFx?= =?utf-8?B?ajJxdmpjQWVsQkp5N1FBWWtocDJtd3FoY3owSGdVRVExaGdxSlFHeldXV1h3?= =?utf-8?B?TWhNRHc3RG9ZUThLdlU0R2xlMjRvdWRvcEFNeDNTQzZwczZDcWNZb0Uydm5Y?= =?utf-8?B?UjZxdFhGZFMxTGxPZ2U5cDBGbnhpNWhvUFFMT1FMTlJVQSs0REVrK1lTbDRB?= =?utf-8?B?TlM3akJncjloRUpaNTBMNlF5Y05rZCtWendPbGlGT0s3SDdrRUtqOEdqQk5u?= =?utf-8?B?OXhNQWI3VStoZEpubFdIbHd1K3hxYm9FZGYwYm9Hdm1MK2JUUEQ3Tk9HZXox?= =?utf-8?Q?DdbyDjmoUkuMMPo+r0VxuKPUYq9Ij65w0PfgTK7?= X-MS-Exchange-CrossTenant-Network-Message-Id: 94c707f4-17bc-49d6-b7ee-08d981e4c989 X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 18:29:48.5230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: myiv4Nbvhv66p3MJsFe/R1z70NmRRYQjBXgbuXAnuAJgEtezNBD1Q8lo3zo1zY1ToOmSyjwHbY7PRT5G1Km5ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4526 X-OriginatorOrg: intel.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix unknown NUMA node value on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/27/2021 11:43 AM, Pallavi Kadam wrote: > Based on the rte_eth_dev_socket_id() documentation, > set the default numa_node to -1. When the API is unsuccessful, > set numa_node to 0. > This change more correctly resembles the Linux code. > > Fixes: bf7cf1f947bd ("bus/pci: fix unknown NUMA node value on Windows") > Cc: stable@dpdk.org > > Reported-by: Vipin Varghese > Signed-off-by: Pallavi Kadam > --- > drivers/bus/pci/windows/pci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c > index 343ef6f33b..644c452c76 100644 > --- a/drivers/bus/pci/windows/pci.c > +++ b/drivers/bus/pci/windows/pci.c > @@ -237,6 +237,7 @@ get_device_resource_info(HDEVINFO dev_info, > } > > /* Get NUMA node using DEVPKEY_Device_Numa_Node */ > + dev->device.numa_node = SOCKET_ID_ANY; > res = SetupDiGetDevicePropertyW(dev_info, dev_info_data, > &DEVPKEY_Device_Numa_Node, &property_type, > (BYTE *)&numa_node, sizeof(numa_node), NULL, 0); > @@ -244,7 +245,7 @@ get_device_resource_info(HDEVINFO dev_info, > DWORD error = GetLastError(); > if (error == ERROR_NOT_FOUND) { > /* On older CPUs, NUMA is not bound to PCIe locality. */ > - dev->device.numa_node = SOCKET_ID_ANY; > + dev->device.numa_node = 0; > return ERROR_SUCCESS; > } > RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW" Acked-by: Ranjit Menon >