From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D771541D93; Mon, 27 Feb 2023 22:46:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA6F840A84; Mon, 27 Feb 2023 22:46:27 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2048.outbound.protection.outlook.com [40.107.220.48]) by mails.dpdk.org (Postfix) with ESMTP id B825D40A7D for ; Mon, 27 Feb 2023 22:46:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cLjM/1AaAqxSDzjZC0VCgOV5KZmAUmNlhrHP65Ah12m7pxKzjLOaZHMQtqrpzQYxX6cvHhf0mMlK5EsoHXSvmiv+enj0oRa6d8LPTvqganjSGoQW+ZYDkU/2CX2p0AguXHFuzJEMMVdOl01NPkr2p0GlKl7mEuANwwLGyc/hNuRksQz9f1h4nyyhIjbRSl3FPuNademf5zbbTY9+P3LObl1znmGmqv07nSGL7mRxUay3Cg7OYQ4COww/ohT3yZoexJ/GJSy24EglB6VhIyCYxpsckaFnhtpliJZmvq91ifXVBhbDo8YV8P0y72c2J4xjx3K2DR0KixmbXqDHCJ3lFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B1520R37taT0myDPBZr3Asq0CEcX3qmemQhdomv4ffw=; b=PAC/0my5NGI9GY8N8Zxp6JnaMuIkT2FZlgv2WFPTFwCr1hmphXUNBhU9EjkQSlGCXGEm/uRFhtJHzuRqcE4depk6M1OQ9qC3GS3hFMunIz9Jbn+/SbeFXrubg/1FdrcII+FoFb/JmCs4HPvbNSHD/b+Lbmb1A4kZ3R2nT5OBCAI8Bk4/IO/XEh1s1YY2+pc6rl06ofjQA8Hz/4PY2aDcmhMFltN3/MS3+cfqOP1I3tzS0OX43JjniMfLgWpEqCQxfgJSwS1y53R8n0b+sU9xz3QXQW3kK+u30m7SP+O/ANOUEyfgfSfFze7eghD7PFzgg5iXbuml979KKejQ91Lzzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B1520R37taT0myDPBZr3Asq0CEcX3qmemQhdomv4ffw=; b=ZOkInK4qsdPTAo6c+qjBL7Qp9AwL4j66QkBpcV4UBpnGvaCsxegs76GjcLZXP2PL80eUHCL40EnvBX1UO6nq89q5R0gdSAK3ZnK+9grBcty0v3PW2dU77EhU9p7/1/z4CLpvaDvURJEFtVgSNCcfaGNeevXFyR7RqP5Kf/BdArw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7280.namprd12.prod.outlook.com (2603:10b6:510:220::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.25; Mon, 27 Feb 2023 21:46:23 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6134.029; Mon, 27 Feb 2023 21:46:22 +0000 Message-ID: <44469963-92a1-82d0-ff77-8ff176cb81e3@amd.com> Date: Mon, 27 Feb 2023 21:46:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Mingxia Liu , dev@dpdk.org, beilei.xing@intel.com, yuying.zhang@intel.com References: <20230213021956.2953088-1-mingxia.liu@intel.com> <20230216003010.3439881-1-mingxia.liu@intel.com> <20230216003010.3439881-4-mingxia.liu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v7 03/21] net/cpfl: add Rx queue setup In-Reply-To: <20230216003010.3439881-4-mingxia.liu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0441.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7280:EE_ X-MS-Office365-Filtering-Correlation-Id: 4a6fac61-0222-49d5-20d3-08db190c1162 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ljPHuMgFYrrKwkLdB+3x9Y5kEIh8d3/SffKPrkEsk2C9vFcuuD0VObmggZ7uwmmoU7j8vUGqy61LGkJb84jLmi7jI5Vd2OhQRYVt5s07IwTASTlJE4j/xRbpuTbdjsbYqSgXGMhmonXsFMCcsgli3Aeuf+eg4GrfAWkFia4jAJKUCRqM4EXhSwp/4OQ3f+Xqu0Xg4koP92QrtaRhI4G0978Z4uOWtrGqCp8RRVtLFNIB5JswY/RiGZWtXUd0+zwUIxIGnS7JrK5RC8NPLDpPr7Ij4AZWnTv3xQYGcXypyTAdzB7ctB5IvvsegO5KrGSOLB18TrADMe6KZLPBB6W7GRbciQAk9iPy0qj6app2dS7IyolUd/KngTPwkO+ekLMLoTmF1Mr4YjNtlaHI3dfyMSve/WFflPu2HCVJUmukg50rrthjfBxg/xSNkybjrlE/lLA2zgBpAOUCu2Rsjux+AKUdk8LtoIZs7Sc1Lf+8cI/AIeU8qG4wGtlTFGVA4U/4ELsLxGRyG2R5cyKhM2RF1XSodAznz/ixw7eEibcPeiyYofpNHAUc8JpigJ5WaAqzba6Xu5uF7HL1HEjdMl0R6CH4I7GuW7yDwm0nU8wtJF0lgEeJYegl8nlGT8yO+9QP4q87LGTpfp2TibgUDeAYKx/mprfVDe7FwFkxDp94cBVQzS1dN1vhZzf05txKF2KCXQhWcF8wn3JQ3PugkNUh2dkDBg+kW/aZPN65zKbs5zo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(396003)(39860400002)(366004)(346002)(376002)(451199018)(186003)(38100700002)(41300700001)(8936002)(66556008)(66946007)(8676002)(2906002)(4744005)(66476007)(6506007)(6512007)(44832011)(53546011)(2616005)(478600001)(26005)(31686004)(31696002)(5660300002)(36756003)(86362001)(6666004)(316002)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b0VRbVdtbEJVcFFwOG5OaUExKzR6Q0toT002d05yc0k0bCtJY3c4ZXFQVGhU?= =?utf-8?B?TlpremphZnZQMG80aVBITzRSUytQaUZYNmhoekJhK0VNSzR5ckZpREdIeU1N?= =?utf-8?B?OC9xTzJBc3VSRlYzNjVJVSsxam5nd0Q4UEo2QnFJMk16Z0luZDVjd0NZeEdX?= =?utf-8?B?ZE1Od21Tb1B3d0FJb0RteHF6bG56WlZrQldKNHFKa0hDN0tJNXYvOUZoVTdD?= =?utf-8?B?Y2s4WkJTMUlIdVRjYWZrQ3hiNkpYRUlabG12M201bTBLajdKMnUva1J2eTVy?= =?utf-8?B?dWU1Sk5ISmFmbGY0NkpFM2w3enEyRlAyVDV2WVNzNW1RMk96bHRtRkFpUnls?= =?utf-8?B?SzR1VC9lQjgvYTFLazZLRmxqbWU5S1VONnpjYVZvQlhRemh0T3dWZlpoS3Fj?= =?utf-8?B?VFA5S0E4SmNSYVltR2lubXRrUXJDK2h0MkhwTzdZdWNicFJRVGp2SER4a1dT?= =?utf-8?B?MG53Q1FScnNGUDhmMG12d3I0dFBXcTJxczFKOUROOFdxRDFUcm10UkxsQXhZ?= =?utf-8?B?Qzd6eFNFUUx0aE8xci9VRU44RmVYVjVXVUdMM0U2YjAwN0NyQ2QwaVRwMFRV?= =?utf-8?B?anVySHZHdmhaUm5razVaY0ZCa2dHUGNRWmFmQksrTlVZa3h0b1JZK1Z3bHZo?= =?utf-8?B?VHV0dzBWR3hHQ1VEYTlHdk9Nb3BmNzV2eENRVExpUko0OURyMG9FSGN4TUVT?= =?utf-8?B?a3NzckJaYmdCaVFBRVQzV0RmS24wank4Z2UzUm1UT0pQZVFKSGZONUdRaEw2?= =?utf-8?B?d1g2TEdESmw0TmM1Ynk5eUpabHYzWW9PMnJMKzh5Si9Xa0FlNXRYWkljR2pV?= =?utf-8?B?cHhWN3BXOUsxUnhBZjdWQVJSYU5hUW1DYkRtUUYzSnR2Q0I1Rm14M3JRZGVL?= =?utf-8?B?TS8vM3FYSVkxc0Vwc0E0QXR3R1hyNzcwVTYxVFVoVklzdWZsR3NxNmNCcHQ1?= =?utf-8?B?Vk1SL2llTVY4QUljdHNkck5CSWJXQ0grbklDZkRQa3hsVGFlNm1lWUVGQXlD?= =?utf-8?B?SFdSUGFTQ1JWU3MyTzlQNGFnekFQb0xvSytxU0VqS3hGTnVXVjJCSFlMdkpU?= =?utf-8?B?bE90Q0hCbUJtOFVNZWFtdk9tOGMyODBZVGZXZS9wYm5hYVQ1MU4ycXQxWm9v?= =?utf-8?B?b1MraHBBQ2xEalZVOW4rOTlKYUFiZmR6cjNSZCtsNk11VGhBRk1UNGU2R0Jr?= =?utf-8?B?T2VWTzFoRGlsNUtFa2tta3JmeHRZNFhiNlB3UzNJamNaMEJ4SzJhUy9pT1N4?= =?utf-8?B?aytic1ljV1M4OEROR3U1ZHNpdm1qNjBtN2x2V2hGRXVMeVYxVG45ekFnMkx2?= =?utf-8?B?dkw1TDJvU2x0QlRzWFdvM2ZVZkJKN29vQnJHTk9hNWFWKzRHMTQrMFFiWERm?= =?utf-8?B?azhMUFZNWlVRQTlnaEpac3E2U0xaUXR4dk14ejF2ajNGMi9oU3dMVC90cWxI?= =?utf-8?B?QjlkYXFpY05NNnJrZklYT1Vta0Vmcmo3OE11TjdHdDZNdTN4cDlwL3krb2ha?= =?utf-8?B?SUlUTytZbTZPTlVHVVoySTJrSmVYamZhUmZ5VlRUekw4dDNyZnU5b2NzdW1n?= =?utf-8?B?dDBIenBsMS9ISzZlRE5ia1FWNnFKeDc2ZmVURUhEWjBlWHNZOU1tZisvejdO?= =?utf-8?B?OHN5SHhGZnU3THRRQUJLNXQ0eHFYTHNGQ1paZ05Ec1ZaZTJ6MDVNZmVjbVVh?= =?utf-8?B?TG03eUQ1cHBKanBPOWszUHN6K0dkUUFPeGY0ZVRodVVUd3lrQXA0a2FFZnVF?= =?utf-8?B?SUFWMWIwRTdiaU5BSUZrYSsxMGViQm5OWVh4RWJ3ZkZDby9TWHdKcS9sU3JK?= =?utf-8?B?ZnJ2c2ZpeWlicUFkRmhUY3ZsdDVsNXFyK2N5d0swT200Qy9iOVUxbDFhSEhy?= =?utf-8?B?Y001a3NjWmQ5Uy9zdGxUSUY4SXpqMEM0QVNpUnNsV2JEQXNlZlp5bHBmZ3dk?= =?utf-8?B?V2poU043MWQxZnNxNmdrd1NsSzk5b29VcGM1YlZBNTJ5WVVHWjNEZDBSMzNN?= =?utf-8?B?OTBud3N2RUgwRGQzK3k1bXdMMGVqTS9INjVZUEdRMmJ5enFvQXlheHRHS2k4?= =?utf-8?B?OXNWTXRWUnAzVEZNdkFnWkI5cU1FVm1zQlVFeEVlNmdWRm9hUUpLNFlhZ0Y1?= =?utf-8?Q?0s0QHtvV1jEPzlrdEenBEEC74?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a6fac61-0222-49d5-20d3-08db190c1162 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2023 21:46:22.7814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9gj90uzbNMQ578ZyvVC+emnzCYiOp42H9U3Ezd45xStdaUfI5B0vYlUYYO87QlXk X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7280 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2023 12:29 AM, Mingxia Liu wrote: > Add support for rx_queue_setup ops. > > Signed-off-by: Mingxia Liu <...> > + > + if (bufq_id == 1) { > + rxq->bufq1 = bufq; > + } else if (bufq_id == 2) { > + rxq->bufq2 = bufq; For readability better to use enums to diffrentiate queues, instead of using 1 and 2 as paramter to function. Also I wonder if queue variable names can be improved too, from 'bufq1' & 'bufq2' to something more descriptive.