DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: Jerin Jacob <jerinjacobk@gmail.com>,
	David Marchand <david.marchand@redhat.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	ohilyard@iol.unh.edu, "Tu, Lijuan" <lijuan.tu@intel.com>,
	dpdk-dev <dev@dpdk.org>
Subject: Re: [RFC PATCH v1 00/15] merge DTS core files to DPDK
Date: Thu, 07 Apr 2022 09:33:36 +0200	[thread overview]
Message-ID: <44577792.fMDQidcC6G@thomas> (raw)
In-Reply-To: <CALBAE1OygtTbT3RH3ET6W1tRS3OR9N1M8kdnphrnoW65YRAexQ@mail.gmail.com>

07/04/2022 07:04, Jerin Jacob:
> On Wed, Apr 6, 2022 at 8:26 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> >
> > These are the basic libraries that other libraries depend on. There's
> > also the basic framework functionality related to test execution.
> >
> > Juraj Linkeš (15):
> >   dts: merge DTS dep/tclclient.tgz to DPDK
> >   dts: merge DTS dep/tgen.tgz to DPDK
> >   dts: merge DTS dts to DPDK
> >   dts: merge DTS framework/__init__.py to DPDK
> >   dts: merge DTS framework/asan_test.py to DPDK
> >   dts: merge DTS framework/checkCase.py to DPDK
> >   dts: merge DTS framework/dts.py to DPDK
> >   dts: merge DTS framework/exception.py to DPDK
> >   dts: merge DTS framework/logger.py to DPDK
> >   dts: merge DTS framework/packet.py to DPDK
> >   dts: merge DTS framework/project_dpdk.py to DPDK
> >   dts: merge DTS framework/serializer.py to DPDK
> >   dts: merge DTS framework/utils.py to DPDK
> >   dts: merge DTS main.py to DPDK
> >   dts: merge DTS version.py to DPDK
> 
> merge->import
> 
> >
> >  dts/dep/tclclient.tgz         |  Bin 0 -> 199327 bytes
> >  dts/dep/tgen.tgz              |  Bin 0 -> 134392 bytes
> 
> Some top level comments:
> - I think, we should not check in binary files.

+1

> - git commit comment should much more than "dts: merge DTS xxxx to DPDK" where
> the commit log should have details on check in.

+1

> -Add the documentation from the first patch and update the
> documentation per patch
> based on the content.

+1

More comments:

- Please don't send so many patches, it looks like spam.
- Please let's start small with the very minimal code
to run a dummy test.
- Split by file does not make sense

The process is going to be very long.
The techboard said in the past that we must have a very careful review
of an import piece by piece. So please be patient.
Thank you



  reply	other threads:[~2022-04-07  7:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 14:55 Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 01/15] dts: merge DTS dep/tclclient.tgz " Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 02/15] dts: merge DTS dep/tgen.tgz " Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 03/15] dts: merge DTS dts " Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 04/15] dts: merge DTS framework/__init__.py " Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 05/15] dts: merge DTS framework/asan_test.py " Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 06/15] dts: merge DTS framework/checkCase.py " Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 07/15] dts: merge DTS framework/dts.py " Juraj Linkeš
2022-04-06 14:55 ` [RFC PATCH v1 08/15] dts: merge DTS framework/exception.py " Juraj Linkeš
2022-04-06 14:56 ` [RFC PATCH v1 09/15] dts: merge DTS framework/logger.py " Juraj Linkeš
2022-04-06 14:56 ` [RFC PATCH v1 10/15] dts: merge DTS framework/packet.py " Juraj Linkeš
2022-04-06 14:56 ` [RFC PATCH v1 11/15] dts: merge DTS framework/project_dpdk.py " Juraj Linkeš
2022-04-06 14:56 ` [RFC PATCH v1 12/15] dts: merge DTS framework/serializer.py " Juraj Linkeš
2022-04-06 14:56 ` [RFC PATCH v1 13/15] dts: merge DTS framework/utils.py " Juraj Linkeš
2022-04-06 14:56 ` [RFC PATCH v1 14/15] dts: merge DTS main.py " Juraj Linkeš
2022-04-06 14:56 ` [RFC PATCH v1 15/15] dts: merge DTS version.py " Juraj Linkeš
2022-04-07  5:04 ` [RFC PATCH v1 00/15] merge DTS core files " Jerin Jacob
2022-04-07  7:33   ` Thomas Monjalon [this message]
2022-04-11  7:41     ` Juraj Linkeš
2022-04-11 17:55       ` Honnappa Nagarahalli
2022-04-11 18:20         ` Owen Hilyard
2022-04-11 19:06   ` Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44577792.fMDQidcC6G@thomas \
    --to=thomas@monjalon.net \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jerinjacobk@gmail.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=lijuan.tu@intel.com \
    --cc=ohilyard@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).