From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB4D1A050B; Thu, 7 Apr 2022 09:33:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E07E40689; Thu, 7 Apr 2022 09:33:42 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 503B64014F for ; Thu, 7 Apr 2022 09:33:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id ACF5B32020BB; Thu, 7 Apr 2022 03:33:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 07 Apr 2022 03:33:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=IomPRLlnRMZ7HH QcrOxDG3KI6AeqvpActDbAMCzILlE=; b=TwRFaxx/UOqCIiL/M6R7Qh06jNVd8Y fjKvH7oN9/vuYje0d5eFp5lW3kZ1p8gVgTqLGXlLDWlDhVwVJgdQk4hmtlhZazaa V4LItEvGHaZ9fELF/KkTtVKBTif+mboS0TXyoM9BdDQT6pVhmms4wKQ6LzrO1dFU /N+d68AFCCuEE5NuWE7UDmudnpWUDzj1TqaajOyQEHgT6BqtJ4V6rBw+DxqnbJSL R5DPmFTdKQPs2s8DJsX6nSNW18pHy+K5UNgguMl7Z/2oB1J53m5qPtmbWE0R4Z7V z3dguxgzqpk6FwAmmk1MyNPRfcOxjS+1FQ/wMPvaO46ePswJXhEp4i+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=IomPRLlnRMZ7HHQcrOxDG3KI6AeqvpActDbAMCzIL lE=; b=gSMsbgVk/KUuIsKegL02nPbvpZjRaWwIxwl6NBSBCArcVqYuR1k+9uEkg +hJlZ+LmY8vySIfrllmQh/CK9xEJIfsxkz4WhGmfjNMB/z7dtxQz/IpY0biVfSFK B3uzJAokw4msGUhypH/T7ipxPJPC5pJMdlUpY+HrKJprQpwXIuK+DWRicO28bH7h WP4+mGaMF9Zq02a1ZQ1YfGfOMM5/8JKj+KCTVetzC85r1kFerzwYaPAp26AWnbRP wCufuYGyI0jeXN+dzpXlVTRJFdhHLlJh7MOtIN110Nmr9el1Wno//VsCLkfKjRUv v2hRNPAkbJ1INyD3E4HGVIvgF6muA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudejjedguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdev uedtjeevheevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Apr 2022 03:33:37 -0400 (EDT) From: Thomas Monjalon To: Juraj =?utf-8?B?TGlua2XFoQ==?= Cc: Jerin Jacob , David Marchand , Honnappa Nagarahalli , ohilyard@iol.unh.edu, "Tu, Lijuan" , dpdk-dev Subject: Re: [RFC PATCH v1 00/15] merge DTS core files to DPDK Date: Thu, 07 Apr 2022 09:33:36 +0200 Message-ID: <44577792.fMDQidcC6G@thomas> In-Reply-To: References: <20220406145606.2913834-1-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/04/2022 07:04, Jerin Jacob: > On Wed, Apr 6, 2022 at 8:26 PM Juraj Linke=C5=A1 wrote: > > > > These are the basic libraries that other libraries depend on. There's > > also the basic framework functionality related to test execution. > > > > Juraj Linke=C5=A1 (15): > > dts: merge DTS dep/tclclient.tgz to DPDK > > dts: merge DTS dep/tgen.tgz to DPDK > > dts: merge DTS dts to DPDK > > dts: merge DTS framework/__init__.py to DPDK > > dts: merge DTS framework/asan_test.py to DPDK > > dts: merge DTS framework/checkCase.py to DPDK > > dts: merge DTS framework/dts.py to DPDK > > dts: merge DTS framework/exception.py to DPDK > > dts: merge DTS framework/logger.py to DPDK > > dts: merge DTS framework/packet.py to DPDK > > dts: merge DTS framework/project_dpdk.py to DPDK > > dts: merge DTS framework/serializer.py to DPDK > > dts: merge DTS framework/utils.py to DPDK > > dts: merge DTS main.py to DPDK > > dts: merge DTS version.py to DPDK >=20 > merge->import >=20 > > > > dts/dep/tclclient.tgz | Bin 0 -> 199327 bytes > > dts/dep/tgen.tgz | Bin 0 -> 134392 bytes >=20 > Some top level comments: > - I think, we should not check in binary files. +1 > - git commit comment should much more than "dts: merge DTS xxxx to DPDK" = where > the commit log should have details on check in. +1 > -Add the documentation from the first patch and update the > documentation per patch > based on the content. +1 More comments: =2D Please don't send so many patches, it looks like spam. =2D Please let's start small with the very minimal code to run a dummy test. =2D Split by file does not make sense The process is going to be very long. The techboard said in the past that we must have a very careful review of an import piece by piece. So please be patient. Thank you