Re: [dpdk-dev] [PATCH v6 00/25] user space vhost library

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Huawei,

2014-10-09 02:54, Huawei Xie:
> This set of patches transforms and refactors vhost example to a user
> space vhost library.
> This library implements a user space vhost cuse driver, and provides
> generic APIs for user space ethernet vSwitch to integrate us-vhost for
> fast packet switching with guest virtio.
> 
> vhost lib consists of five APIs plus several helper routines
> for feature disable/enable.
> 1) rte_vhost_driver_register initializes vhost driver.
> 2) rte_vhost_driver_callback_register registers the callbacks.
> Callbacks are called from vhost driver when a virtio device is ready
> to be added to the data processing core or is de-activated by guest.
> 3) rte_vhost_driver_session_start, a blocking API to start vhost
> message handler session loop.
> 4) rte_vhost_enqueue_burst and rte_vhost_dequeue_burst for
> enqueue/dequeue packets to/from virtio ring respectively.
> 
> v2) turn off vhost lib by default
> 
> v3) fixed checkpatch issues
> 
> v4) split the patch per thomas' requirement
> 
> v5) fine granularity split of the patch
>     regenerate patches based on latest commit
>     this patchset removes vhost example patches, which will be
>  submitted later.
> 
> Huawei Xie (25):
>   move src files from examples/vhost to lib/librte_vhost
>   rename main.c to vhost_rxtx.c and virtio-net.h to rte_vhost_net.h
>   keep virtio_dev_(merge_)rx, copy_from_mbuf_to_vring and virtio_dev_merge_tx; remove anything else in vhost_rxtx.c
>   remove mac learning, mac/vlan, VMDQ and other switching related logic
>   remove host memory region region related logic
>   remove retry
>   patch virtio_dev_merge_tx to make it return packets to app
>   patch vhost_dev_merge_tx about buf_size
>   add queue_id parameter to vhost rx/tx functions
>   define PACKET_BURST
>   rte_vhost_en/dequeue_burst API
>   move virtio_net_config_ll strcture to virtio_net.c
>   remove index
>   call get_virtio_net_callbacks to get the ops in register_cuse_device
>   rte_vhost_driver_register and rte_vhost_session_start API
>   rte_vhost_callback_register API
>   add debug print
>   define VHOST_SUPPORTED_FEATURES
>   header file cleanup
>   static fix
>   add priv field in virtio_net to store application specific context
>   coding style fixes
>   add TODO/FIXME
>   add vhost support in Makefile

Thanks for your hard work.
There are still few things to clean in this patch splitting
but I've did it to apply them.
I won't describe all the changes I've done, you can check them in the
git repository. In short, some split or merge were needed, some lines were
removed and re-added later, build dependencies were not correct and doc
generation was missing.
You did the big work by really splitting all these stuff. Working on small
commits was far easier. Thanks

Applied

Now you can add the new example.
I hope we'll have more reviews and cleanup now that the first version of
this library is integrated.

-- 
Thomas