From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44CC2A0A0C; Thu, 22 Jul 2021 21:53:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDAC04014D; Thu, 22 Jul 2021 21:53:17 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id 082D640040; Thu, 22 Jul 2021 21:53:17 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id C35E0320094F; Thu, 22 Jul 2021 15:53:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 22 Jul 2021 15:53:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= CbMC/i6i5ZkMc9aCOLu/QVFWojFrn8n9xl0wldfD2mc=; b=KF0euVqUa5ZNcyFV J1zz3F2TsU7chLjChVe6OWIsz+3K7UDXaVibBJNXia/jX7b/uo0aXkEOXWgcq4j5 i7lNPZ4FUPMgeFPx0+ifOULTwfKoVxOGm88crqw75yNcAB4aCsLzJOOobj9ImN0N ddmQDI7EIgmzaxfhuhmSFVNp4P98O5LQDuzsvEgYnm1NkmTSX/tjHPV6OExCkqYS sMUBN+iEMA/EJjIrp9sgYv2tdjRNeOXpwy8Ug/kSudA6wiHImv/1BxuArMN0q/Jf IeHGzRQB6jI0VVSqgnZQaGUCFpx0jEdAOSu6fSHFkkZCvdqeoGnlYI1pSk0GzKeg 0kADtA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=CbMC/i6i5ZkMc9aCOLu/QVFWojFrn8n9xl0wldfD2 mc=; b=ra6nBrGlm3BV7saoR9sP5xPdDeF0PjW2lbF1Zr5F84zJ6a2RRKMwWofiY +bLu1LO/Mc/V7WuCpDPgmVpu05sdKM7mqbMC/BxJYksFPbauo3KY9NyDoRHNjKuR QGaNPRFBSrp92/BQQlGgiWkWQQJjq7MPQaXmaHwTMU1i2uFud1XZXiOfzGDrDlxm CZfDgzmgbxf/VCrJCIoZRFCQ7KfXJ9SE1hG1rz/BzW4ibkQfYowhqZr1YQDlU3r8 gm6kBeVAssWatByi6W2wDyCHy0s+QBktulhzyeBR6ms1vq9ye9iYfuyvl3QhPyql rfbcKt4Ibw7J3eiXkOWY7mQfzF/fQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigddufeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 15:53:12 -0400 (EDT) From: Thomas Monjalon To: Mohsin Kazmi Cc: Olivier Matz , dev@dpdk.org, ray.kinsella@intel.com, stable@dpdk.org, Tomasz Kulasek , Konstantin Ananyev Date: Thu, 22 Jul 2021 21:53:31 +0200 Message-ID: <4459484.c67x3OAJy8@thomas> In-Reply-To: References: <20210630110404.21209-1-mohsin.kazmi14@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] net: prepare the outer ipv4 hdr for checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/07/2021 11:14, Mohsin Kazmi: > On Wed, Jun 30, 2021 at 3:09 PM Olivier Matz wrote: > > > + if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) { > > > inner_l3_offset += m->outer_l2_len + m->outer_l3_len; > > > + /* > > > + * prepare outer ipv4 header checksum by setting it to 0, > > > + * in order to be computed by hardware NICs. > > > + */ > > > + if (ol_flags & PKT_TX_OUTER_IP_CKSUM) { > > > + ipv4_hdr = rte_pktmbuf_mtod_offset(m, > > > + struct rte_ipv4_hdr *, > > m->outer_l2_len); > > > + ipv4_hdr->hdr_checksum = 0; > > > + } > > > + } > > > > What about outer L4 checksum? Does it requires the same than inner? > > > I am using XL710 for my testing with i40e dpdk driver. AFAIK, It doesn't > support outer l4 checksum. I am not sure if other Intel NICs support it. This function is used by a lot of drivers. Try git grep rte_net_intel_cksum_prepare I think we need more reviews on the v3. Given it is far from being a new bug, I suggest to wait the next release in order to have more feedbacks.