From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 42ABE28FD for ; Fri, 3 May 2019 22:40:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BB90028CAD; Fri, 3 May 2019 16:40:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 03 May 2019 16:40:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=P1wxhaQBBDZuxXCJxp7VoHO3Fb2+ZD4u2iGynVVJOsE=; b=QCUh4nM94ZB2 aDw7R43HM7GRvDy9BjIeHcd6yUOfhYUIhhpw1pMnUJ0WDIAOWq6HoLL2bHbI9T5t qXkBVP9jUUpImWX3cEkvjKmQuDBCkKhoEJrRgx2lpGRkubFe/bbDe6hHlFZR6IjC //KMzRKgpzynm5MgHTvhUVuuVeGIac0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=P1wxhaQBBDZuxXCJxp7VoHO3Fb2+ZD4u2iGynVVJO sE=; b=kBLEPx9rHun0tDv7f3GhqiTWnpJP0DOMd2tsWHtcAwymYYfViCESgU2KJ N2PXkhlzSidcQVPCSwxTAfmOnHcCpgmyDzO+9jj8N5JUt4o2K8DXQxQXnj+dMjSC wfCkFsEji/guQhDC5qWoUhHUwTutJCVo0n4QU6sCNCmT7C4MSMX3/F64yqPRSVBs 3v3TCtRpY7qy9NNx/dk/Fp4Rn4rryyQeaARgca0PqUBn9GmYgjPolMBDpfBy/Bwm EcRd3lcCnpi3xf6CCjqQDpA19k0qxvX3LMwWE5iZ7nG+lMZT9YxWPyDt16PDANo0 jhPqW4wsxjMoR0iz+UBjaWU2CltkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EB225E4544; Fri, 3 May 2019 16:40:49 -0400 (EDT) From: Thomas Monjalon To: Ruifeng Wang Cc: dev@dpdk.org, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, jerinj@marvell.com, Honnappa.Nagarahalli@arm.com, nd@arm.com Date: Fri, 03 May 2019 22:40:47 +0200 Message-ID: <4460026.HBRZev9yL2@xps> In-Reply-To: <1556532127-46557-1-git-send-email-ruifeng.wang@arm.com> References: <1556532127-46557-1-git-send-email-ruifeng.wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] hash: simplify signature compare neon process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2019 20:40:52 -0000 29/04/2019 12:02, Ruifeng Wang: > Replaced multiple neon instructions with single equivalent instruction. > This made simpler code and a bit higher performance. > Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72 > platforms. As it is an improvement (with small benefit), I don't take any risk for -rc3 and defer it to 19.08. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8CC59A0AC5 for ; Fri, 3 May 2019 22:40:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85DD82986; Fri, 3 May 2019 22:40:53 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 42ABE28FD for ; Fri, 3 May 2019 22:40:52 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BB90028CAD; Fri, 3 May 2019 16:40:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 03 May 2019 16:40:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=P1wxhaQBBDZuxXCJxp7VoHO3Fb2+ZD4u2iGynVVJOsE=; b=QCUh4nM94ZB2 aDw7R43HM7GRvDy9BjIeHcd6yUOfhYUIhhpw1pMnUJ0WDIAOWq6HoLL2bHbI9T5t qXkBVP9jUUpImWX3cEkvjKmQuDBCkKhoEJrRgx2lpGRkubFe/bbDe6hHlFZR6IjC //KMzRKgpzynm5MgHTvhUVuuVeGIac0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=P1wxhaQBBDZuxXCJxp7VoHO3Fb2+ZD4u2iGynVVJO sE=; b=kBLEPx9rHun0tDv7f3GhqiTWnpJP0DOMd2tsWHtcAwymYYfViCESgU2KJ N2PXkhlzSidcQVPCSwxTAfmOnHcCpgmyDzO+9jj8N5JUt4o2K8DXQxQXnj+dMjSC wfCkFsEji/guQhDC5qWoUhHUwTutJCVo0n4QU6sCNCmT7C4MSMX3/F64yqPRSVBs 3v3TCtRpY7qy9NNx/dk/Fp4Rn4rryyQeaARgca0PqUBn9GmYgjPolMBDpfBy/Bwm EcRd3lcCnpi3xf6CCjqQDpA19k0qxvX3LMwWE5iZ7nG+lMZT9YxWPyDt16PDANo0 jhPqW4wsxjMoR0iz+UBjaWU2CltkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrjedugdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EB225E4544; Fri, 3 May 2019 16:40:49 -0400 (EDT) From: Thomas Monjalon To: Ruifeng Wang Cc: dev@dpdk.org, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, pablo.de.lara.guarch@intel.com, jerinj@marvell.com, Honnappa.Nagarahalli@arm.com, nd@arm.com Date: Fri, 03 May 2019 22:40:47 +0200 Message-ID: <4460026.HBRZev9yL2@xps> In-Reply-To: <1556532127-46557-1-git-send-email-ruifeng.wang@arm.com> References: <1556532127-46557-1-git-send-email-ruifeng.wang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] hash: simplify signature compare neon process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190503204047.0vCt_Swn6zcf38x_6Y1YAQBs9EwyOWAVUmhv1NcPAdg@z> 29/04/2019 12:02, Ruifeng Wang: > Replaced multiple neon instructions with single equivalent instruction. > This made simpler code and a bit higher performance. > Hash bulk lookup had 0.1% ~ 3% performance gain in tests on ARM A72 > platforms. As it is an improvement (with small benefit), I don't take any risk for -rc3 and defer it to 19.08.