From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03E14A09EF; Wed, 16 Dec 2020 14:48:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FCE1C9A4; Wed, 16 Dec 2020 14:48:43 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0E327C99E for ; Wed, 16 Dec 2020 14:48:41 +0100 (CET) IronPort-SDR: g+smtzUrWISPq39fHvJmBCPjxbErRhR/Kni5NRlNyeqMfAQnBWbm/3VnAd45mhBaTeF/bTMGP7 Lgvk/w74NQuQ== X-IronPort-AV: E=McAfee;i="6000,8403,9836"; a="154870780" X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="154870780" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 05:48:40 -0800 IronPort-SDR: y9VmjYLWzuF67OZ4/GkMMYqMMaxeUB3xWW7zQBvtNnNEznM1a8y6hA+qHuvKZmOXYRSbNWQCcv p1VsZY1jV3bg== X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="369080821" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.233.132]) ([10.213.233.132]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2020 05:48:38 -0800 To: Liron Himi Cc: "dev@dpdk.org" , Luca Boccassi , Kevin Traynor , Akhil Goyal References: <20201202130529.7332-2-lironh@marvell.com> <20201215222319.13816-1-lironh@marvell.com> From: Ferruh Yigit Message-ID: <4469d988-c732-b302-85bf-f8bbc93a33d0@intel.com> Date: Wed, 16 Dec 2020 13:48:35 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/16/2020 1:41 PM, Liron Himi wrote: > > -----Original Message----- > From: Ferruh Yigit > Sent: Wednesday, 16 December 2020 15:37 > To: Liron Himi > Cc: dev@dpdk.org; Luca Boccassi ; Kevin Traynor ; Akhil Goyal > Subject: [EXT] Re: [PATCH v2] meson: update meson build for armada drivers > > External Email > > ---------------------------------------------------------------------- > On 12/15/2020 10:23 PM, lironh@marvell.com wrote: >> From: Liron Himi >> >> With pkg-config support available within musdk library (from >> musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' >> can be removed. >> PKG_CONFIG_PATH environment variable should be set appropriately to >> use the musdk library. > > Hi Liron, > > It is good change to get rid of an custom meson option, can we or should we backport this to the v20.11? > [L.H.] yes, it can be backported. > >> >> docs are updated with new musdk version and meson instructions. >> >> Signed-off-by: Liron Himi >> Reviewed-by: Liron Himi >> --- >> v2: >> * include updated docs in this patch >> * add musdk version in commit message >> --- >> doc/guides/nics/mvneta.rst | 13 ++++++++----- >> doc/guides/nics/mvpp2.rst | 15 +++++++++------ >> drivers/common/mvep/meson.build | 14 +++++--------- >> drivers/crypto/mvsam/meson.build | 15 +++++---------- > > @Ahil, is it OK if I get this to the next-net, since logically related? > >> drivers/net/mvneta/meson.build | 19 +++++-------------- >> drivers/net/mvneta/mvneta_ethdev.h | 1 + >> drivers/net/mvpp2/meson.build | 15 +++++---------- >> meson_options.txt | 2 -- >> 8 files changed, 38 insertions(+), 56 deletions(-) >> > > <...> > >> @@ -94,7 +94,7 @@ be passed as part of EAL arguments. >> -c 3 -- -i --p 3 -a >> >> >> -Building DPDK >> +Building MUSDK >> ------------- >> > > This is giving doc warning because of "Title underline too short". > [L.H.] okay, will fix in v3 > > <...> > >> @@ -108,7 +108,7 @@ Prerequisites >> DPDK environment. >> >> >> -Building DPDK >> +Building MUSDK >> ------------- >> > > Ditto. > [L.H.] same > > <...> > >> diff --git a/drivers/net/mvneta/mvneta_ethdev.h >> b/drivers/net/mvneta/mvneta_ethdev.h >> index ef8067790..e090abc25 100644 >> --- a/drivers/net/mvneta/mvneta_ethdev.h >> +++ b/drivers/net/mvneta/mvneta_ethdev.h >> @@ -21,6 +21,7 @@ >> #undef container_of >> #endif >> >> +#include > > Is this include related with this patch? > [L.H.] yes, without it meson build will fail > There is no change in the code, how it was working before but failing now? Can you please give more details why it is needed?