From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
 by dpdk.org (Postfix) with ESMTP id 14BFC8E58
 for <dev@dpdk.org>; Wed,  2 Dec 2015 10:26:24 +0100 (CET)
Received: by wmuu63 with SMTP id u63so206348987wmu.0
 for <dev@dpdk.org>; Wed, 02 Dec 2015 01:26:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:organization:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding
 :content-type; bh=Zbbsxj1IERn8OCeuwH8z1xPay7qczqsBavnIOe9pRfE=;
 b=PvTQH/Kufw5lXrxGFq1mcGlOKewGFROXbDH0iqrPB3uMb9ZytDBCM+TsCiA62rfdae
 pmSlj7OLEWh0HNqeFTPBx0x/d3WcjdmEiy5EIAqdHsK999Q6n8/3CxrwI5hZy6j3fDfs
 gHnBMJyG3EREncb3NnWUQmya3VBGCEoPB0p5XzBsy7wGU7fa+yhZLcW4HMRpsA8M6yUU
 9HIKIKrn4K+vrUswExt3aH8HPz46yCyKiNr53w6TsEWjPIji36AAavICDtZtfxkUIy60
 5gi8p3//wCL/FsLsSTJ3yqSQtlvx+rhCbdgUgjuDD+fwYEiTUWG/db6YENv1jSqUlQUl
 I8Eg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=Zbbsxj1IERn8OCeuwH8z1xPay7qczqsBavnIOe9pRfE=;
 b=YcLDUH8LhzUvt7u3tx2CoVtNEGxBsJ8k8kZGtdL4EtKcLRFVds/ig7QzWZMdt8OTyf
 xC5314udpf+ZTKGkVWDne6i1cqwmGXWnhZU1td34pRsGV+0K2xd0i6w6o3NIoTIin8hx
 tnMC7+s8NYYG23r4G2QALE5w2tJdIO8R0A54tal/VPB9m70z1VXKyN8IONxBtD6Egcor
 jHiszXDYGO3WXn+Wn/+XrQ8ZkPKZh6irBBNEcb3tbb3SFU6nxCIyAoDGvH8sCVx3NywQ
 k58k7XoAPHiVs4FgYKXKzmAgWyRLwuOf0qc7KhIv4MHxaK7HrmNrGNTz3ifSCmNeUF2T
 QHvA==
X-Gm-Message-State: ALoCoQmLSS1cx27NzqHAhWPQ8qEPJnd5VMmoSiNkHAIFyqinPbxXm4MjiFy3Hpg65Iwi7O45xtgr
X-Received: by 10.194.114.34 with SMTP id jd2mr3232845wjb.12.1449048383930;
 Wed, 02 Dec 2015 01:26:23 -0800 (PST)
Received: from xps13.localnet ([93.158.46.48])
 by smtp.gmail.com with ESMTPSA id a186sm2305856wmh.4.2015.12.02.01.26.22
 (version=TLSv1/SSLv3 cipher=OTHER);
 Wed, 02 Dec 2015 01:26:23 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Date: Wed, 02 Dec 2015 10:25:14 +0100
Message-ID: <4473021.fPPR1HZVLV@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <565EA15A.1080902@redhat.com>
References: <1449028676-19232-1-git-send-email-thomas.monjalon@6wind.com>
 <565EA15A.1080902@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 00/10] standard make install
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Dec 2015 09:26:24 -0000

2015-12-02 09:44, Panu Matilainen:
> That aside, a bigger problem is that it doesn't seem to work.
> 
> make clean
> make config T=x86_64-native-linuxapp-gcc
> make
> make install DESTDIR=/tmp/dpdk-root

Oh, I forgot to test the simple case where O= is not specified!

It should be fixed with this change:

--- a/mk/rte.sdkinstall.mk
+++ b/mk/rte.sdkinstall.mk
@@ -31,8 +31,10 @@
 #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 # Build directory is given with O=
-O ?= .
+ifndef T
+O ?= build
 BUILD_DIR := $O
+endif
 
 prefix      ?=     /usr/local
 exec_prefix ?=      $(prefix)
@@ -52,6 +54,7 @@ sdkdir      ?= $(datadir)
 # with make install T=<config>
 ifdef T
 # The build directory is T and may be prepended with O
+O ?= .
 BUILD_DIR := $O/$T
 # Default usage of T= will install an almost flat staging tree
 export prefix =