From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 8139411A2 for ; Mon, 2 Nov 2015 00:26:02 +0100 (CET) Received: by wmff134 with SMTP id f134so46101867wmf.1 for ; Sun, 01 Nov 2015 15:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=48b+ARkonCJhH7bm6i1l7m01QN2zyPFHv73anZTWv2Y=; b=xbHR3ZS9B/g2FbvxVfnOOjNpUgvAUTaRkwXDgmP5r5ICibNGUmYHVoM9kX6DJA4Ka2 ZysERPlVlz1+rqzfYcm6YDCvcLDtmobCIOiiK2zqlBXGUTXzwbXO0g+6zwJd3LBDBj0r Rbr4hqAwGjAZjG1MXjry9af8XlnAmeOo0UqJEwGjthvYeFnOcCy968TWIKdQS6feqA9p DF8X2TNeAo4Fay1xIWzrmZHMtsb+Rfhj3nRU1qz3dAaOvkm4Yaz5FMNSeuXjtgcYeyH/ thC7xUeOWtavJHG1tfLRFiwtgU2NI4QkKyEV+za6mvgMyMocp43+A3U1mSeH/DPpkaTp 2XKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=48b+ARkonCJhH7bm6i1l7m01QN2zyPFHv73anZTWv2Y=; b=m7rjdAXQEW/DxhHWpuNEKyvWSvSZE4WE2J7XNzQFt2gCZ/9yUDc+lD81O7YoAAWPiI N/1ZaBFZYDBzXEP/JeMdVav4QF4GUPTs6RaDHjpZqHUjOejIcs47UCxEm7Drxsh/6+cQ lMUGQWp67ifPCiPBo9GmyzlcaMuWo7992ONdAwDqINaVRKgjEP/6wgVJ5TgM5kRpz4va lQPhq9gDK0unqbJ8CT+eIJForeOTIDiM4WEBlwYVSo2GeTFSh5mDcPGvUjTkNKu9xxjA 0xbSdHrVtN9Po5rlnAUvrmRX40fPQVanPdVXEg34J+xLWJRpB1EkzliLUDCIr2PKO/LU hL6w== X-Gm-Message-State: ALoCoQk6eNS4UyALsJYC0ccCcU39pKGLGVWFakSO3VfwzcwwW0xLvuINA4Vsxsyjr19Dsk9eBkBK X-Received: by 10.28.132.18 with SMTP id g18mr9492389wmd.64.1446420362361; Sun, 01 Nov 2015 15:26:02 -0800 (PST) Received: from xps13.localnet (145.16.90.92.rev.sfr.net. [92.90.16.145]) by smtp.gmail.com with ESMTPSA id r12sm14940302wmd.17.2015.11.01.15.26.01 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Nov 2015 15:26:01 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Date: Mon, 02 Nov 2015 00:24:51 +0100 Message-ID: <4489406.qekDmzhmkY@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446419842-22920-1-git-send-email-ferruh.yigit@intel.com> References: <1706989.WgznurFLZ8@xps13> <1446419842-22920-1-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Eric Kinzie Subject: Re: [dpdk-dev] [PATCH] mk: fix ABI versioning compile error for combined shared library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Nov 2015 23:26:02 -0000 2015-11-01 23:17, Ferruh Yigit: > Fixes following error: > LD libdpdk.so > /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found > for symbol @DPDK_x.y > --- a/mk/rte.sharelib.mk > +++ b/mk/rte.sharelib.mk > @@ -40,6 +40,7 @@ LIB_ONE := lib$(RTE_LIBNAME).so > else > LIB_ONE := lib$(RTE_LIBNAME).a > endif > +SHARED_LDFLAGS += --version-script=./lib/libdpdk.map > endif It looks to be the right thing to do. > ifeq ($(LINK_USING_CC),1) > # Override the definition of LD here, since we're linking with CC > LD := $(CC) $(CPU_CFLAGS) > -O_TO_S = $(LD) $(call linkerprefix,$(CPU_LDFLAGS)) \ > +O_TO_S = $(LD) $(call linkerprefix,$(SHARED_LDFLAGS)) \ > -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > else > -O_TO_S = $(LD) $(CPU_LDFLAGS) \ > +O_TO_S = $(LD) $(SHARED_LDFLAGS) \ > -shared $(OBJS) -o $(RTE_OUTPUT)/lib/$(LIB_ONE) > endif Why do you remove CPU_LDFLAGS?