From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 11E64BD1D for ; Wed, 26 Oct 2016 17:42:00 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id e69so39130230wmg.0 for ; Wed, 26 Oct 2016 08:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=sye3Oy6aCCM0/mdfenVTHICac9FS8iwSdyNddx1YvDI=; b=nCcTTTDwFk3+FLuzkJwEFA7YrelDeYHIHZao1RnHZl2mduNx/puwzoGqUPhTlIqgGZ 3bKMGCTIbwiJbKrAvltBcFMfv/qRDSPbn6/O1lWWnZ+m8jLu3+HzN9rFyTbrcEzB/gkH ZkT+AF1VoXcITnhxeRHalkJC453+45SPMivl2qf2Q2PRfBlZ+FqjXB1INCEj7zJ387rF 5OtiRVjXQu1ULUZ2t31GZIZsNzQt0jCKZr/Wkh5ALCtoOv6dFzZile7cXjaHU1NAHV4R nbhk52z9UEFcKDWVjDpPRmL9nvbZcLO7xuh9gZ9RuGlQWvWBDWXJ72+n9MsdetTxtNUX q0vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=sye3Oy6aCCM0/mdfenVTHICac9FS8iwSdyNddx1YvDI=; b=DcKLBeMuUWao/VlW0LqxMhQwQiOOeYBz/CZR+0a21IL581dsYTMpN0OoY8wKY3lmZy KFke7r2m/n60gL2LvZAySN5nz30VvqOm2PYF9/aTaEiZ4EYL4V7eVDabu1y4J28FyEiU zpwHwZPRj5LIf3arisb12lNuHZmx4dO0oPBHQlxQxLGBPRn3kr0cpOyfWaxAc+HWv0eW 9yowM0l7uabkCa8ZnP8Gf6Y/VdWbF8nIZmL8yNHOHqm5lotfNxhVs0Vx0dVFPqE7RhPj Ls9pLCoOER7jWimngDrpj655XDcRtUjEWH5ouLzymSLnuHnzn/ACWhMVhsZvKKrUCExA Ds5Q== X-Gm-Message-State: ABUngvfidZBS1mlJJL6R29iI5jGPSdOg9RgFfnsHRqJ8XAIPxgF4K7ajq0n/P1PISB3T+F8G X-Received: by 10.194.119.162 with SMTP id kv2mr2785843wjb.182.1477496519790; Wed, 26 Oct 2016 08:41:59 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 186sm10260360wmy.13.2016.10.26.08.41.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Oct 2016 08:41:59 -0700 (PDT) From: Thomas Monjalon To: Rasesh Mody , ferruh.yigit@intel.com, bruce.richardson@intel.com, Harish Patil Date: Wed, 26 Oct 2016 17:41:58 +0200 Message-ID: <4491648.SeJM0cAZEU@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1476850306-2141-19-git-send-email-rasesh.mody@qlogic.com> References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com> <1476850306-2141-19-git-send-email-rasesh.mody@qlogic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com Subject: Re: [dpdk-dev] [PATCH v4 18/32] net/qede: add missing 100G link speed capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 15:42:00 -0000 2016-10-18 21:11, Rasesh Mody: > From: Harish Patil > > This patch fixes the missing 100G link speed advertisement > when the 100G support was initially added. > > Fixes: 2af14ca79c0a ("net/qede: support 100G") > > Signed-off-by: Harish Patil [...] > [Features] > +Speed capabilities = Y This feature should be checked only when it is fully implemented, i.e. when you return the real capabilities of the device. > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -599,7 +599,8 @@ qede_dev_info_get(struct rte_eth_dev *eth_dev, > DEV_TX_OFFLOAD_UDP_CKSUM | > DEV_TX_OFFLOAD_TCP_CKSUM); > > - dev_info->speed_capa = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_40G; > + dev_info->speed_capa = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_40G | > + ETH_LINK_SPEED_100G; > } It is only faking the capabilities at driver-level. You should check if the underlying device is able to achieve 100G before advertising this flag to the application. I suggest to update this patch to remove the doc update. The contract is to fill it only when the code is fixed. By the way, we must call every other drivers to properly implement this feature.