From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Guy Kaneti <guyk@marvell.com>,
Luca Boccassi <bluca@debian.org>, Rosen Xu <rosen.xu@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override
Date: Tue, 03 Nov 2020 01:30:30 +0100 [thread overview]
Message-ID: <4495149.WBtOTWmHy8@thomas> (raw)
In-Reply-To: <CAJFAV8wUBTwJ-3BnZVApTvhYt4aDKYQW0=SpQPmLJUcKqjSPAQ@mail.gmail.com>
02/11/2020 20:48, David Marchand:
> On Mon, Nov 2, 2020 at 6:45 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Since the device class is now part of the standard filenames, it's no
> > longer needed in name overrides in specific drivers.
> >
> > Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Equivalent to https://patchwork.dpdk.org/patch/81961/ but maybe better
> to skip setting fmt_name when it is the same as the default value.
[...]
> > -name = 'octeontx2_regex'
But it is not the same?
The name will default to "octeontx2", which is fine.
But the fmt_name should not take this default.
I believe fmt_name should be "octeontx2_regex" as I did in my patch.
next prev parent reply other threads:[~2020-11-03 0:30 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 17:44 [dpdk-dev] [PATCH 0/8] fix driver filenames in the docs Bruce Richardson
2020-11-02 17:45 ` [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override Bruce Richardson
2020-11-02 19:48 ` David Marchand
2020-11-03 0:30 ` Thomas Monjalon [this message]
2020-11-03 8:19 ` David Marchand
2020-11-03 9:06 ` Thomas Monjalon
2020-11-03 9:19 ` David Marchand
2020-11-03 9:45 ` David Marchand
2020-11-03 10:27 ` Bruce Richardson
2020-11-02 17:45 ` [dpdk-dev] [PATCH 2/8] doc: fix driver names in compression devices guide Bruce Richardson
2020-11-02 19:54 ` David Marchand
2020-11-02 17:45 ` [dpdk-dev] [PATCH 3/8] doc: fix driver names in crypto " Bruce Richardson
2020-11-02 20:00 ` David Marchand
2020-11-02 20:02 ` David Marchand
2020-11-03 10:28 ` Bruce Richardson
2020-11-02 17:45 ` [dpdk-dev] [PATCH 4/8] doc: fix driver names in event " Bruce Richardson
2020-11-02 20:03 ` David Marchand
2020-11-02 17:45 ` [dpdk-dev] [PATCH 5/8] doc: fix driver names in NIC " Bruce Richardson
2020-11-02 20:17 ` David Marchand
2020-11-02 20:45 ` David Marchand
2020-11-03 2:31 ` Xu, Rosen
2020-11-03 2:47 ` Ajit Khaparde
2020-11-02 17:45 ` [dpdk-dev] [PATCH 6/8] doc: fix driver names in regex " Bruce Richardson
2020-11-02 20:07 ` David Marchand
2020-11-02 17:45 ` [dpdk-dev] [PATCH 7/8] doc: fix driver names in vDPA " Bruce Richardson
2020-11-02 20:09 ` David Marchand
2020-11-02 17:45 ` [dpdk-dev] [PATCH 8/8] doc: fix driver names in programmers guide Bruce Richardson
2020-11-02 20:12 ` David Marchand
2020-11-02 20:19 ` [dpdk-dev] [PATCH 0/8] fix driver filenames in the docs David Marchand
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 0/7] " Bruce Richardson
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 1/7] doc: fix driver names in compression devices guide Bruce Richardson
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 2/7] doc: fix driver names in crypto " Bruce Richardson
2020-11-03 13:05 ` David Marchand
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 3/7] doc: fix driver names in event " Bruce Richardson
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 4/7] doc: fix driver names in NIC " Bruce Richardson
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 5/7] doc: fix driver names in regex " Bruce Richardson
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 6/7] doc: fix driver names in vDPA " Bruce Richardson
2020-11-03 12:36 ` [dpdk-dev] [PATCH v2 7/7] doc: fix driver names in programmers guide Bruce Richardson
2020-11-03 14:50 ` [dpdk-dev] [PATCH v2 0/7] fix driver filenames in the docs David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4495149.WBtOTWmHy8@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=guyk@marvell.com \
--cc=rosen.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).