From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 1453B7D34
 for <dev@dpdk.org>; Mon, 17 Sep 2018 18:44:56 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id 06B7736D;
 Mon, 17 Sep 2018 12:44:54 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Mon, 17 Sep 2018 12:44:55 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=IH6VZ4eN5NZIMRdN1czJNEtrwR
 5eo7YqKY27+7xsTe8=; b=pcghRdsjjuhzTmT+FSkMgtk5jS4HpIvXj6YS/O8uur
 p47gb+LjiqZkaDVFM263edxcYVKv6Y/WdTgKynD3l/sfeh6+j4HNYScwKurgsrNg
 R4gsTpkClVy091jcQLWGMc9kOMMeZ7eWTqsSG94PL0ET/Tjvg0SFswesgwl0rzG2
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=IH6VZ4
 eN5NZIMRdN1czJNEtrwR5eo7YqKY27+7xsTe8=; b=pinSjeCTc5V3A3Yj1e6UhU
 z0Zx6Sps7EJexVb89FthH4R7lUFa6kECrjP3h6pZrn4x7aMkfSjfywd8v2ovHQcE
 Dyi9wL66Y2wTB3jeixBnyoPXF+QD5yOAD37B+sCxX5g+35lVXGD9aT295graCrTH
 w/PCMbN9ISLd3j7nmHTJX4gBKGdXGERiXDuLKyUq5Mts4dgYmXQKM/gdHuNjTc3E
 8bap3V8Nw4LIjdlTLrTDZFf93EwmF/264lx/4qYi24NA4gaA792hb2UeDsFj8m52
 oEc/fYD6RrcwPJadnSMug5yt3DZpjzhUnIIJUh3EVOCMINW0VCUonfW6N2N5Pf7g
 ==
X-ME-Proxy: <xmx:BtqfW0m3zv3zuHku6kkQPksVmnt_8SjldDPF8dNajqD_rNfmqpPRqw>
 <xmx:BtqfW_kJfimdFpZT2s6veVw3Ti7ArSY8t71oggdSQ7SsZs1Ni07Heg>
 <xmx:BtqfW7N0WgcstvIqcYoHMJeeSKw3daNLTP3B0YHOjaQ6611DkBN9qg>
 <xmx:BtqfWxu47jE-oKIaOMwvDs_dwd7Gcr2Xg4tzNmJMiQ6C3bT0f8t5Kw>
 <xmx:BtqfW9B2Xn4Ajt1cX1KfnaKMkwRzaCuVUmWUgrStPpPZSsSJRULufQ>
 <xmx:BtqfW-SI1Ev7WOv-bfPuJVLh58Giu07NoteOuDNc0euP36bJwSxJIQ>
X-ME-Sender: <xms:BtqfW8yKlqvl4Q2upLeoKMMTaNm_yIXH3SUbXmLwAmyvmWWxWsBJlw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id A3BFF102D8;
 Mon, 17 Sep 2018 12:44:53 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Date: Mon, 17 Sep 2018 18:44:52 +0200
Message-ID: <4495560.7NONgeh6lB@xps>
In-Reply-To: <20180917151716.GA16172@bricha3-MOBL.ger.corp.intel.com>
References: <20180829160252.7890-1-bruce.richardson@intel.com>
 <2047675.hNTm73f6kF@xps>
 <20180917151716.GA16172@bricha3-MOBL.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation
	test
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Sep 2018 16:44:56 -0000

17/09/2018 17:17, Bruce Richardson:
> On Mon, Sep 17, 2018 at 03:38:58PM +0200, Thomas Monjalon wrote:
> > 17/09/2018 14:54, Bruce Richardson:
> > > On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote:
> > > > 29/08/2018 18:02, Bruce Richardson:
> > > > > Add in a cross-file to enable 32-bit compile tests as part
> > > > > of the test-meson-builds script.
> > > > > 
> > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > > ---
> > > > > NOTE: For ease of use, it's recommended that meson 0.47 be used for
> > > > > this testing. With earlier versions, it may be necessary to ensure that
> > > > > the same development packages are installed for both 64-bit and 32-bit.
> > > > > ---
> > > > >  config/x86/i686_sse4_linuxapp_gcc | 18 ++++++++++++++++++
> > > > >  devtools/test-meson-builds.sh     |  4 ++++
> > > > >  2 files changed, 22 insertions(+)
> > > > 
> > > > I'm not sure about adding this test as mandatory, because 32-bit version
> > > > of libraries can be hard to get, especially libbsd and libnuma.
> > > > I hope this test will be run by all developers, so we should not discourage
> > > > them by adding too many requirements.
> > > > Opinion? Idea?
> > > 
> > > Libbsd is not required, but yes, libnuma is, so you do need a 32-bit
> > > libnuma (devel) installed to run this test. I would expect that to be
> > > available on most distros though. I'm open to suggestions as to how to make
> > > this optional, but I do think that sanity checking 32-bit is good practice
> > > to avoid errors, e.g. those wonderful printf format strings for uint64_t.*
> > 
> > I agree and I am testing i686 with the "make build system".
> > I define DPDK_DEP_NUMA=n which disables any NUMA option.
> > Can we have this kind of tweak with meson?
> > 
> > Or perhaps we can just have an option in the script to disable this test?
> > 
> Actually, do you see build failures with 32-bit without the numa or BSD
> libraries? I removed 32-bit versions of both dev packages and everything
> still compiles? The setting of the appropriate defines is based on detected
> libraries.

This is what I see:

ninja -C build-i686
ninja: Entering directory `build-i686'
[6/1237] Linking target lib/librte_kvargs.so.1.1.
FAILED: lib/librte_kvargs.so.1.1 
gcc  -o lib/librte_kvargs.so.1.1 'lib/lib@@rte_kvargs@sta/librte_kvargs_rte_kvargs.c.o' -Wl,--no-undefined -Wl,--as-needed -Wl,-O1 -shared -fPIC -Wl,--start-group -Wl,-soname,librte_kvargs.so.1 -pthread -lm -ldl -lnuma -lbsd -Wl,--end-group -Wl,--version-script=lib/librte_kvargs/rte_kvargs_version.map -m32 
/usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libnuma.so when searching for -lnuma
/usr/bin/ld: skipping incompatible /usr/lib/libnuma.so when searching for -lnuma
/usr/bin/ld: cannot find -lnuma
/usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.1/../../../libbsd.so when searching for -lbsd
/usr/bin/ld: skipping incompatible /usr/lib/libbsd.so when searching for -lbsd
/usr/bin/ld: cannot find -lbsd
collect2: error: ld returned 1 exit status
[11/1237] Compiling C object 'lib/lib@@rte_eal@sta/librte_eal_common_eal_common_fbarray.c.o'.
ninja: build stopped: subcommand failed.