From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Howard Wang <howard_wang@realsil.com.cn>, dev@dpdk.org
Cc: pro_nic_dpdk@realtek.com
Subject: Re: [PATCH v6 09/17] net/r8169: add support for hw initialization
Date: Mon, 11 Nov 2024 00:16:58 +0000 [thread overview]
Message-ID: <44bcb906-bf90-4a0f-9d30-85d24cb291a6@amd.com> (raw)
In-Reply-To: <20241108121123.248797-10-howard_wang@realsil.com.cn>
On 11/8/2024 12:11 PM, Howard Wang wrote:
> This patch initializes software variables, resets the NIC, and performs
> other hw initialization tasks.
>
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
>
<...>
> @@ -24,8 +24,8 @@
> #define MII_EXPANSION 0x06 /* Expansion register */
> #define MII_CTRL1000 0x09 /* 1000BASE-T control */
> #define MII_STAT1000 0x0a /* 1000BASE-T status */
> -#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */
> -#define MII_MMD_DATA 0x0e /* MMD Access Data Register */
> +#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */
> +#define MII_MMD_DATA 0x0e /* MMD Access Data Register */
>
Probably unintendent change.
Also I can see 'MII_LPA', 'MII_RERRCOUNTER', 'ADVERTISE_LPACK' and a few
more uses spaces instead of tab, which can be fixed in the patch they
are added.
next prev parent reply other threads:[~2024-11-11 0:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 12:11 [PATCH v6 00/17] Modify code as suggested by the maintainer Howard Wang
2024-11-08 12:11 ` [PATCH v6 01/17] net/r8169: add PMD driver skeleton Howard Wang
2024-11-08 15:58 ` Stephen Hemminger
2024-11-11 0:14 ` Ferruh Yigit
2024-11-11 3:46 ` 答复: " 王颢
2024-11-11 9:08 ` Ferruh Yigit
2024-11-11 9:24 ` 答复: " 王颢
2024-11-11 9:31 ` Ferruh Yigit
2024-11-08 12:11 ` [PATCH v6 02/17] net/r8169: add logging structure Howard Wang
2024-11-08 12:11 ` [PATCH v6 03/17] net/r8169: add hardware registers access routines Howard Wang
2024-11-08 12:11 ` [PATCH v6 04/17] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-11-08 12:11 ` [PATCH v6 05/17] net/r8169: add support for hw config Howard Wang
2024-11-11 0:15 ` Ferruh Yigit
2024-11-11 9:44 ` 答复: " 王颢
2024-11-08 12:11 ` [PATCH v6 06/17] net/r8169: add phy registers access routines Howard Wang
2024-11-08 12:11 ` [PATCH v6 07/17] net/r8169: add support for hardware operations Howard Wang
2024-11-08 12:11 ` [PATCH v6 08/17] net/r8169: add support for phy configuration Howard Wang
2024-11-11 0:16 ` Ferruh Yigit
2024-11-11 8:18 ` 答复: " 王颢
2024-11-11 9:21 ` Ferruh Yigit
2024-11-08 12:11 ` [PATCH v6 09/17] net/r8169: add support for hw initialization Howard Wang
2024-11-11 0:16 ` Ferruh Yigit [this message]
2024-11-08 12:11 ` [PATCH v6 10/17] net/r8169: add link status and interrupt management Howard Wang
2024-11-08 12:11 ` [PATCH v6 11/17] net/r8169: implement Rx path Howard Wang
2024-11-11 0:20 ` Ferruh Yigit
2024-11-08 12:11 ` [PATCH v6 12/17] net/r8169: implement Tx path Howard Wang
2024-11-11 0:20 ` Ferruh Yigit
2024-11-08 12:11 ` [PATCH v6 13/17] net/r8169: implement device statistics Howard Wang
2024-11-11 0:21 ` Ferruh Yigit
2024-11-08 12:11 ` [PATCH v6 14/17] net/r8169: implement promisc and allmulti modes Howard Wang
2024-11-08 12:11 ` [PATCH v6 15/17] net/r8169: implement MTU configuration Howard Wang
2024-11-08 12:11 ` [PATCH v6 16/17] net/r8169: add support for getting fw version Howard Wang
2024-11-08 12:11 ` [PATCH v6 17/17] net/r8169: add driver_start and driver_stop Howard Wang
2024-11-11 0:26 ` [PATCH v6 00/17] Modify code as suggested by the maintainer Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44bcb906-bf90-4a0f-9d30-85d24cb291a6@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).