From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C830B45CDF; Mon, 11 Nov 2024 01:17:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B59D1406FF; Mon, 11 Nov 2024 01:17:06 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2047.outbound.protection.outlook.com [40.107.223.47]) by mails.dpdk.org (Postfix) with ESMTP id F0EFA40151 for ; Mon, 11 Nov 2024 01:17:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dQNviXjQ1CTPzMILtRZ8yQs/DVFUiBXpmMRnyd0GlVdD7LdZ96y4STzrbIRrDoRoCzwr2RZosrWvDbChIt0KDntbmb/iezxK8DM6lQ1+/Q5anG/8WFbEveipTJL2ODGfyMTqNxZnAdv6KNmVunmmQ+DAYC0GvnxUO0sm/uZL9+R+fR5h5HPSEfsjFJcS8adhpL6rulYEm9GJEzaCZIb5Pih/bwJagSkfctwW/s06+aAw7rBQ6aJugdEWD55ZPGLfv1c8g06URIQdfnrjRw84lg+/OYDfq6sqYPFejTc7lrxU51iTveQBEL4TAbLyUu7fh7POJsBOK1AiMH5HLy3Lyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lt1WBp8hnxH5OBJfDQFky6OSdPGK34MO1ztt5t0bNLA=; b=vpz8UupysdWaDsnLlCIEpprRUI4p87iVVIz3nTj5MNj8m5uOjpJmjDj2+UkVOUn0gVO+Y7sSldouiOaaIuTZVXW+bkeJD3Bcf2QowIBDhkQX8kWZmlAPrxb3klhRwcc/WlXt++IxS7y959Mi0zuZib8Q4pIMNkVCY0+dy5l24j7T3hEEBQoOEK7F4yTl39RtlPtvEdOXY8bDRZxAW0gtn/eNdBsQwvM22Ms0cGr1ntGChkorPIJA/O4qTOFpAxCYCtkKA+ut1hnd4Kyi/12c2rk77F4lhHcRvNmbkriZS9WnPq79GOpNVA2WI3B3ggcvmNHFGGC0KTsgMCPGVC0GzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lt1WBp8hnxH5OBJfDQFky6OSdPGK34MO1ztt5t0bNLA=; b=p/dPfgMv2WRw/6httAfR5vY6Ae7vozt0Gl9gp08ehuJ9qtdCYt78qxnRnt7bcPWzwq7bFWd/+zqeBKrRWJdkx91eErjU8g16CyyAZPj8zczFmLuTv/RsMt7SNuguFlOfgRnmEa3n3z3G/RsSH1w0ONo1d1xK8+UvLZE8Vq65Ul0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by LV8PR12MB9264.namprd12.prod.outlook.com (2603:10b6:408:1e8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 00:17:02 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 00:17:02 +0000 Message-ID: <44bcb906-bf90-4a0f-9d30-85d24cb291a6@amd.com> Date: Mon, 11 Nov 2024 00:16:58 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 09/17] net/r8169: add support for hw initialization To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241108121123.248797-1-howard_wang@realsil.com.cn> <20241108121123.248797-10-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241108121123.248797-10-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0045.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::14) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|LV8PR12MB9264:EE_ X-MS-Office365-Filtering-Correlation-Id: 1eef287b-aee9-40f2-af88-08dd01e62aa7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UHdYbjFjdUJVd2xEMks3YUV6aE5iLy9UeThsV0ltZkhQQUZpQ1d5ay9tYVpY?= =?utf-8?B?VEg1cXFQZTFKbDhWSHJPSS9ldTRGZG1yZFR4bDAvc0tERGVUNnZ0Zmx6SlAv?= =?utf-8?B?bExpUkFPUGNCZVB2L2laNlVJekNiVTRUTDBHUndhS21JdHF4cE9zdm1mTnZm?= =?utf-8?B?SUtPdVg3WWRaQWpFeHJRQnVrQmphT2F2a2JEM0xlSHdKRmYzSVRDbFRpaUww?= =?utf-8?B?MlFXQ3dFRkx0SFluUDFRY1l5YTkxNTJHUWtVUUVyUm9IT29UWGdOWjZlWG5X?= =?utf-8?B?Rmp6NjU3bmY2bUNJbEN6eG9nUEY3eDRsSStKTUkwMk9sblVHemFLWTk1bE1t?= =?utf-8?B?bGV2LzBBK09pK016UVBQN09uUUZidlVWZVJOWmRIRkNGd3NxUHJpc1QweXEw?= =?utf-8?B?WXdDTTBDM2ZTYmxKU283c2IyRUhOVTcwK3ZVSCtXb2c4UmNxNkxqZzQ4dHEx?= =?utf-8?B?Qjc4YnZqTmpMVVlVd1dlTkVuUWtHQkZralRHb21SeGpuL0JXZ3JYb2czVlBO?= =?utf-8?B?emlPanJrdnY3dE91Q0VpVGR5eEdFSHN4T3FYN2FUTDN5SGtoRXYrSDlQbUpV?= =?utf-8?B?RGh6OFpkNnhTbmFlNE5XWitQZy80VHhveUpEZ1ZmR3ROcEFEbkRFWTBOMkxl?= =?utf-8?B?OVFxa3E1TlBtTVdKVVpkdFRwU1hwZjc5NkM4ZFlxR2JncjMwanRiaE5oU1lD?= =?utf-8?B?YVc2b05UOWFtSkh1NzVmVUg2a295b0UrbGVFd3dXRnI5RGRlZG5UNFlObzY5?= =?utf-8?B?TVNvL2YxdThWc25qZXFoYjQ3SVE1a0tEY2NiVlZjb2pxTk1SVmZHRTJGVVNZ?= =?utf-8?B?RFF3dE40Y0MvWStXaStNK3pLZTJGdHZwOUdaSWdlUXNEQzhvMjRreVBHUXQ5?= =?utf-8?B?OUtBR1pxNWo0Y0hkQVJXYW1ndHNoQ0RheWkxOHNTMHNMRUZYeExsTGVLbVNL?= =?utf-8?B?OUVrcEJiaUhkWWtXdUNaWFlXVHBYSmFQeXZYWHgzUzViVUdPd1l3cFY4VkM0?= =?utf-8?B?eU1PTFBZcFJOazg4WHVrbXRoUXNsRzBpUXhCRzg2MzM1L1BnZEZweDBUeE4r?= =?utf-8?B?dzNSY21RcVJTN0tvV3JlMjJOTjdrMzBSazZacVhkbGFZVFNwR0R1cU1Hd3Fm?= =?utf-8?B?K0wvOWNlcDN4eTgzYktPNklZdUIyZEszZi81RnVidHBQcTE3MjVuM1llN1gw?= =?utf-8?B?OVJRTTBDMmhlOC9pSk1Ja3pLUUVsSVhzL3BzUG9DbktsM0ZrazFvUHJXeUdT?= =?utf-8?B?cW0yOE1XVGc5Rng3aHRrUTNORlNtbGNHaXdLN1FxazJHWEw4c3NpaXFhejdV?= =?utf-8?B?QnIxdU1xeHlxZkkxNEpSWlNINlM4SDBKSWxyVk16Ly9lUmUreVN2Rm5pOS8z?= =?utf-8?B?Y3R6Ynh4aExmZXlMSjQ0MXVCclNYdXoyZzFjSE41ditZK0tmMVVqMVNaZlBj?= =?utf-8?B?VWhHL2l6R0tRQUIzWlBsWU1HblVGTTdPY1ZRbitXK1N2SmRpeE5TQkMvRFVY?= =?utf-8?B?TDBkVTlmeWxhcDVCTEd4UVRpOEpTNmFUWWNuTTRpTnZ6cHhSSlBWVWs3VWt5?= =?utf-8?B?MzkzQUZUMCtBYmpDaERaTnRpTUhNNElGcEt4Qjc2TFBpMW52RnEvTURHdUtO?= =?utf-8?B?L3VnYzR1cGVjdkdvWEhWSjB2SVVXWHN0dk9xVlM5VWw3dzRTdWtvV08ySVFS?= =?utf-8?B?c3BZMGhWRUpHZHArV0hlZWFTcU1PQmZNbW9qeVBkTi9LbUFNblVjWGZHN2Z6?= =?utf-8?Q?zIrW2EqauqYoZH58+tNdcjEjhJUAEp5pDKC6vNg?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVpXajlZSWRIZ3BYcnRPZ2k2ekwvbHZQUzBYNnc3cFY3eE5sQUdPV3kreC9q?= =?utf-8?B?TnFRaXpXMFZaV0p3d1JMTjRpMmFCUFp1djQxMTFOdEtMWWQyWWRqaFc4ejBK?= =?utf-8?B?eWtpRElTRldrK1BudVNlT0ljMVVTanlHeVI4b2ErV2szK1E5V0RuRVpEdEt4?= =?utf-8?B?VXhyUElOMnZmbSs2ZTBvSTRCU1VEa3NTZUlZZ1BNMzdrTVF5ZFJma0taanhZ?= =?utf-8?B?NmZvdXYvYTcwN2ZKaUhsMUR0Q3RBWk1qUDhNVzFCeFBQcTBMTllZbFI2V0dM?= =?utf-8?B?WXlPQm1LWCthcEhJV09rbnYydlgwemJsU0JBQ09haGIrbElBRkliRmpjdXV1?= =?utf-8?B?ZHp1cER6WDRTZlQrTm1Cdm5YNTAzZXNSYzBPQTBwWFBRRHU5OUQvdXMyOWdI?= =?utf-8?B?NkxQczRiTWxKTDVFaGZCZ3pjS0NmYnVHdGlGMHM5a0N1Vy80akdkeXBFdzNi?= =?utf-8?B?ZG5LNm9JMVUwOWp0bkJoNktNSHdPNUtGb3pkallMelgvUVQ5UnFiaElVSDJE?= =?utf-8?B?TGl2bVVWQnpNeG1qZEs4LzM2VXI5ZEYxYjZvY3JNU29SVVhwU0YrUEJjS25a?= =?utf-8?B?b1JZQWl0aklPYTBOUmdLNEorR0FxVWFIOFFkKzA4eUl3VzdIUkF4c0VZTEow?= =?utf-8?B?Q1VrUDFUT1dxMzhRUWcrdVJhV3ZvK2hZc3VWeFl6bE5pbEQyRWFpOVY1c0VX?= =?utf-8?B?K1NZNmZaMWQzZmVYMnpuYUxOUHBFczYvTE9qY2hMSnpJR2VPY1l4Qlgrczhy?= =?utf-8?B?bjZkVHU1b3A3MDZBZjhxTzF4ZzhBQXZjVHd2OUxyOHptM3pVOWJONW16WVZu?= =?utf-8?B?LzhpdXF5akZ4OWt3M2xJcVk0UlRxekcycWhDbTg3ZkhVdklnZ1l4ZFB4cG9n?= =?utf-8?B?Z0ZFMm85dThoL3hwM0piaDVXeklLYXE0cVU1T0tYVDlqTnJkc1RVR3Y5aVR1?= =?utf-8?B?NFdOVDZrMjdIbkZyTStPdXpkdzJIWWtPTGtsV0lhUTFwamJMMit5ZkpYOTdT?= =?utf-8?B?N3NIWW8vT0FDMUw3dVNSQ25IWDMvVkhVb3lVWXU0MktIT3lYZFVWQlh6dytN?= =?utf-8?B?ZW03Uk15S2x1SjNWbkdoUVA5V0U5VzdwaWJuYUlKVUgxdFVpRmorb1B2c1Ax?= =?utf-8?B?ckhieGJTMXllSk1aRk5JeDFxWlNsVjlHNXZweS9leGxKdDNIcTJlbDlzMkFN?= =?utf-8?B?OSszREpyTWhTbjVBcUwvT291MERWMkxpR1JhOE1mVjRBT3NaaVNOWFR4WU5o?= =?utf-8?B?WHR1RjQyOWREQ010emdtUUZGR0luVnNYa1VlYzVsMjRGOWhTOGx0VVcvVDVE?= =?utf-8?B?cmNYZGRMUkJGckc0TEZvRWo2R1pncUtCYVhOemRUZG5xWW1kaFhhUTJKdm1N?= =?utf-8?B?QlBDTk14OUg4Vm56VG0yQ3c3QVhzd2MrV1JJR2lWSHQ2aDFWSFg3MVRhWkU0?= =?utf-8?B?Tjk5eEc2eXdobHNpdFBsV2I5b1cyY2RwaDJCWTBUNWNSVjY4RjV2VWpCRFdL?= =?utf-8?B?NDh4MTRpUHpFSmY2NzRPMldTVHZaazFSdWw5Zm1GVDI1M3Q1YnVKRTRSSUFo?= =?utf-8?B?T0s4cWVRU0VtVHoxTTFlamV2eTUzL1lPdkRFeTQvQnNMUHVSamNaZlpWOTdj?= =?utf-8?B?Q3Z1d2VCbkFhZEc3bHQ0TlVVWXpaRUtrWitWVFNKd1lnWjAveUowWGxrQmxr?= =?utf-8?B?Yy93Z1kzSWs0d0Jkb2VQYUduVTlvaS9EME1Jc1N0VkFNUWlYcExqQjZsTk1O?= =?utf-8?B?VzhmQ1dPQ1lwektkSVdsN096QnVTM0Y5eldOYldLS2E2Uys2aWJUVy8wNDZV?= =?utf-8?B?SzJ0SWYycjFleU9kY1FPM0UrdkEvbGdPUHNjaFl3ZjJaa1VkWmg4ZzNBSlhm?= =?utf-8?B?T0pkamE2dDZER1VDNFlxV29uRDBOS08vcVJUT2hlWDNBbFlrK2p3dUFabXJj?= =?utf-8?B?Y2E5WEhiOUhMS0JJaVBXOHo3M0tBUm9wRkk4NENIVnJpMzBWVG4zNk9hcmI5?= =?utf-8?B?SWhBVDFMMGZvbzNGbVBkVHRkQXlkUEdmdXNMbDFoNGZwUW10ZUxXMUFIZUpT?= =?utf-8?B?RHYybU9UaGJVT0FBcjJOcitnb0Fzbk9sbDJLdmRKQmFWZmZoVk9EYjRvQktK?= =?utf-8?Q?JG6y+F3j54MxJmZVWgQzvS0Th?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1eef287b-aee9-40f2-af88-08dd01e62aa7 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 00:17:02.7157 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vq/n6xYPQ2vW2KZE0DO32DBwvhmt2IwfeRbJIwg0iMtOnGez91RZahGFIUy/v3E8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9264 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2024 12:11 PM, Howard Wang wrote: > This patch initializes software variables, resets the NIC, and performs > other hw initialization tasks. > > Signed-off-by: Howard Wang > <...> > @@ -24,8 +24,8 @@ > #define MII_EXPANSION 0x06 /* Expansion register */ > #define MII_CTRL1000 0x09 /* 1000BASE-T control */ > #define MII_STAT1000 0x0a /* 1000BASE-T status */ > -#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */ > -#define MII_MMD_DATA 0x0e /* MMD Access Data Register */ > +#define MII_MMD_CTRL 0x0d /* MMD Access Control Register */ > +#define MII_MMD_DATA 0x0e /* MMD Access Data Register */ > Probably unintendent change. Also I can see 'MII_LPA', 'MII_RERRCOUNTER', 'ADVERTISE_LPACK' and a few more uses spaces instead of tab, which can be fixed in the patch they are added.