From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4375460D2; Wed, 22 Jan 2025 13:41:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 917B3402DB; Wed, 22 Jan 2025 13:41:06 +0100 (CET) Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010020.outbound.protection.outlook.com [52.101.69.20]) by mails.dpdk.org (Postfix) with ESMTP id 0DF15402BC for ; Wed, 22 Jan 2025 13:41:05 +0100 (CET) ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=pdp3d+NAFMxb8eCJOdmPkPKfFMotgTlj/cyBxvnPDlIgxcX4SI7mAhZg8Ij8GclPkU86X2OGFWILaqIo3kXJGPn2stcULvs9ZMTxhUJ7iYvtiuX2AiCf6qp30roekEAwwMEjjIxbr2af6Bni4j6HgMBd5R+x2O9gIgsq21UCEvmBcIf6zUuoVWga6yWXRb7xLhkXyT1Iv+gobn4l3dX4OkApUYoMi+W3SGW7YOQW2COGsQV9unKl0+YfrDukkyoOBOZofRIc7bRWt7XseY3CFGC9A14vZj68OUoPOXBWkmWU+bPwrhXv1hpvmUP0RhzF5nTU0y8CPqdxvIEnpU8oKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yCvY6iv7bDVkxH/sV4Ka21+x6Iq3zWKpqDucK6X7Ahk=; b=Z9iZ+iw10aDHQIDU+tHbaW+F0lEt0g8iLV1ANpdTd1b5UoqKUTwUm9sA+li+pDzO5XsUm3iEzleynOME+KSDIJyP56w7WbRrgdd3kQZa23ph7NCD0t79SHMMsW1kXWuRsVIJMUjESyVTsSLp93Frf58pmgKZtmOBDhTgfTWdlXfz3MTtHQchMmbQCHFgs6q5MavURIrP6qimnM2CVJvUtvAzjEarjRIek6rbZg+heZFdacB0Iuxd6/jad3emQFHQYXuxXSO259tZJ/sCr0ZHRhpOufbGHuXdqAejO+dQ86aYMyGN7RfXOrCdBcts8i1P36uNn4DuJ1Y1ZJG5oaoHxQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yCvY6iv7bDVkxH/sV4Ka21+x6Iq3zWKpqDucK6X7Ahk=; b=rtZjelkSv5nY4GUBq/vps/tW68T35RMl21MYTfmZ2CohIZEvVpagIVhoDzj2irqEejVNMrIRIQGHuOIuYhT73nqpZF3DjCiHeK4rlGymLoagYqw0tKF6hubDrcRSX4CkZZPRKNKrfCfkeBpiVUrdxFTaH7UtG6c8FJOgvitPRFQ= Received: from AS9PR01CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::20) by DBAPR08MB5749.eurprd08.prod.outlook.com (2603:10a6:10:1af::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.20; Wed, 22 Jan 2025 12:41:00 +0000 Received: from AMS0EPF000001AA.eurprd05.prod.outlook.com (2603:10a6:20b:540:cafe::c) by AS9PR01CA0018.outlook.office365.com (2603:10a6:20b:540::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8356.21 via Frontend Transport; Wed, 22 Jan 2025 12:41:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AMS0EPF000001AA.mail.protection.outlook.com (10.167.16.150) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8377.8 via Frontend Transport; Wed, 22 Jan 2025 12:41:00 +0000 Received: ("Tessian outbound db4187c85a3b:v543"); Wed, 22 Jan 2025 12:41:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4ea8a041c91a5068 X-TessianGatewayMetadata: 1aI32VXyxmdScPeNruHGPShho/5enjgOUy+id6uTD+ERwvc9qGnz2Z82Qc+b0f4HZmM/wFnt217hQYUVHcSvdwErmtKzaaCsCeOrKnQSYIfFfoL57g/dp+P14ICGt5oFaLUjpId/TT0lhUHpZnJq9Yx7TCFEROk4dfvhXee8ruE= X-CR-MTA-TID: 64aa7808 Received: from Lda816eb867fc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0D2734ED-AA3A-472A-A413-B3E700A32232.1; Wed, 22 Jan 2025 12:40:49 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id Lda816eb867fc.2 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 22 Jan 2025 12:40:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QrO0e/ZhY1/OwLwHlSWUUWG+g3il42wv9+XSLyn5oQY/RaZaU8hgxXyyaGfizFUKwu0drAu9ljN1a9wtuNIopVrZVN1oJJ7RjkQc8WSVdCzS6bA2vjoVFmJrEIwoIZY0QfshyjkZSUWcQ5ThTKVIZaMU004ohblz4Pw9EFxeMJuiA33ug7KbIny3wM6feKpRRQK2ZC+YgGDMmRxjEKvpjal3qri4NOsyuSkQvuv8jdsN2b/D7NIEf+jWeBxpuPFw/dMeb341xmFKZmLPo+J0e3/rUDD3ToZi7qIGysTlAfuDqREc2isQbNJPgf/Di22gkSBauDmUHUmEzuLvzlo83w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yCvY6iv7bDVkxH/sV4Ka21+x6Iq3zWKpqDucK6X7Ahk=; b=Zer9E69xHkPi6MWGd8A7/RRSOnOFAtobOnQYW+HgNtv0NVjB4vFljEvBOzkfaSeKgRIknmxSliA6K3yw1tTGNnwWtmNy1ydvRSKbiZA0gZTkQeMOD2IqtDESk4TiAPSEwg9AQKOHueyA7nYWvYrhePSBuDnx99Sy6Uv5UGnT9iEf0U1D4M7GGiPbrLdtNUIAbLXTyAGYHeAs7ms2yVZOFz11WWIq1f+RzGKdzYWc6K2gW7GYSKjFTeJUNLFmmq+GZrsGRlauNhFBOzYtCQGv5X9tf5NZh14Yl4GhTswhsqIGnLyjiLgnY3o1wpY/fd3EIdM8NUWm+Dzm6jIe5QSh9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yCvY6iv7bDVkxH/sV4Ka21+x6Iq3zWKpqDucK6X7Ahk=; b=rtZjelkSv5nY4GUBq/vps/tW68T35RMl21MYTfmZ2CohIZEvVpagIVhoDzj2irqEejVNMrIRIQGHuOIuYhT73nqpZF3DjCiHeK4rlGymLoagYqw0tKF6hubDrcRSX4CkZZPRKNKrfCfkeBpiVUrdxFTaH7UtG6c8FJOgvitPRFQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) by VI1PR08MB10220.eurprd08.prod.outlook.com (2603:10a6:800:1bd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.21; Wed, 22 Jan 2025 12:40:45 +0000 Received: from DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::2dd2:fd4d:8ff5:3733]) by DB4PR08MB8151.eurprd08.prod.outlook.com ([fe80::2dd2:fd4d:8ff5:3733%4]) with mapi id 15.20.8356.017; Wed, 22 Jan 2025 12:40:45 +0000 Message-ID: <44f70340-a441-406f-b514-955db2180038@arm.com> Date: Wed, 22 Jan 2025 12:40:42 +0000 User-Agent: Mozilla Thunderbird Cc: nd@arm.com, dev@dpdk.org Subject: Re: [PATCH v1] dts: fix checksum suite docstring/variable format Content-Language: en-US To: Dean Marx , probb@iol.unh.edu, npratte@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com References: <20250116184322.2750-1-dmarx@iol.unh.edu> From: Paul Szczepanek In-Reply-To: <20250116184322.2750-1-dmarx@iol.unh.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::20) To DB4PR08MB8151.eurprd08.prod.outlook.com (2603:10a6:10:381::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB4PR08MB8151:EE_|VI1PR08MB10220:EE_|AMS0EPF000001AA:EE_|DBAPR08MB5749:EE_ X-MS-Office365-Filtering-Correlation-Id: bc772d4f-c783-467c-d47d-08dd3ae206a4 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?Y3U1TzVhVzF6dGpMdlp0WXJ5Z09iMUZzd0NzSEtLcFFNczRJcGRVUnh5ZUZO?= =?utf-8?B?VkNVeEd4TkpwYWJMREthMWhBcldGaWNIMzVzekNaTFZ4VjlwZkhLR2JERG9M?= =?utf-8?B?Q05NQ2VpUGFpejFhc1k4VlJtcUs3eFkvUVI5T1BPMVR0elZYS0Yrek9EOXpE?= =?utf-8?B?RWFGQzFCM0l2UEdrcUNtVFpJVFREUjFKQkFUNkMrYW9PeHVRV21nbDY3TDNz?= =?utf-8?B?VmhMdncySmh0cmVqeXBPQkcwbzltSDhHTW5rOVgxb3N3STFVRnY2RzZSbTQy?= =?utf-8?B?NHZiWE1WN2dhSlJDZCt1Y2xHWDVyM3dvaEZ3ajNpZUhwSVAwNkpzay8vS0M3?= =?utf-8?B?QWlLaHFwMFFTRlRERm92blZkUTFyM2hkNVR3N1Nwdk4yY05MdFlqQ0tWMnlt?= =?utf-8?B?K3ErS3VLU1dBY0UwYmI3SUdQOXA0K1lnSkRtTEdZdmtsQUM0QnF0bzZsclc4?= =?utf-8?B?aHFUci9MNkNOR2JoWXdNSnB3THdzdG5RTWZDbFJERkgwTC8zYTZCbFFlK3ky?= =?utf-8?B?Y1ZwVUUzeWM1bjlrM3ZVcUFqSjYrU296UzE0VVQ0OHNwVUQ1T0ZyWXNnbThD?= =?utf-8?B?TVNNL2VMMmg2WThKWm1mdTAxZmZzUjJIc3RTVWdKV082ZW5XRitSSVNKOHU5?= =?utf-8?B?UEtlWkROWVY0ODdOUFhjUExzblJwcWcrMExyT2ppdFVlUFJnOWY2UXhMYklR?= =?utf-8?B?bEt2MVJSL1M4UWpLR3NTWUc3M3JEV2U3NGxCLzFYc2t6MkRjbFZZcncvV3lF?= =?utf-8?B?NjhMQ1BscHMvTXVySDZHYUZoNDV4dTNqb2VLaFo5U0xId2FtenNpTCtyaDg2?= =?utf-8?B?N2ZPRXhYUnhLV0RzOXBhTC8yUGZqWnpyTWhlUHR5OXRqb3Z0VTkzSWdMbzJN?= =?utf-8?B?SkdpTlZDZDkwN0tRTFZKdUlRVm1FbWIvckVpbkI3bEljWTc1VUJWS25nTnpZ?= =?utf-8?B?MnkxV282K0RBVGZQZVpwaFc4RHlZQlVzOW9Md0czb1RXV2NGTWFXcVhLYWJx?= =?utf-8?B?VGtvM1pWbExxdksyNnNUMzFpMTZ5ZUZsWkdXSmI5N1dIS2ZzVVdscDFFVm8z?= =?utf-8?B?SmhuM3BuT2thVWxYY3BJWFR1dE1JVXRYOWIyeHZLZmMxZlVRQytCWmZrTWJx?= =?utf-8?B?YzRreEdseC9aS1F1SjdVNEdLQVgzTXJ2b2d4WUdGblduT2htaE9DWlhpcEZk?= =?utf-8?B?NS9Gc2Y1cmFiS3FzYStrcVVtZHpTZGxEcE5Ncjk1d01YQVNGVksrdjdudENR?= =?utf-8?B?clgzRFR4MHk2a2RBTld1OG1EeXFDcmN3Nlo4U09keVpPZkVDNEd6eitMS21M?= =?utf-8?B?NUtTQzFSVDFtNW5yU2RvSzVRZTZpdE9mb0NtZUpZNlMzdVFrL0hRS0xDZXVL?= =?utf-8?B?QTVOazQrQW1MYjZhMTZBKzVGdm9ieDVxbUxuTU5wdkxEcy9Uc0VHY0JBYlJh?= =?utf-8?B?ckRPNXJVS1FJUS91bm5nKzc3L3RYZVJhUUxhM0EvRUlSUXRHRmpDVTI5VjVM?= =?utf-8?B?UC9PTlltemdzbFJMdVpLZ0hUSTM1cEV2WlVuTnN2WWxZZ2JLdmJpY3N1N2FK?= =?utf-8?B?Um1rN2pWUFVGdy9wRmg0dEtEelEyT3lJUjZFSFF3T3dYRVlHdEh3VjdZT3VS?= =?utf-8?B?MjNMeDZUbWdYL2NNL3Uvb3hFT0NZTFJJSlNQcTJjaGthTmhjcU1nMHNTQmpZ?= =?utf-8?B?K0pkZkU3ZW1NaVBRZVVMWUcrVDMzT0czQ0N3ZE9EdTBZbjIyYnk4ZUFaTUtJ?= =?utf-8?B?ZkJMUTN5TUZiMDdsL2VraWp6MCszMXd6eUNJcWgrTlUzSHlwQkdpeURkdmo2?= =?utf-8?B?UW9WTEs3cDg3ZTNwdDRyYUxuK0IyeExvUFJmd0tIYTJtb2t2OFdJb0x6dnpR?= =?utf-8?Q?HEC+wiuxJ8Nbv?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR08MB8151.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(7053199007); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB10220 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-SkipListedInternetSender: ip=[2603:10a6:10:381::16]; domain=DB4PR08MB8151.eurprd08.prod.outlook.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001AA.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e0b1ece-682a-4d68-2380-08dd3ae1fd52 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|35042699022|36860700013|14060799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MmgyWm5PWG9QemlGTlZaSExWZ3RzbkxYMkFSejh2TWhWTEVZVDZWYUVTS20v?= =?utf-8?B?Nmt0YzB1ZHRsTVl0N0xqQTI5WEVYRlVuQXF2VkZMdjNDL2ZCbkZabE16d2ZE?= =?utf-8?B?R1ZBc3dWa1ZTTmZUTXpNU1hGR3FXUGZXWVZ6M2JLRzdCaXlwZlN2VWNUVzYw?= =?utf-8?B?cFVXRmlyQjU5U3ZVZU15aVlvdGJad2tsMFhFZVR1aXlhbHhjWnphYXhtTVkr?= =?utf-8?B?bnM5eHhIQ2JITnhTalFXT2NvT0JLK242TlFGV0tJVk1yNHAwSkI5d2Zqb2hR?= =?utf-8?B?SDR1b0kxYUx3ZFlLV3p0eW0xenpKaERpcytweUQ1ODJMWWxpcmlzb3lodWc5?= =?utf-8?B?dG1tVHI2V2tRdy9yejk5NDczYmFFY2wxSVFQWEZ6YWE5Z2kzZVo3WUovZEdt?= =?utf-8?B?blFXMWR1b1lFTmtzaWh5RHRzYmhDaDk4SStHRjVCL3JTOWdaWlJ2VkY1d3RX?= =?utf-8?B?aW9XWlliY2Zrbml3OVdsNmM5K2xaOGRnTks0S2VUS0NEbFIwUm01K0dKMEdk?= =?utf-8?B?T3l3bHJEakxFalRpbmI2NFlsdnlDOHBwTCsxTDFMaERnVGN1WHA0YmdETmQ4?= =?utf-8?B?ejMyM0xvTlViSDEwUklYN3djRWphYWFaTHNOa0w2TDRtOXJpbm9tcmRqaE9k?= =?utf-8?B?NGoydTh1NkprbENzZUEzZ1lLY0VuOU0wcTZUbVQ4VzU1cjE4cm4yRUE5cjNo?= =?utf-8?B?cWllOVA1RUJGY29HMGlsaGNlb01nRHJFWEtMeXBGNHNXUkxTdUVnZldaWS91?= =?utf-8?B?NGhYOVI0Q3YrQ1RDVVo2SGxGM1JUdGgvTThoUzNCYld4WTM4QVRBbHkxQTA1?= =?utf-8?B?aG1kaGZoWkIvdGZSZDdKdTJsaHZ1ZmtLMVBJT1ZKSERpQ09VS3lReU9RamRF?= =?utf-8?B?b2xWcjJHNjhGTk55VThoZnBWUlVhL21tUlh0a3JVSTJiY2lReTlWQ21oY3VE?= =?utf-8?B?T3NmY0F1RWh1TjR4MWg1R0NWUWFhTVk3U1ZYK1dlNFRBNnFrRitmVG43WWVG?= =?utf-8?B?VmNIZEZ2MExxRm9UVzZPWG9kd21OVFlOOU9PUkowZU54K0hNdFpWbFE1Sm4w?= =?utf-8?B?YWs3dE4wcUZWTWtqNms3RjhJNUZkdElDMnNaSmNtd1M4Rm4yTjlOVkRrRGV1?= =?utf-8?B?bWdaVG55NUVhRVoxZnEzMEdCQ2JlNmZ0YWhJZEJQWEMwSmNEOVpPYlkzdGRW?= =?utf-8?B?V1FoL0dXeW5mWkRQc3JPMGlzcTdzeFU1YklRRVR4WGw2czZVRU9qSy84V0ds?= =?utf-8?B?d1ZtMVVkcCtIaFlXOVFMdjZJR0p1Qm9TaG9xUk5tc1Rmd202REhGQlNGNUQx?= =?utf-8?B?QjB6TVBPM3QzVjFieERQZHZKdzBtVDlVNktnOEJENmF2aGE4VHptbTVyQ096?= =?utf-8?B?U0MrOUhncU5xcnNOWmhSN3B6bGl3dXc5eStIQUwzOWUwQWlaQlhSemdEN2Y1?= =?utf-8?B?VjE2VUdwcTNiSEJpRWhHcWxvWDNnM2FWcWs0NUl3RktNcEl3VHRkL29nRTYv?= =?utf-8?B?S1NkR0dPY2NuaGZhVzIzb1FOSVpRMVR5aTBnMFVHYXczQ3hwbjdIVWlpQ0tX?= =?utf-8?B?ajVnY1ZmdWtZYUVpbUtsc3I0a1FLK1NhZG1MVmVCdTJoalg3Q1ZvY1hUT2Mz?= =?utf-8?B?R1E4alZ1dGZ1a1gwK1ZVK2VDNVh2c29oOUtpcktSbFBGYjhyek9scEl1cE5i?= =?utf-8?B?MUdUQjQwWTVZWG9nZC9FdlZNcFZzalJ3UG5GbEtpdVAvNVRxZUVucUhHcllu?= =?utf-8?B?T3NjY3ZYT0Z6L1p5b2RWNGhaV29kZS9meUtBdHBUdzNwQVM0U1B3L3FDRUR5?= =?utf-8?B?Yzd4T2V5YTRFb2VuV1IybTFQdSt2TXkrcVE1K25PSkN0K3JTY01iVlJkR2lm?= =?utf-8?B?RmJwTTU2bnd2ajVRMEVpL05PTUhaMjM2QWlwS3BMTit4d1lhSGZKeE16ZURN?= =?utf-8?B?RVlBeTNRVWNNUDJ6aHFrYUlnY1VkTE1uK1FyeU1sZFZYbXY3aG43eXcyZHQy?= =?utf-8?Q?Vmfx5fCUklTUlBUGQO9TtkUpep6M7M=3D?= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:64aa7808-outbound-1.mta.getcheckrecipient.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(35042699022)(36860700013)(14060799003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2025 12:41:00.4026 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bc772d4f-c783-467c-d47d-08dd3ae206a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001AA.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5749 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Reviewed-by: Paul Szczepanek On 16/01/2025 18:43, Dean Marx wrote: > Fixes checksum offload test suite docstring format > by adding steps and verify sections. Changes variables > formatted in camel case to snake case to fit python standards. > > Fixes: 8c9a7471a0e6 ("dts: add checksum offload test suite") > > Signed-off-by: Dean Marx > --- > dts/tests/TestSuite_checksum_offload.py | 127 ++++++++++++++++++------ > 1 file changed, 99 insertions(+), 28 deletions(-) > > diff --git a/dts/tests/TestSuite_checksum_offload.py b/dts/tests/TestSuite_checksum_offload.py > index c1680bd388..4c9520917a 100644 > --- a/dts/tests/TestSuite_checksum_offload.py > +++ b/dts/tests/TestSuite_checksum_offload.py > @@ -57,7 +57,7 @@ def send_packets_and_verify( > packet_list: List of Scapy packets to send and verify. > load: Raw layer load attribute in the sent packet. > should_receive: Indicates whether the packet should be received > - by the traffic generator. > + by the traffic generator. > """ > for i in range(0, len(packet_list)): > received_packets = self.send_packet_and_capture(packet=packet_list[i]) > @@ -70,15 +70,15 @@ def send_packets_and_verify( > ) > > def send_packet_and_verify_checksum( > - self, packet: Packet, goodL4: bool, goodIP: bool, testpmd: TestPmdShell, id: str > + self, packet: Packet, good_L4: bool, good_IP: bool, testpmd: TestPmdShell, id: str > ) -> None: > """Send packet and verify verbose output matches expected output. > > Args: > packet: Scapy packet to send to DUT. > - goodL4: Verifies RTE_MBUF_F_RX_L4_CKSUM_GOOD in verbose output > + good_L4: Verifies RTE_MBUF_F_RX_L4_CKSUM_GOOD in verbose output > if :data:`True`, or RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN if :data:`False`. > - goodIP: Verifies RTE_MBUF_F_RX_IP_CKSUM_GOOD in verbose output > + good_IP: Verifies RTE_MBUF_F_RX_IP_CKSUM_GOOD in verbose output > if :data:`True`, or RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN if :data:`False`. > testpmd: Testpmd shell session to analyze verbose output of. > id: The destination mac address that matches the sent packet in verbose output. > @@ -88,10 +88,10 @@ def send_packet_and_verify_checksum( > verbose_output = testpmd.extract_verbose_output(testpmd.stop()) > for testpmd_packet in verbose_output: > if testpmd_packet.dst_mac == id: > - isIP = PacketOffloadFlag.RTE_MBUF_F_RX_IP_CKSUM_GOOD in packet.ol_flags > - isL4 = PacketOffloadFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in packet.ol_flags > - self.verify(isL4 == goodL4, "Layer 4 checksum flag did not match expected checksum flag.") > - self.verify(isIP == goodIP, "IP checksum flag did not match expected checksum flag.") > + is_IP = PacketOffloadFlag.RTE_MBUF_F_RX_IP_CKSUM_GOOD in packet.ol_flags > + is_L4 = PacketOffloadFlag.RTE_MBUF_F_RX_L4_CKSUM_GOOD in packet.ol_flags > + self.verify(is_L4 == good_L4, "Layer 4 checksum flag did not match expected checksum flag.") > + self.verify(is_IP == good_IP, "IP checksum flag did not match expected checksum flag.") > > def setup_hw_offload(self, testpmd: TestPmdShell) -> None: > """Sets IP, UDP, and TCP layers to hardware offload. > @@ -108,7 +108,18 @@ def setup_hw_offload(self, testpmd: TestPmdShell) -> None: > > @func_test > def test_insert_checksums(self) -> None: > - """Enable checksum offload insertion and verify packet reception.""" > + """Enable checksum offload insertion and verify packet reception. > + > + Steps: > + Create a list of packets to send. > + Launch testpmd with the necessary configuration. > + Enable checksum hardware offload. > + Send list of packets. > + > + Verify: > + Verify packets are received. > + Verify packet checksums match the expected flags. > + """ > mac_id = "00:00:00:00:00:01" > payload = b"xxxxx" > packet_list = [ > @@ -125,12 +136,22 @@ def test_insert_checksums(self) -> None: > self.send_packets_and_verify(packet_list=packet_list, load=payload, should_receive=True) > for i in range(0, len(packet_list)): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=True, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=True, good_IP=True, testpmd=testpmd, id=mac_id > ) > > @func_test > def test_no_insert_checksums(self) -> None: > - """Disable checksum offload insertion and verify packet reception.""" > + """Disable checksum offload insertion and verify packet reception. > + > + Steps: > + Create a list of packets to send. > + Launch testpmd with the necessary configuration. > + Send list of packets. > + > + Verify: > + Verify packets are received. > + Verify packet checksums match the expected flags. > + """ > mac_id = "00:00:00:00:00:01" > payload = b"xxxxx" > packet_list = [ > @@ -146,12 +167,22 @@ def test_no_insert_checksums(self) -> None: > self.send_packets_and_verify(packet_list=packet_list, load=payload, should_receive=True) > for i in range(0, len(packet_list)): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=True, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=True, good_IP=True, testpmd=testpmd, id=mac_id > ) > > @func_test > def test_l4_rx_checksum(self) -> None: > - """Tests L4 Rx checksum in a variety of scenarios.""" > + """Tests L4 Rx checksum in a variety of scenarios. > + > + Steps: > + Create a list of packets to send with UDP/TCP fields. > + Launch testpmd with the necessary configuration. > + Enable checksum hardware offload. > + Send list of packets. > + > + Verify: > + Verify packet checksums match the expected flags. > + """ > mac_id = "00:00:00:00:00:01" > packet_list = [ > Ether(dst=mac_id) / IP() / UDP(), > @@ -165,16 +196,26 @@ def test_l4_rx_checksum(self) -> None: > self.setup_hw_offload(testpmd=testpmd) > for i in range(0, 2): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=True, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=True, good_IP=True, testpmd=testpmd, id=mac_id > ) > for i in range(2, 4): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=False, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=False, good_IP=True, testpmd=testpmd, id=mac_id > ) > > @func_test > def test_l3_rx_checksum(self) -> None: > - """Tests L3 Rx checksum hardware offload.""" > + """Tests L3 Rx checksum hardware offload. > + > + Steps: > + Create a list of packets to send with IP fields. > + Launch testpmd with the necessary configuration. > + Enable checksum hardware offload. > + Send list of packets. > + > + Verify: > + Verify packet checksums match the expected flags. > + """ > mac_id = "00:00:00:00:00:01" > packet_list = [ > Ether(dst=mac_id) / IP() / UDP(), > @@ -188,16 +229,26 @@ def test_l3_rx_checksum(self) -> None: > self.setup_hw_offload(testpmd=testpmd) > for i in range(0, 2): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=True, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=True, good_IP=True, testpmd=testpmd, id=mac_id > ) > for i in range(2, 4): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=True, goodIP=False, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=True, good_IP=False, testpmd=testpmd, id=mac_id > ) > > @func_test > def test_validate_rx_checksum(self) -> None: > - """Verify verbose output of Rx packets matches expected behavior.""" > + """Verify verbose output of Rx packets matches expected behavior. > + > + Steps: > + Create a list of packets to send. > + Launch testpmd with the necessary configuration. > + Enable checksum hardware offload. > + Send list of packets. > + > + Verify: > + Verify packet checksums match the expected flags. > + """ > mac_id = "00:00:00:00:00:01" > packet_list = [ > Ether(dst=mac_id) / IP() / UDP(), > @@ -215,21 +266,31 @@ def test_validate_rx_checksum(self) -> None: > self.setup_hw_offload(testpmd=testpmd) > for i in range(0, 4): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=True, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=True, good_IP=True, testpmd=testpmd, id=mac_id > ) > for i in range(4, 6): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=False, goodIP=False, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=False, good_IP=False, testpmd=testpmd, id=mac_id > ) > for i in range(6, 8): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=False, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=False, good_IP=True, testpmd=testpmd, id=mac_id > ) > > @requires(NicCapability.RX_OFFLOAD_VLAN) > @func_test > def test_vlan_checksum(self) -> None: > - """Test VLAN Rx checksum hardware offload and verify packet reception.""" > + """Test VLAN Rx checksum hardware offload and verify packet reception. > + > + Steps: > + Create a list of packets to send with VLAN fields. > + Launch testpmd with the necessary configuration. > + Enable checksum hardware offload. > + Send list of packets. > + > + Verify: > + Verify packet checksums match the expected flags. > + """ > mac_id = "00:00:00:00:00:01" > payload = b"xxxxx" > packet_list = [ > @@ -246,17 +307,27 @@ def test_vlan_checksum(self) -> None: > self.send_packets_and_verify(packet_list=packet_list, load=payload, should_receive=True) > for i in range(0, 2): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=False, goodIP=False, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=False, good_IP=False, testpmd=testpmd, id=mac_id > ) > for i in range(2, 4): > self.send_packet_and_verify_checksum( > - packet=packet_list[i], goodL4=False, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[i], good_L4=False, good_IP=True, testpmd=testpmd, id=mac_id > ) > > @requires(NicCapability.RX_OFFLOAD_SCTP_CKSUM) > @func_test > def test_validate_sctp_checksum(self) -> None: > - """Test SCTP Rx checksum hardware offload and verify packet reception.""" > + """Test SCTP Rx checksum hardware offload and verify packet reception. > + > + Steps: > + Create a list of packets to send with SCTP fields. > + Launch testpmd with the necessary configuration. > + Enable checksum hardware offload. > + Send list of packets. > + > + Verify: > + Verify packet checksums match the expected flags. > + """ > mac_id = "00:00:00:00:00:01" > packet_list = [ > Ether(dst=mac_id) / IP() / SCTP(), > @@ -268,8 +339,8 @@ def test_validate_sctp_checksum(self) -> None: > testpmd.csum_set_hw(layers=ChecksumOffloadOptions.sctp) > testpmd.start() > self.send_packet_and_verify_checksum( > - packet=packet_list[0], goodL4=True, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[0], good_L4=True, good_IP=True, testpmd=testpmd, id=mac_id > ) > self.send_packet_and_verify_checksum( > - packet=packet_list[1], goodL4=False, goodIP=True, testpmd=testpmd, id=mac_id > + packet=packet_list[1], good_L4=False, good_IP=True, testpmd=testpmd, id=mac_id > )