From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 35C3D1B651 for ; Thu, 2 Nov 2017 21:35:08 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2017 13:35:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,335,1505804400"; d="scan'208";a="331297191" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.226.36]) ([10.241.226.36]) by fmsmga004.fm.intel.com with ESMTP; 02 Nov 2017 13:35:07 -0700 To: Adrien Mazarguil , Matan Azrad Cc: dev@dpdk.org, Ophir Munk References: <1509358049-18854-1-git-send-email-matan@mellanox.com> <1509640971-8637-1-git-send-email-matan@mellanox.com> <20171102170725.GJ24849@6wind.com> From: Ferruh Yigit Message-ID: <44f795b0-eb23-5553-f16d-6d0c54932088@intel.com> Date: Thu, 2 Nov 2017 13:35:07 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102170725.GJ24849@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 0/8] net/mlx4: Tx path improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Nov 2017 20:35:09 -0000 On 11/2/2017 10:07 AM, Adrien Mazarguil wrote: > On Thu, Nov 02, 2017 at 04:42:43PM +0000, Matan Azrad wrote: >> v1: >> This series is a follow-up of the new datapath implementation introduced in RC1. >> It is dedicated to Tx and improves the performance. >> >> v2: >> Change uint32_t be_lkey to rte_be32_t lkey >> >> v3: >> Rebase to 17.11-rc2. >> Remove "net/mlx4: save lkey in big-endian format" patch which degrade performance. >> Merge separate segment cases patches "net/mlx4: improve performance of one Tx segment" and "net/mlx4: separate Tx for multi-segments". >> "net/mlx4: inline more Tx functions" renamed to "net/mlx4: associate MR to MP in a short function". >> Leave bytes counter as old version. >> Add memory barrier improvement patch. >> Remove empty segment support. >> >> v4: >> Remove "net/mlx4: remove empty Tx segment support" patch. >> Add "fix ring wraparound compiler hint" patch. >> Add "fix HW memory optimizations careless" patch. >> Remove unnecessary IO memory barrier in completion function. >> Remove inline declaration of completion function. >> Fix unnecessary empty lines. >> Fix indetations. >> Move max=0 check removal to patch "remove duplicate handling in Tx burst" and rename the patch. >> Add performace improvement in patch "mitigate Tx path memory barriers" >> >> v5: >> Fix compilation issue in debug mode for patch "net/mlx4: associate MR to MP in a short function". >> Add missing includes in "net/mlx4: associate MR to MP in a short function". >> Add cq_uar as volatile too in "net/mlx4: fix HW memory optimizations careless". >> Fix indentation issues in "net/mlx4: separate Tx segment cases". > > OK for this version, although looks like you didn't include: > > "net/mlx4: fix missing include" > > in front of the series. mlx4_utils.h remains to be fixed, although I don't > think a v6 is needed for such a minor commit. > > Ferruh, can you apply the above patch first for consistency? Yes I can, no need a new version for this. > > Thanks. >