From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBE46A0559; Mon, 16 Mar 2020 15:25:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 021A52BF9; Mon, 16 Mar 2020 15:25:49 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4AF09FEB for ; Mon, 16 Mar 2020 15:25:48 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 61CDC5C0391; Mon, 16 Mar 2020 10:25:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 16 Mar 2020 10:25:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=38qcTxWilr+9ctnkKG2WSrFZkc2tZZUEmU+K1Yega4g=; b=p2uVPUvTk6+T di8zswY52b5Hb7TYVbIg/2f2Z87V93fEkdFwjYTg08Wsygp9XzeMF5sM2QEfehvb LlL8LbXx2e3ydvEvAbDV46BnAYaec+R5yScRL6h6r98dMStuwMeOGHAgDU6PH8o+ n8bGMXukfVr2leQCARukFS3q8ByjnD0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=38qcTxWilr+9ctnkKG2WSrFZkc2tZZUEmU+K1Yega 4g=; b=3u+D30Awal492x0wFCx0x8wzHVIl2gJUkX/BJU45nDlgQvytZhATL4hD9 Mm+V1insrM7Xr6sxYxT2fos752hfueGXHfEC5AP1E9gUWC0V90R2IL5w4d+1CxmE ojFuja5tJ0RY9gdrj4UH7x6WoBaqvv7CyRpEpKxe918W5P86Z2cwB6A9Hn+t+mBg bP6lVduW+YkSH7nrEq6VctVc/EtT/ZBj5BKvKQsGnjFygcqZeAhdlCfQn1Nb1xYK k+r2rYXhumhcU5cOMhNIlQy3F8OYRvI6QJUSTh/9arxr6/QDQzi8ZlN5Jg0plF9l SwBhiPQ2GfLFZp92sZcKGBjecjzdw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudeffedgieegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9CE1B328005E; Mon, 16 Mar 2020 10:25:45 -0400 (EDT) From: Thomas Monjalon To: bruce.richardson@intel.com, dmitry.kozliuk@gmail.com Cc: dev@dpdk.org, david.marchand@redhat.com, Jerin Jacob , Gavin Hu , Jan Viktorin , Cristian Dumitrescu Date: Mon, 16 Mar 2020 15:25:44 +0100 Message-ID: <4502147.F8r316W7xa@xps> In-Reply-To: <20200316120454.933575-1-thomas@monjalon.net> References: <20200316120454.933575-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix compiler detection in public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/03/2020 13:04, Thomas Monjalon: > RTE_TOOLCHAIN_* macros are defining the target compiler. > Some API may be used in a host application like pmdinfogen. > That's why the the public headers should check the effective compiler > in use instead of the target compiler. > > Detecting the compiler with macros is easy, except for __GNUC__ > which is defined in all compilers supporting some GNU compatibility. > > It is improved by defining RTE_CC_CLANG, RTE_CC_ICC and RTE_CC_GCC. > The extra macro RTE_CC_IS_GNU is defined to 0 or 1 in GCC case, > so it can be used simply with #if. > > Signed-off-by: Thomas Monjalon > --- > > This patch is probably useless. > The first intent was fixing pmdinfogen compilation with clang > while compiling the target with GCC, with MinGW support patch. > > This case is now better fixed with a patch removing EAL dependencies > from the PCI library, which drops rte_common.h inclusion from pmdinfogen: > http://patches.dpdk.org/patch/66701/ Actually rte_common.h is directly included by buildtools/pmdinfogen/pmdinfogen.c so we need this patch in my opinion. > As a consequence, I send this EAL patch just in case we need it > in future. We can decide to apply or leave it. This patch is now gating acceptance of MinGW support.