From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D62C3A0487 for ; Mon, 1 Jul 2019 20:03:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C251A1B974; Mon, 1 Jul 2019 20:03:27 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 26C451B96E; Mon, 1 Jul 2019 20:03:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6238521D2B; Mon, 1 Jul 2019 14:03:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 01 Jul 2019 14:03:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PyebWAhPV/sV2ZbST5at+szXGp5LKWzgrylgbIkmvXU=; b=Z+Oa9cFGbm+5 MzVdKWNGZvmXnHWx8tisiN5+dl+blcY15ayr3z+zQhvgJduhlLweA2i6JA3jNlpS HgNQYwWb8+Hw/BVn9SAid+uLYvD91SZjtuVzYwOHQfePwUEQbSRi6awOTE8hlzZY jepba+ekEIuaM9XVd5bUVUMHy/MWGTY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=PyebWAhPV/sV2ZbST5at+szXGp5LKWzgrylgbIkmv XU=; b=m0fX+/SgU4Z/D5rYmEftiZe8OPsk9A7JxQiMWRVcYiTuDFX4+Y6lP/g23 TYhoPhGTSUh+fsayOSrrO2Wyy4y8yqjrev3EYwiUnZ87Kw0elvdAD4I3hd2VAU6V eOgoj3/z5gV6XN97MM6Ld8u5OUj4uC9wuCk6mH1DHwZlB0A9ckX/xztCTArXQB5z 7cTc02r+X9zK8GxNM9AJMa3CZ8UuvQt7AjUDfPlMEGuHVBBBhK7U4kGdtsoU74xJ VLkFS+Dl48bAStwzP7jBJgxBmZYoB5WJzIe82erTnCRD2s5U5K7T322egRpSu/MM LDwv+OJrYWlFOa0UVGYc0vF8k7ijA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdeigdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D3FEA80070; Mon, 1 Jul 2019 14:03:24 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, dev@dpdk.org, shreyansh.jain@nxp.com Date: Mon, 01 Jul 2019 20:03:23 +0200 Message-ID: <4502927.5MotF66W6e@xps> In-Reply-To: <20190621155659.29297-2-bruce.richardson@intel.com> References: <20190619170802.7691-1-bruce.richardson@intel.com> <20190621155659.29297-1-bruce.richardson@intel.com> <20190621155659.29297-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] raw/skeleton: fix failing test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/06/2019 17:56, Bruce Richardson: > Rawdev unit test for setting and getting parameters is failing because > of a pointer value being dereferenced after the memory it pointed to is > freed. > > The freeing of the malloced memory is difficult when using asserts to > cause early abort of the test cases, since that can leak memory. The > original placement of the free call caused a memory leak if the test > finished early, while a fix for that leak caused the test to fail at > times due to the memory variable being referenced after free. For a case > like this, using stack rather than heap memory is just easier and avoids > all issues. > > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases") > Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure") > Cc: shreyansh.jain@nxp.com > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson This test is already fixed by another patch: http://git.dpdk.org/dpdk/commit/?id=dcb1595956